From 0e42423d03b6cfe856289f99bb18a0bb4c4dc2b0 Mon Sep 17 00:00:00 2001 From: Kyle D Kavanagh Date: Tue, 29 Jan 2019 16:04:42 -0800 Subject: [PATCH 1/2] Header validation warning on non-uint16 types instead of error --- .../main/java/uk/co/real_logic/sbe/xml/CompositeType.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java index 1086a86fd7..d66f5390f4 100644 --- a/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java +++ b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java @@ -323,7 +323,7 @@ else if (blockLengthType.primitiveType() != UINT16) } else if (templateIdType.primitiveType() != UINT16) { - XmlSchemaParser.handleError(node, "\"templateId\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"templateId\" must be UINT16"); } if (schemaIdType == null) @@ -332,7 +332,7 @@ else if (templateIdType.primitiveType() != UINT16) } else if (schemaIdType.primitiveType() != UINT16) { - XmlSchemaParser.handleError(node, "\"schemaId\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"schemaId\" must be UINT16"); } if (versionType == null) @@ -341,7 +341,7 @@ else if (schemaIdType.primitiveType() != UINT16) } else if (versionType.primitiveType() != UINT16) { - XmlSchemaParser.handleError(node, "\"version\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"version\" must be UINT16"); } } From aa9685a0810d68c98a274efdb3013903b4172ff5 Mon Sep 17 00:00:00 2001 From: Kyle D Kavanagh Date: Tue, 29 Jan 2019 16:16:49 -0800 Subject: [PATCH 2/2] grammar on warn --- .../main/java/uk/co/real_logic/sbe/xml/CompositeType.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java index d66f5390f4..7e2f038449 100644 --- a/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java +++ b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java @@ -323,7 +323,7 @@ else if (blockLengthType.primitiveType() != UINT16) } else if (templateIdType.primitiveType() != UINT16) { - XmlSchemaParser.handleWarning(node, "\"templateId\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"templateId\" should be UINT16"); } if (schemaIdType == null) @@ -332,7 +332,7 @@ else if (templateIdType.primitiveType() != UINT16) } else if (schemaIdType.primitiveType() != UINT16) { - XmlSchemaParser.handleWarning(node, "\"schemaId\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"schemaId\" should be UINT16"); } if (versionType == null) @@ -341,7 +341,7 @@ else if (schemaIdType.primitiveType() != UINT16) } else if (versionType.primitiveType() != UINT16) { - XmlSchemaParser.handleWarning(node, "\"version\" must be UINT16"); + XmlSchemaParser.handleWarning(node, "\"version\" should be UINT16"); } }