Skip to content

fix(daemon): set claude otel env#114

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-113
Apr 26, 2026
Merged

fix(daemon): set claude otel env#114
rowan-stein merged 2 commits into
mainfrom
noa/issue-113

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • configure Claude Code OTEL exporters and telemetry env vars
  • pin OTLP endpoint to the local tracing proxy

Testing

  • buf generate buf.build/agynio/api --path agynio/api/gateway/v1 --include-imports
  • go test ./...
  • go vet ./...

Refs #113

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/gateway/v1 --include-imports
  • go test ./... (passed: 7, failed: 0, skipped: 1)
  • go vet ./... (no issues)

noa-lucent
noa-lucent previously approved these changes Apr 26, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config looks aligned with agynd-cli#113: Claude subprocess now has explicit OTEL exporters enabled and protocol forced to gRPC.

Minor note left inline about avoiding a hard-coded OTLP endpoint.

[nit] Consider changing the PR description from Refs #113 to Closes #113 so it auto-closes on merge.

Comment thread internal/daemon/claude.go Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • derive the OTLP endpoint from tracingproxy.ListenAddress

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/gateway/v1 --include-imports
  • go test ./... (passed: 7, failed: 0, skipped: 1)
  • go vet ./... (no issues)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review after update: confirmed the Claude OTLP endpoint is now derived from tracingproxy.ListenAddress again, and the additional OTEL env vars match the issue spec (force gRPC OTLP traces; disable metrics/logs).

@rowan-stein rowan-stein merged commit 0608d63 into main Apr 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants