Skip to content

feat(proto): update activity list protos#134

Merged
vitramir merged 1 commit into
mainfrom
noa/issue-133-2
Apr 25, 2026
Merged

feat(proto): update activity list protos#134
vitramir merged 1 commit into
mainfrom
noa/issue-133-2

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add server-side list filter/sort envelopes for workloads and volumes
  • enrich workload/volume responses with display names and attachments
  • introduce list organization threads RPC and identity nickname batch lookup

Testing

  • buf lint
  • buf breaking --against '.git#branch=main'

Refs #133

@casey-brooks casey-brooks requested a review from a team as a code owner April 24, 2026 19:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 25, 2026, 12:29 AM

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Tests:

  • buf breaking --against '.git#branch=main' (passed: 1, failed: 0, skipped: 0)

Lint:

  • buf lint (no errors)

noa-lucent
noa-lucent previously approved these changes Apr 24, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protos look aligned with the Activity server-side list spec (workloads/volumes/threads) and keep compatibility via deprecated legacy fields. Left a few minor nits around making defaults/semantics self-documenting (default sort + deterministic cursor notes, case-insensitive volume name search), marking GetOrganizationThreads deprecated via proto option, and clarifying whether nicknames include the @ prefix.

Comment thread proto/agynio/api/runners/v1/runners.proto
Comment thread proto/agynio/api/runners/v1/runners.proto
Comment thread proto/agynio/api/runners/v1/runners.proto
Comment thread proto/agynio/api/threads/v1/threads.proto
Comment thread proto/agynio/api/threads/v1/threads.proto
Comment thread proto/agynio/api/threads/v1/threads.proto
Comment thread proto/agynio/api/identity/v1/identity.proto
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary:

  • Rebasing onto main resolved runners.proto conflict by keeping failure reason/message fields and moving agent_name/runner_name to new field numbers (17/18).

Tests:

  • buf lint (no errors)
  • buf breaking --against '.git#branch=main' (passed: 1, failed: 0, skipped: 0)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (static only — not running builds/tests).

The proto surface for Activity server-side lists (workloads/volumes/threads) + nickname batch lookup still looks aligned with issue #133/spec, and the branch updates didn’t introduce any new blockers. Resolved my prior minor doc/deprecation nits as non-blocking.

@vitramir vitramir merged commit 7326d1b into main Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants