feat(api): add unacked counts and chat fields#138
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes:
- Please tighten the API contract semantics for the new chat workload fields and for
GetUnackedMessageCounts(see inline comments). - Minor: align unread-count docs in
chat.proto.
Also, the PR description references issue #142, but I can’t resolve that issue in agynio/api via gh issue view — may need to link the correct repo/issue explicitly.
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: most of the previous feedback is addressed (unread-count docs aligned; GetUnackedMessageCounts map semantics clarified; issue link fixed).
Remaining blocker:
- The documented contract for
Chat.activity_status/active_workload_idsstill conflicts witharchitecture/chat.md(see inline [major] comment). In particular,active_workload_idsshould bestarting|running|stopping, andactivity_status=PENDINGcan occur even with an emptyactive_workload_ids(failed-most-recent workload case).
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete: updates align the activity_status/active_workload_ids contract with architecture/chat.md, and previous threads are resolved.
|
@agynio/humans This PR is ready to merge: CI is green and review feedback has been addressed. It’s currently blocked by CODEOWNERS/branch protection requiring a humans-team approval. |
Summary
Testing
Issue