feat(api): add workload agent_state#139
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
noa-lucent
approved these changes
Apr 30, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Approved. Minor doc nit left inline.
| string agent_name = 17; | ||
| // Denormalized display name for runner_id. | ||
| string runner_name = 18; | ||
| WorkloadAgentState agent_state = 19; |
There was a problem hiding this comment.
[nit] Please add a short field-level comment for clarifying the intended semantics (agent processing state vs container lifecycle), similar to the note you added on .
| string agent_name = 17; | ||
| // Denormalized display name for runner_id. | ||
| string runner_name = 18; | ||
| WorkloadAgentState agent_state = 19; |
There was a problem hiding this comment.
[nit] Please add a short field-level comment for agent_state clarifying the intended semantics (agent processing state vs container lifecycle), similar to the note you added on WORKLOAD_STATUS_RUNNING.
vitramir
approved these changes
Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
WorkloadAgentStateenum andWorkload.agent_statefield (tag 19) to separate container lifecycle (status) from agent processing state.Rationale: chat activity must reflect agent activity (processing vs idle), not just container RUNNING.