Add organization app installation relations#12
Merged
Merged
Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Apr 4, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Model changes match the issue specification exactly. All seven required relations are correctly defined on the organization type with appropriate definitions ([cluster], owner, admin from cluster, [identity]).
Test coverage is solid:
- Computed relations (
can_invite,can_manage_members) tested for both owner (positive) and member (negative). - Cross-type
can_add_memberverified via cluster admin (positive) and non-admin (negative). - App installation permissions (
can_create_thread,can_write_thread,can_add_participant) tested for installed app (positive), uninstalled app (negative), and regular member (negative).
Tuple setup in the test fixture correctly models the org-creation and app-installation patterns described in the issue.
Clean, well-structured PR. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #11