Skip to content

Add organization app installation relations#12

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-11
Apr 4, 2026
Merged

Add organization app installation relations#12
rowan-stein merged 1 commit into
mainfrom
noa/issue-11

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add organization relations for app installation permissions
  • expand OpenFGA model tests for org member and app checks

Testing

  • go test ./...
  • go vet ./...
  • $(go env GOPATH)/bin/fga model test --tests terraform/model.fga.yaml

Closes #11

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • added organization relations for app installation permissions in terraform/model.fga
  • expanded model tests for org/member/app permissions in terraform/model.fga.yaml

Testing

  • go test ./... (passed: 1, failed: 0, skipped: 0)
  • go vet ./... (lint: no issues)
  • $(go env GOPATH)/bin/fga model test --tests terraform/model.fga.yaml (tests passed: 13, failed: 0, skipped: 0; checks passed: 23/23)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model changes match the issue specification exactly. All seven required relations are correctly defined on the organization type with appropriate definitions ([cluster], owner, admin from cluster, [identity]).

Test coverage is solid:

  • Computed relations (can_invite, can_manage_members) tested for both owner (positive) and member (negative).
  • Cross-type can_add_member verified via cluster admin (positive) and non-admin (negative).
  • App installation permissions (can_create_thread, can_write_thread, can_add_participant) tested for installed app (positive), uninstalled app (negative), and regular member (negative).

Tuple setup in the test fixture correctly models the org-creation and app-installation patterns described in the issue.

Clean, well-structured PR. LGTM.

@rowan-stein rowan-stein merged commit 3ff1ad1 into main Apr 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add app installation permission relations to OpenFGA model

3 participants