feat(authz): update OpenFGA model#14
Conversation
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
Model changes look aligned with the authz spec (org/thread/model types + app installation permissions). Inline nits/suggestions left re: minor readability and an extra negative thread-permissions test.
Note: the PR references #136 but that issue number doesn’t exist in this repo (might be cross-repo) — consider linking the correct issue for traceability.
| relations | ||
| define cluster: [cluster] | ||
| define owner: [identity] | ||
| define member: [identity] or owner |
There was a problem hiding this comment.
[nit] Follow-up (previous comment may have had formatting issues): consider defining owner before member since member references owner. It reads more naturally and avoids forward-reference when scanning.
| thread_write: false | ||
| participant_add: false | ||
| can_create_thread: false | ||
| - name: thread participant can read write add |
There was a problem hiding this comment.
[minor] Test coverage: consider adding an explicit negative check for an org member who is not a participant on a thread (e.g. org-member-id on thread:thread-1 should have can_read/can_write/can_add_participant = false). This locks the key invariant that membership alone doesn’t grant thread-level access.
Summary
Testing
Refs #136