Skip to content

fix(deployment): adds draining rpc query logs#2375

Merged
ygrishajev merged 1 commit intomainfrom
feature/auto-reload
Dec 18, 2025
Merged

fix(deployment): adds draining rpc query logs#2375
ygrishajev merged 1 commit intomainfrom
feature/auto-reload

Conversation

@ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Dec 18, 2025

refs #1779

Summary by CodeRabbit

  • Chores
    • Enhanced internal logging for deployment resource tracking to improve system observability and debugging capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@ygrishajev ygrishajev requested a review from a team as a code owner December 18, 2025 10:04
@ygrishajev ygrishajev merged commit 5d6e7a9 into main Dec 18, 2025
13 of 15 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Added a debug log statement to the findManyByDseqAndOwner method that emits the RPC_RESOURCES_FETCHED event with computed resources data (dseqSet, leases, deployments, and outputs) after the filtering step. This provides observability into the resource computation process without altering control flow or return values.

Changes

Cohort / File(s) Change Summary
Debug Logging Addition
apps/api/src/deployment/services/draining-deployment-rpc/draining-deployment-rpc.service.ts
Added debug log emitting RPC_RESOURCES_FETCHED event with dseqSet, leases, deployments, and computed outputs in the findManyByDseqAndOwner method

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • akash-network/console#2354: Modifies filtering logic in the same findManyByDseqAndOwner flow within the draining-deployment-rpc service

Suggested reviewers

  • baktun14

Poem

🐰 A log hops into the code so fine,
RPC_RESOURCES_FETCHED marks the time,
Data flows like carrots in a line,
Debug logs make observability shine!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/auto-reload

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ae3a55 and b26591c.

📒 Files selected for processing (1)
  • apps/api/src/deployment/services/draining-deployment-rpc/draining-deployment-rpc.service.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@ygrishajev ygrishajev deleted the feature/auto-reload branch December 18, 2025 10:04
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.04%. Comparing base (0ae3a55) to head (b26591c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
- Coverage   51.34%   51.04%   -0.30%     
==========================================
  Files        1071     1061      -10     
  Lines       29107    28759     -348     
  Branches     6396     6355      -41     
==========================================
- Hits        14945    14681     -264     
+ Misses      13763    13679      -84     
  Partials      399      399              
Flag Coverage Δ *Carryforward flag
api 80.99% <100.00%> (-0.03%) ⬇️
deploy-web 31.14% <ø> (ø) Carriedforward from 0ae3a55
log-collector ?
notifications 87.94% <ø> (ø) Carriedforward from 0ae3a55
provider-console 81.48% <ø> (ø) Carriedforward from 0ae3a55
provider-proxy 84.35% <ø> (ø) Carriedforward from 0ae3a55

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...-deployment-rpc/draining-deployment-rpc.service.ts 98.59% <100.00%> (+0.02%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments