Skip to content

fix(deployment): uses proper button image link#2496

Merged
ygrishajev merged 1 commit intomainfrom
fix/deployment-btn
Jan 14, 2026
Merged

fix(deployment): uses proper button image link#2496
ygrishajev merged 1 commit intomainfrom
fix/deployment-btn

Conversation

@ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Jan 14, 2026

refs #2470

Summary by CodeRabbit

  • Bug Fixes
    • Fixed image links used in deployment sharing snippets so the deploy button image displays correctly in both Markdown and HTML share outputs.

✏️ Tip: You can customize this high-level summary in your review settings.

@ygrishajev ygrishajev requested a review from a team as a code owner January 14, 2026 14:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

The ShareDeployButton updated the Deploy Button image source URL from the support repository path to a path within the console repository; tests were updated to expect the new image URL.

Changes

Cohort / File(s) Summary
Image URL Update
apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.tsx, apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
Replaced old support-repo raw GitHub image URL with new console-repo raw GitHub image URL in generated Markdown/HTML snippets and updated test expectations accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • baktun14
  • stalniy

Poem

🐰 A little rabbit hopped to play,
Swapped a URL along the way,
No logic changed, just image shown,
A tiny tweak — the button's grown. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the deploy button image source URL from the support repository to the console repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9bb7d9 and b52d770.

📒 Files selected for processing (2)
  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.tsx
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/general.mdc)

**/*.{ts,tsx,js}: Never use type any or cast to type any. Always define the proper TypeScript types.
Never use deprecated methods from libraries.
Don't add unnecessary comments to the code.

Files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.tsx
**/*.spec.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/no-jest-mock.mdc)

Don't use jest.mock() in test files. Instead, use jest-mock-extended to create mocks and pass mocks as dependencies to the service under test

Use setup function instead of beforeEach in test files. The setup function must be at the bottom of the root describe block, should create an object under test and return it, accept a single parameter with inline type definition, avoid shared state, and not have a specified return type.

**/*.spec.{ts,tsx}: Use <Subject>.name in the root describe suite description instead of hardcoded class/service name strings to enable automated refactoring tools to find all references
Use either a method name or a condition starting with 'when' for nested suite descriptions in tests
Use present simple, 3rd person singular for test descriptions without prepending 'should'

Files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
{apps/deploy-web,apps/provider-console}/**/*.spec.tsx

📄 CodeRabbit inference engine (.cursor/rules/query-by-in-tests.mdc)

Use queryBy methods instead of getBy methods in test expectations

Files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
**/*.{test,spec}.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use setup function instead of beforeEach in unit and service level tests

Files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
🧠 Learnings (2)
📚 Learning: 2025-11-25T17:45:49.180Z
Learnt from: CR
Repo: akash-network/console PR: 0
File: .cursor/rules/query-by-in-tests.mdc:0-0
Timestamp: 2025-11-25T17:45:49.180Z
Learning: Applies to {apps/deploy-web,apps/provider-console}/**/*.spec.tsx : Use `queryBy` methods instead of `getBy` methods in test expectations

Applied to files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
📚 Learning: 2025-07-11T10:46:43.711Z
Learnt from: stalniy
Repo: akash-network/console PR: 1660
File: apps/deploy-web/src/components/alerts/DeploymentAlertsContainer/DeploymentAlertsContainer.spec.tsx:54-56
Timestamp: 2025-07-11T10:46:43.711Z
Learning: In apps/{deploy-web,provider-console}/**/*.spec.tsx files: Use `getBy` methods instead of `queryBy` methods when testing element presence with `toBeInTheDocument()` because `getBy` throws an error and shows DOM state when element is not found, providing better debugging information than `queryBy` which returns null.

Applied to files:

  • apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: validate / validate-app
  • GitHub Check: test-build
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.spec.tsx (1)

89-90: LGTM - Test expectations updated to match the new image URL.

The expected snippets correctly reflect the updated button image URL from the console repository.

apps/deploy-web/src/components/new-deployment/ShareDeployButton/ShareDeployButton.tsx (1)

217-219: LGTM - URL updated to reference the console repository.

The image URL correctly points to the console repository's deploy button asset using a valid GitHub raw content reference. The local file exists, and the code follows all TypeScript guidelines with proper type inference and no deprecated methods.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.64%. Comparing base (57d3673) to head (b52d770).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

❌ Your project status has failed because the head coverage (79.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
- Coverage   50.93%   50.64%   -0.29%     
==========================================
  Files        1064     1054      -10     
  Lines       29452    29103     -349     
  Branches     6537     6496      -41     
==========================================
- Hits        15000    14739     -261     
+ Misses      14093    14014      -79     
+ Partials      359      350       -9     
Flag Coverage Δ *Carryforward flag
api 79.33% <ø> (ø) Carriedforward from 57d3673
deploy-web 31.45% <100.00%> (+0.01%) ⬆️
log-collector ?
notifications 87.94% <ø> (ø) Carriedforward from 57d3673
provider-console 81.48% <ø> (ø) Carriedforward from 57d3673
provider-proxy 84.35% <ø> (ø) Carriedforward from 57d3673

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...deployment/ShareDeployButton/ShareDeployButton.tsx 86.15% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ygrishajev ygrishajev merged commit 73fc6a5 into main Jan 14, 2026
64 of 65 checks passed
@ygrishajev ygrishajev deleted the fix/deployment-btn branch January 14, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments