From 0670905c4cda67d39a1e2393fd9e7b1013a01076 Mon Sep 17 00:00:00 2001 From: alt-ctrl-dev <1557519+alt-ctrl-dev@users.noreply.github.com> Date: Sat, 1 Apr 2023 17:07:32 +0800 Subject: [PATCH 1/2] refactor: returning error for incorrect code Signed-off-by: alt-ctrl-dev <1557519+alt-ctrl-dev@users.noreply.github.com> --- lib/aba_file_validator.ex | 2 +- test/aba_file_validator_test.exs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/aba_file_validator.ex b/lib/aba_file_validator.ex index 4c044d8..2f1d818 100644 --- a/lib/aba_file_validator.ex +++ b/lib/aba_file_validator.ex @@ -33,5 +33,5 @@ defmodule AbaFileValidator do def get_transaction_code_description("56"), do: "Dividend" def get_transaction_code_description(57), do: "Debenture/Note Interest" def get_transaction_code_description("57"), do: "Debenture/Note Interest" - def get_transaction_code_description(_), do: :not_provided + def get_transaction_code_description(_), do: :error end diff --git a/test/aba_file_validator_test.exs b/test/aba_file_validator_test.exs index a58bc76..577132a 100644 --- a/test/aba_file_validator_test.exs +++ b/test/aba_file_validator_test.exs @@ -3,7 +3,7 @@ defmodule AbaFileValidatorTest do doctest AbaFileValidator test "transaction code description" do - assert AbaFileValidator.get_transaction_code_description(11) == :not_provided + assert AbaFileValidator.get_transaction_code_description(11) == :error assert AbaFileValidator.get_transaction_code_description(13) == "Externally initiated debit items" assert AbaFileValidator.get_transaction_code_description("13") == "Externally initiated debit items" assert AbaFileValidator.get_transaction_code_description(50) == "Externally initiated credit items with the exception of those bearing Transaction Codes" From 5c55616f3e63fb2b93e6f74c4ef7e838da76cad5 Mon Sep 17 00:00:00 2001 From: alt-ctrl-dev <1557519+alt-ctrl-dev@users.noreply.github.com> Date: Sat, 1 Apr 2023 17:10:42 +0800 Subject: [PATCH 2/2] fix: updated doctest Signed-off-by: alt-ctrl-dev <1557519+alt-ctrl-dev@users.noreply.github.com> --- lib/aba_file_validator.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/aba_file_validator.ex b/lib/aba_file_validator.ex index 2f1d818..d0e172a 100644 --- a/lib/aba_file_validator.ex +++ b/lib/aba_file_validator.ex @@ -9,7 +9,7 @@ defmodule AbaFileValidator do ## Examples iex> AbaFileValidator.get_transaction_code_description("11") - :not_provided + :error iex> AbaFileValidator.get_transaction_code_description(13) "Externally initiated debit items"