From 9e7e2abd43ca9131d64050e6546395d261cb7dd6 Mon Sep 17 00:00:00 2001 From: Nelesh Singla <117123879+nsingla@users.noreply.github.com> Date: Thu, 4 Dec 2025 14:46:20 -0500 Subject: [PATCH 1/2] ading path to git triggers so that we don;t run workflows unnecessarily Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com> --- .github/workflows/e2e.yml | 15 ++++++++++ .github/workflows/frontend-lint.yml | 46 +++++++++++++---------------- .github/workflows/go-lint.yml | 14 +++++++++ 3 files changed, 49 insertions(+), 26 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index a23ffa3a3..7acf82ae6 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -3,8 +3,23 @@ name: E2E Tests on: pull_request: branches: [ main, master ] + paths: + - 'components/**' + - '.github/workflows/e2e.yml' + - 'e2e/**' + - 'scripts/**' + - '.specify/**' + - 'agents/**' + push: branches: [ main, master ] + paths: + - 'components/**' + - '.github/workflows/e2e.yml' + - 'e2e/**' + - 'scripts/**' + - '.specify/**' + - 'agents/**' workflow_dispatch: # Allow manual trigger jobs: diff --git a/.github/workflows/frontend-lint.yml b/.github/workflows/frontend-lint.yml index 67b705807..04d8169ce 100644 --- a/.github/workflows/frontend-lint.yml +++ b/.github/workflows/frontend-lint.yml @@ -3,38 +3,32 @@ name: Frontend Lint and Type Check on: push: branches: [main] + paths: + - 'components/frontend/**/*.ts' + - 'components/frontend/**/*.tsx' + - 'components/frontend/**/*.js' + - 'components/frontend/**/*.jsx' + - 'components/frontend/package.json' + - 'components/frontend/package-lock.json' + - 'components/frontend/tsconfig.json' + - 'components/frontend/eslint.config.mjs' + pull_request: branches: [main] + paths: + - 'components/frontend/**/*.ts' + - 'components/frontend/**/*.tsx' + - 'components/frontend/**/*.js' + - 'components/frontend/**/*.jsx' + - 'components/frontend/package.json' + - 'components/frontend/package-lock.json' + - 'components/frontend/tsconfig.json' + - 'components/frontend/eslint.config.mjs' workflow_dispatch: jobs: - detect-frontend-changes: - runs-on: ubuntu-latest - outputs: - frontend: ${{ steps.filter.outputs.frontend }} - steps: - - name: Checkout code - uses: actions/checkout@v5 - - - name: Check for Frontend changes - uses: dorny/paths-filter@v3 - id: filter - with: - filters: | - frontend: - - 'components/frontend/**/*.ts' - - 'components/frontend/**/*.tsx' - - 'components/frontend/**/*.js' - - 'components/frontend/**/*.jsx' - - 'components/frontend/package.json' - - 'components/frontend/package-lock.json' - - 'components/frontend/tsconfig.json' - - 'components/frontend/eslint.config.mjs' - lint-frontend: runs-on: ubuntu-latest - needs: detect-frontend-changes - if: needs.detect-frontend-changes.outputs.frontend == 'true' || github.event_name == 'workflow_dispatch' steps: - name: Checkout code uses: actions/checkout@v5 @@ -68,7 +62,7 @@ jobs: lint-summary: runs-on: ubuntu-latest - needs: [detect-frontend-changes, lint-frontend] + needs: lint-frontend if: always() steps: - name: Check overall status diff --git a/.github/workflows/go-lint.yml b/.github/workflows/go-lint.yml index 661bd40a4..2c582d681 100644 --- a/.github/workflows/go-lint.yml +++ b/.github/workflows/go-lint.yml @@ -3,8 +3,22 @@ name: Go Lint and Format on: push: branches: [main] + paths: + - 'components/backend/**/*.go' + - 'components/backend/go.mod' + - 'components/backend/go.sum' + - 'components/operator/**/*.go' + - 'components/operator/go.mod' + - 'components/operator/go.sum' pull_request: branches: [main] + paths: + - 'components/backend/**/*.go' + - 'components/backend/go.mod' + - 'components/backend/go.sum' + - 'components/operator/**/*.go' + - 'components/operator/go.mod' + - 'components/operator/go.sum' workflow_dispatch: jobs: From e7df45608757303354140aa0abc7bae3ea72bb84 Mon Sep 17 00:00:00 2001 From: Nelesh Singla <117123879+nsingla@users.noreply.github.com> Date: Thu, 4 Dec 2025 15:12:36 -0500 Subject: [PATCH 2/2] simplifying git workflows Signed-off-by: Nelesh Singla <117123879+nsingla@users.noreply.github.com> --- .github/workflows/components-build-deploy.yml | 18 ++++++++++++++++++ .github/workflows/e2e.yml | 4 ++++ .github/workflows/frontend-lint.yml | 7 +++++++ .github/workflows/go-lint.yml | 6 ++++++ 4 files changed, 35 insertions(+) diff --git a/.github/workflows/components-build-deploy.yml b/.github/workflows/components-build-deploy.yml index 0c40b5fb1..dfde7a4c6 100644 --- a/.github/workflows/components-build-deploy.yml +++ b/.github/workflows/components-build-deploy.yml @@ -3,10 +3,28 @@ name: Build and Push Component Docker Images on: push: branches: [main] + paths: + - '.github/workflows/components-build-deploy.yml' + - 'components/manifests/**' + - 'components/runners/**' + - 'components/operator/**' + - 'components/backend/**' + - 'components/frontend/**' pull_request_target: branches: [main] + paths: + - '.github/workflows/components-build-deploy.yml' + - 'components/manifests/**' + - 'components/runners/**' + - 'components/operator/**' + - 'components/backend/**' + - 'components/frontend/**' workflow_dispatch: +concurrency: + group: components-build-deploy-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: detect-changes: runs-on: ubuntu-latest diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 7acf82ae6..3aac62d49 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,6 +22,10 @@ on: - 'agents/**' workflow_dispatch: # Allow manual trigger +concurrency: + group: e2e-tests-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: detect-changes: runs-on: ubuntu-latest diff --git a/.github/workflows/frontend-lint.yml b/.github/workflows/frontend-lint.yml index 04d8169ce..22766430f 100644 --- a/.github/workflows/frontend-lint.yml +++ b/.github/workflows/frontend-lint.yml @@ -12,6 +12,7 @@ on: - 'components/frontend/package-lock.json' - 'components/frontend/tsconfig.json' - 'components/frontend/eslint.config.mjs' + - '.github/workflows/frontend-lint.yml' pull_request: branches: [main] @@ -24,8 +25,14 @@ on: - 'components/frontend/package-lock.json' - 'components/frontend/tsconfig.json' - 'components/frontend/eslint.config.mjs' + - '.github/workflows/frontend-lint.yml' + workflow_dispatch: +concurrency: + group: frontend-lint-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: lint-frontend: runs-on: ubuntu-latest diff --git a/.github/workflows/go-lint.yml b/.github/workflows/go-lint.yml index 2c582d681..8e6d086e3 100644 --- a/.github/workflows/go-lint.yml +++ b/.github/workflows/go-lint.yml @@ -10,6 +10,7 @@ on: - 'components/operator/**/*.go' - 'components/operator/go.mod' - 'components/operator/go.sum' + - '.github/workflows/go-lint.yml' pull_request: branches: [main] paths: @@ -19,8 +20,13 @@ on: - 'components/operator/**/*.go' - 'components/operator/go.mod' - 'components/operator/go.sum' + - '.github/workflows/go-lint.yml' workflow_dispatch: +concurrency: + group: go-lint-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + jobs: detect-go-changes: runs-on: ubuntu-latest