From 3b1d698f6b26c36ddb942a0cbffde3a838206774 Mon Sep 17 00:00:00 2001 From: Gage Krumbach Date: Tue, 3 Feb 2026 15:20:33 -0600 Subject: [PATCH] fix(e2e): simplify E2E workflow to trigger only on safe-to-test label Changes the E2E workflow to ONLY run when 'safe-to-test' label is added to a PR. Security model: - Uses pull_request_target for secret access - Requires explicit maintainer approval via label - Runs full test suite with ANTHROPIC_API_KEY Usage: gh pr edit --add-label safe-to-test Benefits: - Secure: maintainer review required before running with secrets - Simple: one workflow, one trigger - Complete: full agent interaction testing --- .github/workflows/e2e.yml | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 7ab3cc7be..393062908 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -68,17 +68,6 @@ jobs: timeout-minutes: 25 steps: - - name: Add comment to PR - uses: actions/github-script@v7 - with: - script: | - github.rest.issues.createComment({ - issue_number: ${{ github.event.pull_request.number }}, - owner: context.repo.owner, - repo: context.repo.repo, - body: '🔒 **E2E Tests Started**\n\nRunning full test suite with agent interaction.\n\nTriggered by: @${{ github.actor }}' - }) - - name: Checkout PR code uses: actions/checkout@v6 with: @@ -239,24 +228,6 @@ jobs: path: e2e/cypress/videos if-no-files-found: ignore retention-days: 7 - - - name: Comment test result on PR - if: always() - uses: actions/github-script@v7 - with: - script: | - const status = '${{ job.status }}'; - const icon = status === 'success' ? '✅' : '❌'; - const message = status === 'success' - ? 'All E2E tests passed (including agent interaction)!' - : 'Some E2E tests failed. Check the workflow logs for details.'; - - github.rest.issues.createComment({ - issue_number: ${{ github.event.pull_request.number }}, - owner: context.repo.owner, - repo: context.repo.repo, - body: `${icon} **E2E Tests ${status}**\n\n${message}\n\n[View workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})` - }) - name: Debug logs on failure if: failure()