fix e2e webpack test

Author: hansl

packages/webpack/src/index.ts

@@ -1,3 +1,5 @@
+import 'reflect-metadata';
+
 export * from './codegen'
 export * from './plugin'
 export {ngcLoader as default} from './loader'

tests/e2e/setup/300-log-environment.ts

@@ -0,0 +1,15 @@
+import {node, ng, npm} from '../utils/process';
+
+
+export default function() {
+  return Promise.resolve()
+    .then(() => console.log('Environment:'))
+    .then(() => {
+      Object.keys(process.env).forEach(envName => {
+        console.log(`  ${envName}: ${process.env[envName].replace(/[\n\r]+/g, '\n        ')}`);
+      });
+    })
+    .then(() => node('--version'))
+    .then(() => npm('--version'))
+    .then(() => ng('version'));
+}

tests/e2e/setup/500-create-project.ts

@@ -9,10 +9,11 @@ import {gitClean, gitCommit} from '../utils/git';
 export default function(argv: any) {
   let createProject = null;
 
-  // If we're set to reuse an existing project, just chdir to it and clean it.
+  // This is a dangerous flag, but is useful for testing packages only.
   if (argv.noproject) {
     return Promise.resolve();
   } else if (argv.reuse) {
+    // If we're set to reuse an existing project, just chdir to it and clean it.
     createProject = Promise.resolve()
       .then(() => process.chdir(argv.reuse))
       .then(() => gitClean());

tests/e2e/tests/packages/webpack/test.ts

@@ -1,7 +1,8 @@
 import {copyAssets} from '../../../utils/assets';
-import {npm, exec} from '../../../utils/process';
+import {exec, silentNpm} from '../../../utils/process';
 import {updateJsonFile} from '../../../utils/project';
 import {join} from 'path';
+import {expectFileSizeToBeUnder} from '../../../utils/fs';
 
 
 export default function(argv: any, skipCleaning: () => void) {
@@ -14,9 +15,10 @@ export default function(argv: any, skipCleaning: () => void) {
       const dist = '../../../../../dist/';
       json['dependencies']['@ngtools/webpack'] = join(__dirname, dist, 'webpack');
     }))
-    .then(() => npm('install'))
-    .then(() => exec('node_modules/.bin/webpack', '-p', 'webpack.config.js'))
-    .then(() => console.log(process.cwd()))
+    .then(() => silentNpm('install'))
+    .then(() => exec('node_modules/.bin/webpack', '-p'))
+    .then(() => expectFileSizeToBeUnder('dist/app.main.js', 400000))
+    .then(() => expectFileSizeToBeUnder('dist/0.app.main.js', 40000))
     .then(() => process.chdir(currentDir))
     .then(() => skipCleaning());
 }

tests/e2e/utils/fs.ts

@@ -119,3 +119,12 @@ export function expectFileToMatch(fileName: string, regEx: RegExp | string) {
       }
     });
 }
+
+export function expectFileSizeToBeUnder(fileName: string, sizeInBytes: number) {
+  return readFile(fileName)
+    .then(content => {
+      if (content.length > sizeInBytes) {
+        throw new Error(`File "${fileName}" exceeded file size of "${sizeInBytes}".`);
+      }
+    });
+}

tests/e2e/utils/process.ts

@@ -20,8 +20,15 @@ function _exec(options: ExecOptions, cmd: string, args: string[]): Promise<strin
   ));
 
   args = args.filter(x => x !== undefined);
-
-  console.log(blue(`  Running \`${cmd} ${args.map(x => `"${x}"`).join(' ')}\`...`));
+  const flags = [
+    options.silent && 'silent',
+    options.waitForMatch && `matching(${options.waitForMatch})`
+  ]
+    .filter(x => !!x)  // Remove false and undefined.
+    .join(', ')
+    .replace(/^(.+)$/, ' [$1]');  // Proper formatting.
+
+  console.log(blue(`  Running \`${cmd} ${args.map(x => `"${x}"`).join(' ')}\`${flags}...`));
   console.log(blue(`  CWD: ${cwd}`));
   const spawnOptions: any = {cwd};
 
@@ -31,8 +38,8 @@ function _exec(options: ExecOptions, cmd: string, args: string[]): Promise<strin
     spawnOptions['stdio'] = 'pipe';
   }
 
-  const npmProcess = child_process.spawn(cmd, args, spawnOptions);
-  npmProcess.stdout.on('data', (data: Buffer) => {
+  const childProcess = child_process.spawn(cmd, args, spawnOptions);
+  childProcess.stdout.on('data', (data: Buffer) => {
     stdout += data.toString('utf-8');
     if (options.silent) {
       return;
@@ -42,21 +49,21 @@ function _exec(options: ExecOptions, cmd: string, args: string[]): Promise<strin
       .filter(line => line !== '')
       .forEach(line => console.log('  ' + line));
   });
-  npmProcess.stderr.on('data', (data: Buffer) => {
+  childProcess.stderr.on('data', (data: Buffer) => {
     stderr += data.toString('utf-8');
     data.toString('utf-8')
       .split(/[\n\r]+/)
       .filter(line => line !== '')
       .forEach(line => console.error(yellow('  ' + line)));
   });
 
-  _processes.push(npmProcess);
+  _processes.push(childProcess);
 
   // Create the error here so the stack shows who called this function.
   const err = new Error(`Running "${cmd} ${args.join(' ')}" returned error code `);
   return new Promise((resolve, reject) => {
-    npmProcess.on('exit', (error: any) => {
-      _processes = _processes.filter(p => p !== npmProcess);
+    childProcess.on('exit', (error: any) => {
+      _processes = _processes.filter(p => p !== childProcess);
 
       if (!error) {
         resolve(stdout);
@@ -67,7 +74,7 @@ function _exec(options: ExecOptions, cmd: string, args: string[]): Promise<strin
     });
 
     if (options.waitForMatch) {
-      npmProcess.stdout.on('data', (data: Buffer) => {
+      childProcess.stdout.on('data', (data: Buffer) => {
         if (data.toString().match(options.waitForMatch)) {
           resolve(stdout);
         }
@@ -113,6 +120,10 @@ export function npm(...args: string[]) {
   return _exec({}, 'npm', args);
 }
 
+export function node(...args: string[]) {
+  return _exec({}, 'node', args);
+}
+
 export function git(...args: string[]) {
   return _exec({}, 'git', args);
 }