fix: lazy loading now works as expected with latest webpack (#2038)

Author: hansl

.appveyor.yml

@@ -3,6 +3,9 @@ environment:
   - nodejs_version: "5.0"
   - nodejs_version: "6.0"
 
+matrix:
+  fast_finish: true
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install

addon/ng2/models/find-lazy-modules.ts

@@ -51,18 +51,16 @@ export function findLoadChildren(tsFilePath: string): string[] {
 
 
 export function findLazyModules(projectRoot: any): string[] {
-  const result: {[key: string]: boolean} = {};
+  const result: {[key: string]: string} = {};
   glob.sync(path.join(projectRoot, '/**/*.ts'))
     .forEach(tsPath => {
       findLoadChildren(tsPath).forEach(moduleName => {
-        const fileName = path.resolve(path.dirname(tsPath), moduleName) + '.ts';
+        const fileName = path.resolve(projectRoot, moduleName) + '.ts';
         if (fs.existsSync(fileName)) {
           // Put the moduleName as relative to the main.ts.
-          const fullPath = path.resolve(path.dirname(tsPath), moduleName);
-          const name = `./${path.relative(projectRoot, fullPath)}.ts`;
-          result[name] = true;
+          result[moduleName] = fileName;
         }
       });
     });
-  return Object.keys(result);
+  return result;
 }

tests/acceptance/find-lazy-module.spec.ts

@@ -39,11 +39,12 @@ describe('find-lazy-module', () => {
   afterEach(() => mockFs.restore());
 
   it('works', () => {
-    expect(findLazyModules('project-root')).to.eql([
-      './' + join('.', 'moduleA.ts'),
-      './' + join('.', 'moduleB.ts'),
-      './' + join('.', 'moduleC.ts'),
-      './' + join('.', 'app/+workspace/+settings/settings.module.ts')
-    ]);
+    expect(findLazyModules('project-root')).to.eql({
+      'moduleA': join(process.cwd(), 'project-root', 'moduleA.ts'),
+      'moduleB': join(process.cwd(), 'project-root', 'moduleB.ts'),
+      'moduleC': join(process.cwd(), 'project-root', 'moduleC.ts'),
+      'app/+workspace/+settings/settings.module':
+          join(process.cwd(), 'project-root', 'app/+workspace/+settings/settings.module.ts'),
+    });
   });
 });

tests/e2e/tests/misc/lazy-module.ts

@@ -17,9 +17,9 @@ export default function(argv: any) {
   return Promise.resolve()
     .then(() => ng('build'))
     .then(() => oldNumberOfFiles = readdirSync('dist').length)
-    .then(() => ng('generate', 'module', 'lazy'))
+    .then(() => ng('generate', 'module', 'lazy', '--routing'))
     .then(() => addImportToModule('src/app/app.module.ts', oneLine`
-      RouterModule.forRoot([{ path: "/lazy", loadChildren: "./lazy/lazy.module#LazyModule" }])
+      RouterModule.forRoot([{ path: "lazy", loadChildren: "app/lazy/lazy.module#LazyModule" }])
       `, '@angular/router'))
     .then(() => ng('build'))
     .then(() => currentNumberOfDistFiles = readdirSync('dist').length)

tests/e2e_runner.js

@@ -104,7 +104,10 @@ testsToRun.reduce((previous, relativeName) => {
   });
 }, Promise.resolve())
 .then(
-  () => console.log(green('Done.')),
+  () => {
+    console.log(green('Done.'));
+    process.exit(0);
+  },
   (err) => {
     console.log('\n');
     console.error(red(`Test "${currentFileName}" failed...`));