From b1580cd6fd3eaff2ecf0cfea9bec6ee3ab95f78f Mon Sep 17 00:00:00 2001 From: Sean Larkin Date: Fri, 12 Aug 2016 14:52:10 -0500 Subject: [PATCH 1/2] feat: remove sourcemap warnings for vendors who don't properly provide them --- addon/ng2/models/webpack-build-common.ts | 10 ---------- addon/ng2/models/webpack-build-development.ts | 8 ++++++++ addon/ng2/models/webpack-build-production.ts | 11 +++++++++++ addon/ng2/models/webpack-build-utils.ts | 3 ++- 4 files changed, 21 insertions(+), 11 deletions(-) diff --git a/addon/ng2/models/webpack-build-common.ts b/addon/ng2/models/webpack-build-common.ts index 1cfaa771d529..2e888f72b429 100644 --- a/addon/ng2/models/webpack-build-common.ts +++ b/addon/ng2/models/webpack-build-common.ts @@ -22,16 +22,6 @@ export function getWebpackCommonConfig(projectRoot: string, sourceDir: string) { filename: '[name].bundle.js' }, module: { - preLoaders: [ - { - test: /\.js$/, - loader: 'source-map-loader', - exclude: [ - path.resolve(projectRoot, 'node_modules/rxjs'), - path.resolve(projectRoot, 'node_modules/@angular'), - ] - } - ], loaders: [ { test: /\.ts$/, diff --git a/addon/ng2/models/webpack-build-development.ts b/addon/ng2/models/webpack-build-development.ts index 3465a28bf4c0..15feea54287b 100644 --- a/addon/ng2/models/webpack-build-development.ts +++ b/addon/ng2/models/webpack-build-development.ts @@ -11,6 +11,14 @@ export const getWebpackDevConfigPartial = function(projectRoot: string, sourceDi sourceMapFilename: '[name].map', chunkFilename: '[id].chunk.js' }, + module: { + preLoaders: [ + { + test: /\.js$/, + loader: 'source-map-loader' + } + ] + }, tslint: { emitErrors: false, failOnHint: false, diff --git a/addon/ng2/models/webpack-build-production.ts b/addon/ng2/models/webpack-build-production.ts index 9866b7add430..ba7b1ef4fcb6 100644 --- a/addon/ng2/models/webpack-build-production.ts +++ b/addon/ng2/models/webpack-build-production.ts @@ -15,6 +15,17 @@ export const getWebpackProdConfigPartial = function(projectRoot: string, sourceD sourceMapFilename: '[name].[chunkhash].bundle.map', chunkFilename: '[id].[chunkhash].chunk.js' }, + module: { + preLoaders: [ + { + test: /\.js$/, + loader: 'source-map-loader', + exclude: [ + /node_modules/ // don't pull in vendor sourcemaps for production builds, increased speed for build + ] + } + ] + }, plugins: [ new WebpackMd5Hash(), new webpack.optimize.DedupePlugin(), diff --git a/addon/ng2/models/webpack-build-utils.ts b/addon/ng2/models/webpack-build-utils.ts index dcaa15558593..8706093af3f4 100644 --- a/addon/ng2/models/webpack-build-utils.ts +++ b/addon/ng2/models/webpack-build-utils.ts @@ -19,5 +19,6 @@ export const webpackDevServerOutputOptions = { hash: true, timings: true, chunks: false, - chunkModules: false + chunkModules: false, + warning: false } From ddcdfa279a0380786023442e706c5f0cf0ac9760 Mon Sep 17 00:00:00 2001 From: Sean Larkin Date: Fri, 12 Aug 2016 16:09:53 -0500 Subject: [PATCH 2/2] fix: change dev server output name to warnings --- addon/ng2/models/webpack-build-utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/ng2/models/webpack-build-utils.ts b/addon/ng2/models/webpack-build-utils.ts index 8706093af3f4..579ee34662cd 100644 --- a/addon/ng2/models/webpack-build-utils.ts +++ b/addon/ng2/models/webpack-build-utils.ts @@ -20,5 +20,5 @@ export const webpackDevServerOutputOptions = { timings: true, chunks: false, chunkModules: false, - warning: false + warnings: false }