From dc9cc2f528f7b103e7e4c6346946445eac567c80 Mon Sep 17 00:00:00 2001 From: Cesar Dario Garcia Date: Mon, 21 Mar 2016 02:58:55 -0700 Subject: [PATCH] perf(benchpress) refactor function collectExpressionInputs --- benchmarks/largetable/angular.js | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/benchmarks/largetable/angular.js b/benchmarks/largetable/angular.js index 071a358..879910f 100644 --- a/benchmarks/largetable/angular.js +++ b/benchmarks/largetable/angular.js @@ -12420,19 +12420,11 @@ function $ParseProvider() { return addInterceptor(noop, interceptorFn); } }; - - function collectExpressionInputs(inputs, list) { - for (var i = 0, ii = inputs.length; i < ii; i++) { - var input = inputs[i]; - if (!input.constant) { - if (input.inputs) { - collectExpressionInputs(input.inputs, list); - } else if (list.indexOf(input) === -1) { // TODO(perf) can we do better? - list.push(input); - } - } + + function collectExpressionInputs(inputs, list){ + for(let value of inputs => !value.constant){ + list.push(value); } - return list; }