Skip to content

fix(Sankey): insufficient pass-in parameters for the callback function of edgeStyle#3483

Merged
visiky merged 1 commit intoantvis:masterfrom
csjkevin:fix-sankey
Mar 3, 2023
Merged

fix(Sankey): insufficient pass-in parameters for the callback function of edgeStyle#3483
visiky merged 1 commit intoantvis:masterfrom
csjkevin:fix-sankey

Conversation

@csjkevin
Copy link
Contributor

@csjkevin csjkevin commented Mar 2, 2023

PR includes

  • fix the bug that the the callback function edgeStyle has no sufficient parameters

Before:

Only the parameters of name, x and y are passed into the callback function edgeStyle. The value of name is the name of the source node. Users cannot get the name of the target node while using edgeStyle. The rawFields does not affect.

After:

The parameters of source and target are passed into the callback function edgeStyle. Users can get the name of the target node from target. The rawFields takes effect.

@github-actions github-actions bot added bugfix and removed bugfix labels Mar 2, 2023
@hustcc hustcc requested review from lxfu1 and visiky March 2, 2023 03:48
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 2, 2023
@visiky visiky merged commit 0a4f376 into antvis:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants