From dc3ff9d39a1ae8a86e8274f509f634bce056baba Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Tue, 28 Nov 2023 13:52:47 +0100 Subject: [PATCH] Skip port forwarding also for base ports when running pre-commits When pre-commits are run and breeze shell is opened they were both attempting to use the same port forwarding. However pre-commits do not ever need port forwarding because the forwarded ports are only needed when you run breeze shell interactively. This is a follow-up afte #35862. This PR removes port forwarding when "pre-commit" project name is used to run breeze shell command. --- dev/breeze/src/airflow_breeze/params/shell_params.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/breeze/src/airflow_breeze/params/shell_params.py b/dev/breeze/src/airflow_breeze/params/shell_params.py index a314075d29ddb..32f6a111ce24d 100644 --- a/dev/breeze/src/airflow_breeze/params/shell_params.py +++ b/dev/breeze/src/airflow_breeze/params/shell_params.py @@ -314,7 +314,7 @@ def compose_file(self) -> str: f"from sources but from {self.use_airflow_version}[/]" ) self.mount_sources = MOUNT_REMOVE - if self.forward_ports: + if self.forward_ports and not self.project_name == "pre-commit": compose_file_list.append(DOCKER_COMPOSE_DIR / "base-ports.yml") if self.mount_sources == MOUNT_SELECTED: compose_file_list.append(DOCKER_COMPOSE_DIR / "local.yml")