From 253ba4595c0861df8c51ef48967734b12ade0e77 Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Sun, 22 Jun 2025 09:08:01 +0200 Subject: [PATCH] [v3-0-test] When UI files change in PR we build CI image / run all static checks (#52009) Previously when only UI files changed (for example when dependabot bumped UI dependencies), the CI image was not built and only basic static checks were run - which did not show error when dependency upgrade caused different results when compiling ui assets (cherry picked from commit 294cd86e5b42457e135e6c1be045badc45514329) Co-authored-by: Jarek Potiuk --- dev/breeze/src/airflow_breeze/utils/selective_checks.py | 1 + dev/breeze/tests/test_selective_checks.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/breeze/src/airflow_breeze/utils/selective_checks.py b/dev/breeze/src/airflow_breeze/utils/selective_checks.py index 1d53a730356ef..17e1b08b482e7 100644 --- a/dev/breeze/src/airflow_breeze/utils/selective_checks.py +++ b/dev/breeze/src/airflow_breeze/utils/selective_checks.py @@ -802,6 +802,7 @@ def ci_image_build(self) -> bool: or self.docs_build or self.run_kubernetes_tests or self.needs_helm_tests + or self.run_ui_tests or self.pyproject_toml_changed or self.any_provider_yaml_or_pyproject_toml_changed ) diff --git a/dev/breeze/tests/test_selective_checks.py b/dev/breeze/tests/test_selective_checks.py index 84e7795c3be9e..00acb4634f356 100644 --- a/dev/breeze/tests/test_selective_checks.py +++ b/dev/breeze/tests/test_selective_checks.py @@ -1171,7 +1171,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str): "all-python-versions-list-as-string": DEFAULT_PYTHON_MAJOR_MINOR_VERSION, "python-versions": f"['{DEFAULT_PYTHON_MAJOR_MINOR_VERSION}']", "python-versions-list-as-string": DEFAULT_PYTHON_MAJOR_MINOR_VERSION, - "ci-image-build": "false", + "ci-image-build": "true", "prod-image-build": "false", "needs-helm-tests": "false", "run-tests": "false",