From 99f423b2d128f94dbe898d4bae11b573625306c6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=9D=9C=E6=98=8E?= <ming.du5@gientech.com>
Date: Fri, 21 Mar 2025 14:10:47 +0800
Subject: [PATCH] Fix ambari-metrics-grafana start scipt only check pid file
 exist.   This commit fixes a bug where when the metrics-grafana service was
 stopped outside the Ambari interface, attempting to start Grafana through the
 Ambari interface would incorrectly report the service as already running
 while Grafana had actually failed to start. The resolution addresses this
 state mismatch and ensures proper service status synchronization.

---
 .../conf/unix/ambari-metrics-grafana            | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana b/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
index 92857994..4746ba8c 100644
--- a/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
+++ b/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana
@@ -89,7 +89,22 @@ fi
 DAEMON_OPTS="--pidfile=${PID_FILE} --config=${CONF_FILE} cfg:default.paths.data=${DATA_DIR} cfg:default.paths.logs=${LOG_DIR}"
 
 function isRunning() {
-  test -e "$PID_FILE"
+  if [ -f ${PID_FILE} ]; then
+    PID=`cat ${PID_FILE}`
+    if [ -z "`ps ax -o pid | grep -w ${PID}`" ]; then
+      echo "${PID_FILE} found with no process. Removing ${PID}..."
+      rm -f ${PID_FILE}
+      return 1
+    else
+      tput bold
+      echo "WARN: Grafana already running with PID: ${PID}"
+      tput sgr0
+      echo "Exiting."
+      return 0
+    fi
+  else
+    return 1
+  fi
 }
 
 case "$1" in