From ba51e4b06d5dffbee30e2b95d0c32c527a935367 Mon Sep 17 00:00:00 2001 From: Boaz Date: Sun, 19 Sep 2021 18:05:39 +0300 Subject: [PATCH] Make BooleanBufferBuilder get_bit not require mutable reference (#784) --- arrow/src/array/builder.rs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arrow/src/array/builder.rs b/arrow/src/array/builder.rs index 00317e6622e1..97403c144f4a 100644 --- a/arrow/src/array/builder.rs +++ b/arrow/src/array/builder.rs @@ -329,7 +329,7 @@ impl BooleanBufferBuilder { } #[inline] - pub fn get_bit(&mut self, index: usize) -> bool { + pub fn get_bit(&self, index: usize) -> bool { bit_util::get_bit(self.buffer.as_slice(), index) } @@ -2551,6 +2551,17 @@ mod tests { assert!(buffer.get_bit(0)); } + #[test] + fn test_bool_buffer_builder_get_first_bit_not_requires_mutability() { + let buffer = { + let mut buffer = BooleanBufferBuilder::new(16); + buffer.append_n(8, true); + buffer + }; + + assert!(buffer.get_bit(0)); + } + #[test] fn test_bool_buffer_builder_get_last_bit() { let mut buffer = BooleanBufferBuilder::new(16);