From ad3d9aa07e82d5763d19ca6da0ef43a2402c1cf6 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Fri, 8 Apr 2022 14:26:44 -0300 Subject: [PATCH 1/2] add 'engine' to to the list of capabilities we don't care about; clarify package startup message --- r/R/arrow-package.R | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/r/R/arrow-package.R b/r/R/arrow-package.R index 896363a4786..9ca3841b312 100644 --- a/r/R/arrow-package.R +++ b/r/R/arrow-package.R @@ -107,7 +107,12 @@ # # Let's print a message if some are off if (some_features_are_off(features)) { - packageStartupMessage("See arrow_info() for available features") + packageStartupMessage( + paste( + "Some features of Arrow C++ are turned off.", + "Run `arrow_info()` for more information." + ) + ) } }) } @@ -264,7 +269,7 @@ arrow_info <- function() { some_features_are_off <- function(features) { # `features` is a named logical vector (as in arrow_info()$capabilities) # Let's exclude some less relevant ones - blocklist <- c("lzo", "bz2", "brotli") + blocklist <- c("lzo", "bz2", "brotli", "engine") # Return TRUE if any of the other features are FALSE !all(features[setdiff(names(features), blocklist)]) } From e8ecc22560f0a4721723b940807c6b8754416e5d Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Fri, 8 Apr 2022 15:52:20 -0300 Subject: [PATCH 2/2] Update r/R/arrow-package.R Co-authored-by: Jonathan Keane --- r/R/arrow-package.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/r/R/arrow-package.R b/r/R/arrow-package.R index 9ca3841b312..3c810bb8f27 100644 --- a/r/R/arrow-package.R +++ b/r/R/arrow-package.R @@ -109,7 +109,7 @@ if (some_features_are_off(features)) { packageStartupMessage( paste( - "Some features of Arrow C++ are turned off.", + "Some features are not enabled in this build of Arrow.", "Run `arrow_info()` for more information." ) )