From cab7b96c471e152e7bc0623b1b34f8e65c22e203 Mon Sep 17 00:00:00 2001 From: Rok Date: Wed, 3 Aug 2022 22:05:57 +0200 Subject: [PATCH 1/3] Minor change --- r/NEWS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/r/NEWS.md b/r/NEWS.md index 81ef8c07e83..2cf46db22b4 100644 --- a/r/NEWS.md +++ b/r/NEWS.md @@ -109,7 +109,8 @@ As of version 10.0.0, `arrow` requires C++17 to build. This means that: * `map_batches()` returns a `RecordBatchReader` and requires that the function it maps returns something coercible to a `RecordBatch` through the `as_record_batch()` S3 function. It can also run in streaming fashion if passed `.lazy = TRUE`. (ARROW-15271, ARROW-16703) * Functions can be called with package namespace prefixes (e.g. `stringr::`, `lubridate::`) within queries. For example, `stringr::str_length` will now dispatch to the same kernel as `str_length`. (ARROW-14575) * Support for new functions: - * `lubridate::parse_date_time()` datetime parser: (ARROW-14848, ARROW-16407) + * `lubridate::parse_date_time()` datetime parser: (ARROW-14848, ARROW-16407, ARROW-16653) + * most formats are now supported. * `orders` with year, month, day, hours, minutes, and seconds components are supported. * the `orders` argument in the Arrow binding works as follows: `orders` are transformed into `formats` which subsequently get applied in turn. There is no `select_formats` parameter and no inference takes place (like is the case in `lubridate::parse_date_time()`). * `lubridate` date and datetime parsers such as `lubridate::ymd()`, `lubridate::yq()`, and `lubridate::ymd_hms()` (ARROW-16394, ARROW-16516, ARROW-16395) From 50e3200976bece25c9d5135afc6c793d85636239 Mon Sep 17 00:00:00 2001 From: Rok Mihevc Date: Mon, 16 Jan 2023 16:30:16 +0100 Subject: [PATCH 2/3] Review feedback. --- r/NEWS.md | 1 - r/R/dplyr-funcs-datetime.R | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/r/NEWS.md b/r/NEWS.md index 2cf46db22b4..cae3aa0a176 100644 --- a/r/NEWS.md +++ b/r/NEWS.md @@ -110,7 +110,6 @@ As of version 10.0.0, `arrow` requires C++17 to build. This means that: * Functions can be called with package namespace prefixes (e.g. `stringr::`, `lubridate::`) within queries. For example, `stringr::str_length` will now dispatch to the same kernel as `str_length`. (ARROW-14575) * Support for new functions: * `lubridate::parse_date_time()` datetime parser: (ARROW-14848, ARROW-16407, ARROW-16653) - * most formats are now supported. * `orders` with year, month, day, hours, minutes, and seconds components are supported. * the `orders` argument in the Arrow binding works as follows: `orders` are transformed into `formats` which subsequently get applied in turn. There is no `select_formats` parameter and no inference takes place (like is the case in `lubridate::parse_date_time()`). * `lubridate` date and datetime parsers such as `lubridate::ymd()`, `lubridate::yq()`, and `lubridate::ymd_hms()` (ARROW-16394, ARROW-16516, ARROW-16395) diff --git a/r/R/dplyr-funcs-datetime.R b/r/R/dplyr-funcs-datetime.R index 42159f4f470..3fe08c4f460 100644 --- a/r/R/dplyr-funcs-datetime.R +++ b/r/R/dplyr-funcs-datetime.R @@ -699,7 +699,9 @@ register_bindings_datetime_parsers <- function() { } }, notes = c( - "`quiet = FALSE` is not supported" + "`quiet = FALSE` is not supported", + "Available formats are H, I, j, M, S, U, w, W, y, Y, R, T.", + "On Linux and OS X additionally a, A, b, B, Om, p, r are available." ) ) From 50046a4e7259bc79779cf698bbd5b9bbd89fb2dc Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Mon, 16 Jan 2023 13:30:20 -0400 Subject: [PATCH 3/3] run devtools::document() --- r/R/dplyr-funcs-doc.R | 2 ++ r/man/acero.Rd | 7 +++++-- r/man/arrow-package.Rd | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/r/R/dplyr-funcs-doc.R b/r/R/dplyr-funcs-doc.R index 4858f392ea0..b619cfe509b 100644 --- a/r/R/dplyr-funcs-doc.R +++ b/r/R/dplyr-funcs-doc.R @@ -262,6 +262,8 @@ #' * [`my()`][lubridate::my()]: `locale` argument not supported #' * [`myd()`][lubridate::myd()]: `locale` argument not supported #' * [`parse_date_time()`][lubridate::parse_date_time()]: `quiet = FALSE` is not supported +#' Available formats are H, I, j, M, S, U, w, W, y, Y, R, T. +#' On Linux and OS X additionally a, A, b, B, Om, p, r are available. #' * [`pm()`][lubridate::pm()] #' * [`qday()`][lubridate::qday()] #' * [`quarter()`][lubridate::quarter()] diff --git a/r/man/acero.Rd b/r/man/acero.Rd index a54b210e187..6b5563acdf9 100644 --- a/r/man/acero.Rd +++ b/r/man/acero.Rd @@ -6,7 +6,7 @@ \description{ The \code{arrow} package contains methods for 37 \code{dplyr} table functions, many of which are "verbs" that do transformations to one or more tables. -The package also has mappings of 209 R functions to the corresponding +The package also has mappings of 211 R functions to the corresponding functions in the Arrow compute library. These allow you to write code inside of \code{dplyr} methods that call R functions, including many in packages like \code{stringr} and \code{lubridate}, and they will get translated to Arrow and run @@ -229,7 +229,8 @@ Valid values are "s", "ms" (default), "us", "ns". \item \code{\link[lubridate:parse_date_time]{fast_strptime()}}: non-default values of \code{lt} and \code{cutoff_2000} not supported \item \code{\link[lubridate:round_date]{floor_date()}} \item \code{\link[lubridate:force_tz]{force_tz()}}: Timezone conversion from non-UTC timezone not supported; -When \code{roll = FALSE} and hit a non-existent time, raise an error +\code{roll_dst} values of 'error' and 'boundary' are supported for nonexistent times, +\code{roll_dst} values of 'error', 'pre', and 'post' are supported for ambiguous times. \item \code{\link[lubridate:format_ISO8601]{format_ISO8601()}} \item \code{\link[lubridate:hour]{hour()}} \item \code{\link[lubridate:date_utils]{is.Date()}} @@ -253,6 +254,8 @@ providing both \code{num} and \code{...} is not supported \item \code{\link[lubridate:ymd]{my()}}: \code{locale} argument not supported \item \code{\link[lubridate:ymd]{myd()}}: \code{locale} argument not supported \item \code{\link[lubridate:parse_date_time]{parse_date_time()}}: \code{quiet = FALSE} is not supported +Available formats are H, I, j, M, S, U, w, W, y, Y, R, T. +On Linux and OS X additionally a, A, b, B, Om, p, r are available. \item \code{\link[lubridate:am]{pm()}} \item \code{\link[lubridate:day]{qday()}} \item \code{\link[lubridate:quarter]{quarter()}} diff --git a/r/man/arrow-package.Rd b/r/man/arrow-package.Rd index e1b6808f6bf..b6cf0509e3e 100644 --- a/r/man/arrow-package.Rd +++ b/r/man/arrow-package.Rd @@ -18,12 +18,12 @@ Useful links: } \author{ -\strong{Maintainer}: Neal Richardson \email{neal@ursalabs.org} +\strong{Maintainer}: Nic Crane \email{thisisnic@gmail.com} Authors: \itemize{ + \item Neal Richardson \email{neal.p.richardson@gmail.com} \item Ian Cook \email{ianmcook@gmail.com} - \item Nic Crane \email{thisisnic@gmail.com} \item Dewey Dunnington \email{dewey@fishandwhistle.net} (\href{https://orcid.org/0000-0002-9415-4582}{ORCID}) \item Romain François \email{romain@rstudio.com} (\href{https://orcid.org/0000-0002-2444-4226}{ORCID}) \item Jonathan Keane \email{jkeane@gmail.com}