From 1a216d089ef65fe28a54a7b47575d52080430c64 Mon Sep 17 00:00:00 2001 From: Alenka Frim Date: Mon, 3 Oct 2022 15:16:23 +0200 Subject: [PATCH 1/5] Change src/arrow/python location mentioned in the text --- docs/source/python/getting_involved.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/python/getting_involved.rst b/docs/source/python/getting_involved.rst index 87fa0aca37f..36434554615 100644 --- a/docs/source/python/getting_involved.rst +++ b/docs/source/python/getting_involved.rst @@ -70,6 +70,6 @@ used as foundations to build easier to use entities. so that in the other ``.pyx`` files they can be used to implement Python classes, functions and helpers. * PyArrow is also based on dedicated pieces of code that are written into Arrow itself. - Those live into ``cpp/src/arrow/python`` directory and provide the low level + Those live in ``python/pyarrow/src/arrow/python`` directory and provide the low level code for capabilities like converting to and from numpy or pandas and the classes that allow to use Python objects and callbacks in C++. \ No newline at end of file From 7e0ea168d1fa69c7221e978a808d39187ac2b5c1 Mon Sep 17 00:00:00 2001 From: Alenka Frim Date: Tue, 4 Oct 2022 14:14:51 +0200 Subject: [PATCH 2/5] Add correction to PyArrow Architectural Overview --- docs/source/python/getting_involved.rst | 2 +- docs/source/python/py_arch_overview.svg | 1 - docs/source/python/savefig/py_arch_overview.svg | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 docs/source/python/py_arch_overview.svg create mode 100644 docs/source/python/savefig/py_arch_overview.svg diff --git a/docs/source/python/getting_involved.rst b/docs/source/python/getting_involved.rst index 36434554615..7de4a22feed 100644 --- a/docs/source/python/getting_involved.rst +++ b/docs/source/python/getting_involved.rst @@ -47,7 +47,7 @@ less complex to use. So while in some cases it might be easy to map what's in C++ to what's in Python, in many cases the C++ classes and methods are used as foundations to build easier to use entities. -.. image:: py_arch_overview.svg +.. image:: /python/savefig/py_arch_overview.svg :alt: Four layers of PyArrow architecture: .py, .pyx, .pxd and low level C++ code. * The ``*.py`` files in the pyarrow package are usually where the entities diff --git a/docs/source/python/py_arch_overview.svg b/docs/source/python/py_arch_overview.svg deleted file mode 100644 index 11f09eb8c6d..00000000000 --- a/docs/source/python/py_arch_overview.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/docs/source/python/savefig/py_arch_overview.svg b/docs/source/python/savefig/py_arch_overview.svg new file mode 100644 index 00000000000..8f0dd8838ca --- /dev/null +++ b/docs/source/python/savefig/py_arch_overview.svg @@ -0,0 +1 @@ + \ No newline at end of file From c2be07b27501b5a7c39ebda5a60477c1d0dcd493 Mon Sep 17 00:00:00 2001 From: Alenka Frim Date: Wed, 5 Oct 2022 09:03:05 +0200 Subject: [PATCH 3/5] Try to update the last item in arch overview list --- docs/source/python/getting_involved.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/source/python/getting_involved.rst b/docs/source/python/getting_involved.rst index 7de4a22feed..4c5d6dd8487 100644 --- a/docs/source/python/getting_involved.rst +++ b/docs/source/python/getting_involved.rst @@ -69,7 +69,8 @@ used as foundations to build easier to use entities. for usage in Cython. Here the C++ classes and methods are declared as they are so that in the other ``.pyx`` files they can be used to implement Python classes, functions and helpers. -* PyArrow is also based on dedicated pieces of code that are written into Arrow itself. - Those live in ``python/pyarrow/src/arrow/python`` directory and provide the low level +* Apart from Arrow C++ library, which dependence is mentioned in the previous line, + PyArrow is also based on PyArrow C++, dedicated pieces of code that live in + ``python/pyarrow/src/arrow/python`` directory and provide the low level code for capabilities like converting to and from numpy or pandas and the classes that allow to use Python objects and callbacks in C++. \ No newline at end of file From fa1233f1f781314aa33fcf11363f444660943dd0 Mon Sep 17 00:00:00 2001 From: Alenka Frim Date: Wed, 5 Oct 2022 09:03:59 +0200 Subject: [PATCH 4/5] Rename savefig -> images --- docs/source/python/{savefig => images}/py_arch_overview.svg | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/source/python/{savefig => images}/py_arch_overview.svg (100%) diff --git a/docs/source/python/savefig/py_arch_overview.svg b/docs/source/python/images/py_arch_overview.svg similarity index 100% rename from docs/source/python/savefig/py_arch_overview.svg rename to docs/source/python/images/py_arch_overview.svg From 1d9d8c69dd75132129d84ef66f9e2be14d8afeae Mon Sep 17 00:00:00 2001 From: Alenka Frim Date: Tue, 11 Oct 2022 10:18:43 +0200 Subject: [PATCH 5/5] Fix folder name error --- docs/source/python/getting_involved.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/python/getting_involved.rst b/docs/source/python/getting_involved.rst index 4c5d6dd8487..1f05aa9088f 100644 --- a/docs/source/python/getting_involved.rst +++ b/docs/source/python/getting_involved.rst @@ -47,7 +47,7 @@ less complex to use. So while in some cases it might be easy to map what's in C++ to what's in Python, in many cases the C++ classes and methods are used as foundations to build easier to use entities. -.. image:: /python/savefig/py_arch_overview.svg +.. image:: /python/images/py_arch_overview.svg :alt: Four layers of PyArrow architecture: .py, .pyx, .pxd and low level C++ code. * The ``*.py`` files in the pyarrow package are usually where the entities