From aa658518c56e85222767366a01c9b1141bcb3232 Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Wed, 5 Oct 2022 15:54:52 +0530 Subject: [PATCH 1/6] fix(temp): adding scale factor --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index adc5ec70ebd..7ddbc9edc8b 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1033,9 +1033,10 @@ TEST(HashJoin, Random) { // for EQ only: // constexpr int key_cmp_mask = 0x01; constexpr int min_num_rows = 1; - const int max_num_rows = parallel ? 20000 : 2000; - constexpr int min_batch_size = 10; - constexpr int max_batch_size = 100; + const int scale = 10; + const int max_num_rows = parallel ? 20000 * scale : 2000 * scale; + constexpr int min_batch_size = 100 * scale; + constexpr int max_batch_size = 1000 * scale; // Generate list of key field data types int num_key_fields = rng.from_range(1, max_num_key_fields); From 35824c71d6970787033b03a9d1b9d7c5ff8e651b Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Thu, 6 Oct 2022 10:16:12 +0530 Subject: [PATCH 2/6] fix(scale) --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index 7ddbc9edc8b..0afb0e8ff41 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1033,7 +1033,7 @@ TEST(HashJoin, Random) { // for EQ only: // constexpr int key_cmp_mask = 0x01; constexpr int min_num_rows = 1; - const int scale = 10; + const int scale = 1; const int max_num_rows = parallel ? 20000 * scale : 2000 * scale; constexpr int min_batch_size = 100 * scale; constexpr int max_batch_size = 1000 * scale; From 367d6439092ecc8fbfa17d098dcc46b374d4c580 Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Tue, 11 Oct 2022 11:03:13 +0530 Subject: [PATCH 3/6] fix(temp) --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index 0afb0e8ff41..a866266f2d2 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1011,7 +1011,7 @@ TEST(HashJoin, Random) { bool disable_bloom_filter = (rng.from_range(0, 1) == 1); auto exec_ctx = std::make_unique( default_memory_pool(), parallel ? arrow::internal::GetCpuThreadPool() : nullptr); - + exec_ctx->set_use_threads(false); // Constraints RandomDataTypeConstraints type_constraints; type_constraints.Default(); From 9d626a3eaa1624276d6a5ab35880da585b3c65bd Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Tue, 11 Oct 2022 20:51:11 +0530 Subject: [PATCH 4/6] fix(test) --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index a866266f2d2..87c616cebd3 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1004,7 +1004,7 @@ TEST(HashJoin, Random) { #elif defined(ADDRESS_SANITIZER) const int num_tests = 25; #else - const int num_tests = 100; + const int num_tests = 1; #endif for (int test_id = 0; test_id < num_tests; ++test_id) { bool parallel = (rng.from_range(0, 1) == 1); From e0fef0d5a2ef59764f7953dd96b68ffb4253f4e5 Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Wed, 12 Oct 2022 07:26:05 +0530 Subject: [PATCH 5/6] fix(temp): reduce the number of tests --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index 87c616cebd3..30e8085265c 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1004,7 +1004,7 @@ TEST(HashJoin, Random) { #elif defined(ADDRESS_SANITIZER) const int num_tests = 25; #else - const int num_tests = 1; + const int num_tests = 25; #endif for (int test_id = 0; test_id < num_tests; ++test_id) { bool parallel = (rng.from_range(0, 1) == 1); From 0cc20069ed096cf4c042c1149494796effc7b9e9 Mon Sep 17 00:00:00 2001 From: Vibhatha Lakmal Abeykoon Date: Wed, 12 Oct 2022 21:19:41 +0530 Subject: [PATCH 6/6] fix(test): num_tests variable test --- cpp/src/arrow/compute/exec/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/exec/hash_join_node_test.cc b/cpp/src/arrow/compute/exec/hash_join_node_test.cc index 30e8085265c..a866266f2d2 100644 --- a/cpp/src/arrow/compute/exec/hash_join_node_test.cc +++ b/cpp/src/arrow/compute/exec/hash_join_node_test.cc @@ -1004,7 +1004,7 @@ TEST(HashJoin, Random) { #elif defined(ADDRESS_SANITIZER) const int num_tests = 25; #else - const int num_tests = 25; + const int num_tests = 100; #endif for (int test_id = 0; test_id < num_tests; ++test_id) { bool parallel = (rng.from_range(0, 1) == 1);