From f35a749eacd94d9a887d63536136744892967ced Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 09:02:04 +0900 Subject: [PATCH 01/12] GH-34914: [Packaging][Linux] Add support for Acero --- dev/release/rat_exclude_files.txt | 56 +------------------ .../apache-arrow/debian/control.in | 29 +++++++++- .../apache-arrow/yum/arrow.spec.in | 34 +++++++++++ 3 files changed, 64 insertions(+), 55 deletions(-) diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt index b606ef85ed5..d37790912b0 100644 --- a/dev/release/rat_exclude_files.txt +++ b/dev/release/rat_exclude_files.txt @@ -47,61 +47,11 @@ dev/tasks/linux-packages/apache-arrow-apt-source/debian/compat dev/tasks/linux-packages/apache-arrow-apt-source/debian/control dev/tasks/linux-packages/apache-arrow-apt-source/debian/rules dev/tasks/linux-packages/apache-arrow-apt-source/debian/source/format +dev/tasks/linux-packages/apache-arrow/debian/*.doc-base +dev/tasks/linux-packages/apache-arrow/debian/*.install +dev/tasks/linux-packages/apache-arrow/debian/*.links dev/tasks/linux-packages/apache-arrow/debian/compat dev/tasks/linux-packages/apache-arrow/debian/control.in -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-arrow-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-arrow-cuda-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-arrow-dataset-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-arrow-flight-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-arrow-flight-sql-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-gandiva-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/gir1.2-parquet-1.0.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dataset1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight-sql1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-flight1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libarrow1200.install -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libgandiva1200.install -dev/tasks/linux-packages/apache-arrow/debian/libparquet-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib-dev.install -dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib-doc.doc-base -dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib-doc.install -dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib-doc.links -dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib1200.install -dev/tasks/linux-packages/apache-arrow/debian/libparquet1200.install dev/tasks/linux-packages/apache-arrow/debian/patches/series dev/tasks/linux-packages/apache-arrow/debian/rules dev/tasks/linux-packages/apache-arrow/debian/shlibs.local diff --git a/dev/tasks/linux-packages/apache-arrow/debian/control.in b/dev/tasks/linux-packages/apache-arrow/debian/control.in index 01f4ab03a35..3c7a3a57d6a 100644 --- a/dev/tasks/linux-packages/apache-arrow/debian/control.in +++ b/dev/tasks/linux-packages/apache-arrow/debian/control.in @@ -79,6 +79,19 @@ Description: Apache Arrow is a data processing library for analysis . This package provides C++ library files for CUDA support. +Package: libarrow-acero1200 +Section: libs +Architecture: any +Multi-Arch: same +Pre-Depends: ${misc:Pre-Depends} +Depends: + ${misc:Depends}, + ${shlibs:Depends}, + libarrow1200 (= ${binary:Version}) +Description: Apache Arrow is a data processing library for analysis + . + This package provides C++ library files for Acero module. + Package: libarrow-dataset1200 Section: libs Architecture: any @@ -87,7 +100,7 @@ Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends}, ${shlibs:Depends}, - libarrow1200 (= ${binary:Version}), + libarrow_acero1200 (= ${binary:Version}), libparquet1200 (= ${binary:Version}) Description: Apache Arrow is a data processing library for analysis . @@ -159,13 +172,25 @@ Description: Apache Arrow is a data processing library for analysis . This package provides C++ header files for CUDA support. +Package: libarrow-acero-dev +Section: libdevel +Architecture: any +Multi-Arch: same +Depends: + ${misc:Depends}, + libarrow-acero1200 (= ${binary:Version}), + libparquet-dev (= ${binary:Version}) +Description: Apache Arrow is a data processing library for analysis + . + This package provides C++ header files for Acero module. + Package: libarrow-dataset-dev Section: libdevel Architecture: any Multi-Arch: same Depends: ${misc:Depends}, - libarrow-dev (= ${binary:Version}), + libarrow-acero-dev (= ${binary:Version}), libarrow-dataset1200 (= ${binary:Version}), libparquet-dev (= ${binary:Version}) Description: Apache Arrow is a data processing library for analysis diff --git a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in index 32bd3a36131..f06c64e9fcd 100644 --- a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in +++ b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in @@ -320,6 +320,7 @@ Libraries and header files for Apache Arrow C++. %{_datadir}/arrow/gdb/ %{_datadir}/gdb/auto-load/ %{_includedir}/arrow/ +%exclude %{_includedir}/arrow/acero/ %exclude %{_includedir}/arrow/dataset/ %if %{use_flight} %exclude %{_includedir}/arrow/flight/ @@ -336,6 +337,39 @@ Libraries and header files for Apache Arrow C++. %{_libdir}/pkgconfig/arrow-orc.pc %{_libdir}/pkgconfig/arrow.pc +%package -n %{name}%{major_version}-acero-libs +Summary: C++ library to execute a query in streaming +License: Apache-2.0 +Requires: %{name}%{major_version}-libs = %{version}-%{release} + +%description -n %{name}%{major_version}-acero-libs +This package contains the libraries for Apache Arrow Acero. + +%files -n %{name}%{major_version}-acero-libs +%defattr(-,root,root,-) +%doc README.md +%license LICENSE.txt NOTICE.txt +%{_libdir}/libarrow_acero.so.* + +%package acero-devel +Summary: Libraries and header files for Apache Arrow Acero +License: Apache-2.0 +Requires: %{name}%{major_version}-acero-libs = %{version}-%{release} +Requires: %{name}-devel = %{version}-%{release} + +%description acero-devel +Libraries and header files for Apache Arrow Acero + +%files acero-devel +%defattr(-,root,root,-) +%doc README.md +%license LICENSE.txt NOTICE.txt +%{_includedir}/arrow/acero/ +%{_libdir}/cmake/ArrowAcero/ +%{_libdir}/libarrow_acero.a +%{_libdir}/libarrow_acero.so +%{_libdir}/pkgconfig/arrow-acero.pc + %package -n %{name}%{major_version}-dataset-libs Summary: C++ library to read and write semantic datasets stored in different locations and formats License: Apache-2.0 From d4244ef92c20c0294406b01d912dcc35058c0de5 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 09:04:53 +0900 Subject: [PATCH 02/12] Add missing patterns --- dev/tasks/tasks.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index 03dbe96deb0..5fc7c023efd 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -571,11 +571,15 @@ tasks: - apache-arrow_{no_rc_version}.orig.tar.gz {% endif %} - gir1.2-arrow-1.0_{no_rc_version}-1_[a-z0-9]+.deb + - gir1.2-arrow-acero-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-dataset-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-flight-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-flight-sql-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-gandiva-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-parquet-1.0_{no_rc_version}-1_[a-z0-9]+.deb + - libarrow-acero-dev_{no_rc_version}-1_[a-z0-9]+.deb + - libarrow-acero1200-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb + - libarrow-acero1200_{no_rc_version}-1_[a-z0-9]+.deb - libarrow-dataset-dev_{no_rc_version}-1_[a-z0-9]+.deb - libarrow-dataset-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb - libarrow-dataset-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb @@ -659,6 +663,12 @@ tasks: - apache-arrow-release-{no_rc_version}-1.[a-z0-9]+.noarch.rpm - apache-arrow-release-{no_rc_version}-1.[a-z0-9]+.src.rpm {% endif %} + - arrow[0-9]+-acero-libs-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm + - arrow-acero-devel-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm + {% if not is_rhel7_based %} + - arrow[0-9]+-acero-libs-debuginfo-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm + {% endif %} + - arrow[0-9]+-dataset-libs-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm - arrow-dataset-devel-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm - arrow-dataset-glib-devel-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm - arrow-dataset-glib-doc-{no_rc_version}-1.[a-z0-9]+.[a-z0-9_]+.rpm From 326dcf7f6cad68dac97238d48e1ffa5729e2a095 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 09:08:14 +0900 Subject: [PATCH 03/12] Add missing requires --- dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in index f06c64e9fcd..560c9394835 100644 --- a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in +++ b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in @@ -373,7 +373,8 @@ Libraries and header files for Apache Arrow Acero %package -n %{name}%{major_version}-dataset-libs Summary: C++ library to read and write semantic datasets stored in different locations and formats License: Apache-2.0 -Requires: %{name}%{major_version}-libs = %{version}-%{release} +Requires: %{name}%{major_version}-acero-libs = %{version}-%{release} +Requires: parquet%{major_version}-libs = %{version}-%{release} %description -n %{name}%{major_version}-dataset-libs This package contains the libraries for Apache Arrow dataset. @@ -388,7 +389,8 @@ This package contains the libraries for Apache Arrow dataset. Summary: Libraries and header files for Apache Arrow dataset. License: Apache-2.0 Requires: %{name}%{major_version}-dataset-libs = %{version}-%{release} -Requires: %{name}-devel = %{version}-%{release} +Requires: %{name}-acero-devel = %{version}-%{release} +Requires: parquet-devel = %{version}-%{release} %description dataset-devel Libraries and header files for Apache Arrow dataset. From a966b3173fb8937c2c8ed2ad9de0f34a56411611 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 09:08:20 +0900 Subject: [PATCH 04/12] Update expected --- dev/release/post-11-bump-versions-test.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dev/release/post-11-bump-versions-test.rb b/dev/release/post-11-bump-versions-test.rb index 9dd29f93aa5..73f65fe6c8f 100644 --- a/dev/release/post-11-bump-versions-test.rb +++ b/dev/release/post-11-bump-versions-test.rb @@ -308,13 +308,6 @@ def test_deb_package_names } end expected_changes = [ - { - sampled_diff: [ - "-dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda-glib#{@so_version}.install", - "+dev/tasks/linux-packages/apache-arrow/debian/libarrow-cuda-glib#{@next_so_version}.install", - ], - path: "dev/release/rat_exclude_files.txt", - }, { sampled_diff: [ "-Package: libarrow#{@so_version}", From 57abb225cc0f60b9560fc582ace349b2b7264533 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 10:51:46 +0900 Subject: [PATCH 05/12] Add missing files --- .../linux-packages/apache-arrow/debian/arrow-tools.install | 1 + .../apache-arrow/debian/libarrow-acero-dev.install | 4 ++++ .../apache-arrow/debian/libarrow-acero1200.install | 1 + .../linux-packages/apache-arrow/debian/parquet-tools.install | 1 + 4 files changed, 7 insertions(+) create mode 100644 dev/tasks/linux-packages/apache-arrow/debian/arrow-tools.install create mode 100644 dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero-dev.install create mode 100644 dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero1200.install create mode 100644 dev/tasks/linux-packages/apache-arrow/debian/parquet-tools.install diff --git a/dev/tasks/linux-packages/apache-arrow/debian/arrow-tools.install b/dev/tasks/linux-packages/apache-arrow/debian/arrow-tools.install new file mode 100644 index 00000000000..c4d52b7c766 --- /dev/null +++ b/dev/tasks/linux-packages/apache-arrow/debian/arrow-tools.install @@ -0,0 +1 @@ +usr/bin/arrow-* diff --git a/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero-dev.install b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero-dev.install new file mode 100644 index 00000000000..9cb9847e765 --- /dev/null +++ b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero-dev.install @@ -0,0 +1,4 @@ +usr/lib/*/cmake/ArrowAcero/ +usr/lib/*/libarrow_acero.a +usr/lib/*/libarrow_acero.so +usr/lib/*/pkgconfig/arrow-acero.pc diff --git a/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero1200.install b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero1200.install new file mode 100644 index 00000000000..7dc5670840d --- /dev/null +++ b/dev/tasks/linux-packages/apache-arrow/debian/libarrow-acero1200.install @@ -0,0 +1 @@ +usr/lib/*/libarrow_acero.so.* diff --git a/dev/tasks/linux-packages/apache-arrow/debian/parquet-tools.install b/dev/tasks/linux-packages/apache-arrow/debian/parquet-tools.install new file mode 100644 index 00000000000..c3748c3d91f --- /dev/null +++ b/dev/tasks/linux-packages/apache-arrow/debian/parquet-tools.install @@ -0,0 +1 @@ +usr/bin/parquet-* From 9733d548f8785119e138dd9bc9d71a9813ab729e Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 11:09:30 +0900 Subject: [PATCH 06/12] Fix requires in arrow-dataset.pc --- cpp/src/arrow/dataset/CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cpp/src/arrow/dataset/CMakeLists.txt b/cpp/src/arrow/dataset/CMakeLists.txt index e1b14b77c47..1671c2c4a49 100644 --- a/cpp/src/arrow/dataset/CMakeLists.txt +++ b/cpp/src/arrow/dataset/CMakeLists.txt @@ -31,10 +31,9 @@ set(ARROW_DATASET_SRCS scanner.cc scan_node.cc) +set(ARROW_DATASET_PKG_CONFIG_REQUIRES arrow_acero) if(ARROW_PARQUET) - set(ARROW_DATASET_PKG_CONFIG_REQUIRES parquet) -else() - set(ARROW_DATASET_PKG_CONFIG_REQUIRES arrow arrow_acero) + list(APPEND ARROW_DATASET_PKG_CONFIG_REQUIRES parquet) endif() set(ARROW_DATASET_STATIC_LINK_LIBS) From 83e7bd909af8f99fcaf9a9f99e7019579c976a4d Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 11:29:49 +0900 Subject: [PATCH 07/12] Disable Vala for CentOS 7 --- .../apache-arrow/yum/arrow.spec.in | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in index 560c9394835..007602c4c57 100644 --- a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in +++ b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in @@ -77,6 +77,7 @@ # Travis CI. # %%define use_s3 (%%{rhel} >= 8) %define use_s3 0 +%define use_vala (%{rhel} >= 8) %define have_lz4_libs (%{rhel} >= 8) %define have_rapidjson (%{rhel} != 8) @@ -146,7 +147,9 @@ BuildRequires: ncurses-devel BuildRequires: gobject-introspection-devel BuildRequires: gtk-doc +%if %{use_vala} BuildRequires: vala +%endif %description Apache Arrow is a data processing library for analysis. @@ -212,7 +215,9 @@ meson setup build \ -Darrow_cpp_build_dir=../cpp/%{arrow_cmake_builddir} \ -Darrow_cpp_build_type=$cpp_build_type \ -Dgtk_doc=true \ +%if %{use_vala} -Dvapi=true +%endif LD_LIBRARY_PATH=$PWD/../cpp/%{arrow_cmake_builddir}/$cpp_build_type \ meson compile -C build %{?_smp_mflags} @@ -595,7 +600,9 @@ Libraries and header files for Apache Arrow GLib. %license LICENSE.txt NOTICE.txt %{_datadir}/arrow-glib/example/ %{_datadir}/gir-1.0/Arrow-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/arrow-glib.* +%endif %{_includedir}/arrow-glib/ %{_libdir}/libarrow-glib.a %{_libdir}/libarrow-glib.so @@ -647,7 +654,9 @@ Libraries and header files for Apache Arrow Dataset GLib. %doc README.md %license LICENSE.txt NOTICE.txt %{_datadir}/gir-1.0/ArrowDataset-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/arrow-dataset-glib.* +%endif %{_includedir}/arrow-dataset-glib/ %{_libdir}/libarrow-dataset-glib.a %{_libdir}/libarrow-dataset-glib.so @@ -698,7 +707,9 @@ Libraries and header files for Apache Arrow Flight GLib. %doc README.md %license LICENSE.txt NOTICE.txt %{_datadir}/gir-1.0/ArrowFlight-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/arrow-flight-glib.* +%endif %{_includedir}/arrow-flight-glib/ %{_libdir}/libarrow-flight-glib.a %{_libdir}/libarrow-flight-glib.so @@ -748,7 +759,9 @@ Libraries and header files for Apache Arrow Flight SQL GLib. %doc README.md %license LICENSE.txt NOTICE.txt %{_datadir}/gir-1.0/ArrowFlightSQL-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/arrow-flight-sql-glib.* +%endif %{_includedir}/arrow-flight-sql-glib/ %{_libdir}/libarrow-flight-sql-glib.a %{_libdir}/libarrow-flight-sql-glib.so @@ -800,7 +813,9 @@ Libraries and header files for Gandiva GLib. %doc README.md %license LICENSE.txt NOTICE.txt %{_datadir}/gir-1.0/Gandiva-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/gandiva-glib.* +%endif %{_includedir}/gandiva-glib/ %{_libdir}/libgandiva-glib.a %{_libdir}/libgandiva-glib.so @@ -851,7 +866,9 @@ Libraries and header files for Apache Parquet GLib. %doc README.md %license LICENSE.txt NOTICE.txt %{_datadir}/gir-1.0/Parquet-*.gir +%if %{use_vala} %{_datadir}/vala/vapi/parquet-glib.* +%endif %{_includedir}/parquet-glib/ %{_libdir}/libparquet-glib.a %{_libdir}/libparquet-glib.so From 3a2bbc89964839e255c7c0f2956652c6a91a6e17 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 14:45:21 +0900 Subject: [PATCH 08/12] Update verify-yum.sh --- dev/release/verify-yum.sh | 16 ++++++++++------ .../apache-arrow/yum/arrow.spec.in | 2 +- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/dev/release/verify-yum.sh b/dev/release/verify-yum.sh index c28b262fe61..c9285afdbe2 100755 --- a/dev/release/verify-yum.sh +++ b/dev/release/verify-yum.sh @@ -57,6 +57,7 @@ have_glib=yes have_parquet=yes have_python=yes have_ruby=yes +have_vala=yes ruby_devel_packages=(ruby-devel) install_command="dnf install -y --enablerepo=crb" uninstall_command="dnf remove -y" @@ -105,6 +106,7 @@ case "${distribution}-${distribution_version}" in have_gandiva=no have_python=no have_ruby=no + have_vala=no install_command="yum install -y" uninstall_command="yum remove -y" clean_command="yum clean" @@ -234,12 +236,14 @@ if [ "${have_glib}" = "yes" ]; then ${install_command} --enablerepo=epel arrow-glib-devel-${package_version} ${install_command} --enablerepo=epel arrow-glib-doc-${package_version} - ${install_command} vala - cp -a "${TOP_SOURCE_DIR}/c_glib/example/vala" build/ - pushd build/vala - valac --pkg arrow-glib --pkg posix build.vala - ./build - popd + if [ "${have_vala}" = "yes" ]; then + ${install_command} vala + cp -a "${TOP_SOURCE_DIR}/c_glib/example/vala" build/ + pushd build/vala + valac --pkg arrow-glib --pkg posix build.vala + ./build + popd + fi if [ "${have_ruby}" = "yes" ]; then ${install_command} "${ruby_devel_packages[@]}" diff --git a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in index 007602c4c57..da5db95526c 100644 --- a/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in +++ b/dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in @@ -77,7 +77,7 @@ # Travis CI. # %%define use_s3 (%%{rhel} >= 8) %define use_s3 0 -%define use_vala (%{rhel} >= 8) +%define use_vala (%{rhel} >= 8 || %{is_amazon_linux}) %define have_lz4_libs (%{rhel} >= 8) %define have_rapidjson (%{rhel} != 8) From 0c8837a8a24486acd8e3975720a793f05cd36c0d Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 14:46:23 +0900 Subject: [PATCH 09/12] Fix a typo --- dev/tasks/linux-packages/apache-arrow/debian/control.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/linux-packages/apache-arrow/debian/control.in b/dev/tasks/linux-packages/apache-arrow/debian/control.in index 3c7a3a57d6a..eb279c534c5 100644 --- a/dev/tasks/linux-packages/apache-arrow/debian/control.in +++ b/dev/tasks/linux-packages/apache-arrow/debian/control.in @@ -100,7 +100,7 @@ Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends}, ${shlibs:Depends}, - libarrow_acero1200 (= ${binary:Version}), + libarrow-acero1200 (= ${binary:Version}), libparquet1200 (= ${binary:Version}) Description: Apache Arrow is a data processing library for analysis . From eb0b8c1c427b5a5950e5d0406d6de46d4bc021eb Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 14:54:45 +0900 Subject: [PATCH 10/12] Update expected --- dev/release/post-11-bump-versions-test.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/release/post-11-bump-versions-test.rb b/dev/release/post-11-bump-versions-test.rb index 73f65fe6c8f..96d24eccb09 100644 --- a/dev/release/post-11-bump-versions-test.rb +++ b/dev/release/post-11-bump-versions-test.rb @@ -317,8 +317,8 @@ def test_deb_package_names }, { sampled_diff: [ - "- - libarrow-dataset-glib#{@so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", - "+ - libarrow-dataset-glib#{@next_so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", + "- - libarrow-acero-glib#{@so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", + "+ - libarrow-acero-glib#{@next_so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", ], path: "dev/tasks/tasks.yml", }, From 0a70e64ed2a071d62b805c9aeb9721a0c8ded9c5 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 6 Apr 2023 15:18:25 +0900 Subject: [PATCH 11/12] Update expected --- dev/release/post-11-bump-versions-test.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/release/post-11-bump-versions-test.rb b/dev/release/post-11-bump-versions-test.rb index 96d24eccb09..cc35b93cc99 100644 --- a/dev/release/post-11-bump-versions-test.rb +++ b/dev/release/post-11-bump-versions-test.rb @@ -317,8 +317,8 @@ def test_deb_package_names }, { sampled_diff: [ - "- - libarrow-acero-glib#{@so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", - "+ - libarrow-acero-glib#{@next_so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", + "- - libarrow-acero#{@so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", + "+ - libarrow-acero#{@next_so_version}-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb", ], path: "dev/tasks/tasks.yml", }, From ec127eeff37abcbefa7963810c96690359aab899 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Fri, 7 Apr 2023 05:01:48 +0900 Subject: [PATCH 12/12] Update pattern --- dev/tasks/tasks.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index 5fc7c023efd..89fbe9b46ad 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -571,7 +571,6 @@ tasks: - apache-arrow_{no_rc_version}.orig.tar.gz {% endif %} - gir1.2-arrow-1.0_{no_rc_version}-1_[a-z0-9]+.deb - - gir1.2-arrow-acero-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-dataset-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-flight-1.0_{no_rc_version}-1_[a-z0-9]+.deb - gir1.2-arrow-flight-sql-1.0_{no_rc_version}-1_[a-z0-9]+.deb