From c6710c1755048ab11f067bf67fa1cc22848759b1 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Fri, 25 Aug 2023 11:22:59 +0100 Subject: [PATCH 1/2] Update check to error not warn --- ci/scripts/r_test.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ci/scripts/r_test.sh b/ci/scripts/r_test.sh index d7df44e2e43..e0c2ce9efed 100755 --- a/ci/scripts/r_test.sh +++ b/ci/scripts/r_test.sh @@ -65,6 +65,8 @@ export _R_CHECK_DONTTEST_EXAMPLES_=TRUE export _R_CHECK_FORCE_SUGGESTS_=FALSE export _R_CHECK_LIMIT_CORES_=FALSE export _R_CHECK_TESTS_NLINES_=0 +# This can cause failures on CRAN but needs to be set here so issues an error not a warning +export _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_=TRUE # By default, aws-sdk tries to contact a non-existing local ip host # to retrieve metadata. Disable this so that S3FileSystem tests run faster. From 98158f8f9009f520821706a3a0cf8c247e9949a1 Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Fri, 25 Aug 2023 14:37:49 +0100 Subject: [PATCH 2/2] Add flag to Windows build --- .github/workflows/r.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml index 277080bec5c..807d21b6c80 100644 --- a/.github/workflows/r.yml +++ b/.github/workflows/r.yml @@ -305,7 +305,8 @@ jobs: RWINLIB_LOCAL = file.path(Sys.getenv("GITHUB_WORKSPACE"), "r", "windows", "libarrow.zip"), MAKEFLAGS = paste0("-j", parallel::detectCores()), ARROW_R_DEV = TRUE, - "_R_CHECK_FORCE_SUGGESTS_" = FALSE + "_R_CHECK_FORCE_SUGGESTS_" = FALSE, + "_R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_" = TRUE ) rcmdcheck::rcmdcheck(".", build_args = '--no-build-vignettes',