From d20f7c9825265454a3e3e226326dc2ab4e253612 Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 12 Oct 2023 11:54:39 +0200 Subject: [PATCH 01/10] [CI] Ignore deprecation warning from aiohttp --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/python/setup.cfg b/python/setup.cfg index 618fa475cd9..87434936f4e 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -28,6 +28,7 @@ build-dir = doc/_build addopts = --ignore=scripts filterwarnings = error:The SparseDataFrame:FutureWarning + ignore:Setting custom ClientSession:DeprecationWarning:aiohttp # Get a debug traceback when a test takes a really long time faulthandler_timeout = 300 From 7b8e9db4c30b38a98d1739bae4371b6600218290 Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 12 Oct 2023 12:13:26 +0200 Subject: [PATCH 02/10] remove library selection --- python/setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index 87434936f4e..263a4a97b3d 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -28,7 +28,7 @@ build-dir = doc/_build addopts = --ignore=scripts filterwarnings = error:The SparseDataFrame:FutureWarning - ignore:Setting custom ClientSession:DeprecationWarning:aiohttp + ignore:Setting custom ClientSession:DeprecationWarning # Get a debug traceback when a test takes a really long time faulthandler_timeout = 300 From 78460fa8522cd5a02d4f1401e9fca30f59b89421 Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 12 Oct 2023 13:01:24 +0200 Subject: [PATCH 03/10] add to cli arg as well --- dev/tasks/tasks.yml | 2 +- python/setup.cfg | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index 09503788756..b04e261b9a6 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,7 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: "-W error" + PYTEST_ARGS: "-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'" image: conda-python {% endfor %} diff --git a/python/setup.cfg b/python/setup.cfg index 263a4a97b3d..3df4ff27ef8 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -28,6 +28,7 @@ build-dir = doc/_build addopts = --ignore=scripts filterwarnings = error:The SparseDataFrame:FutureWarning + # https://github.com/apache/arrow/issues/38239 ignore:Setting custom ClientSession:DeprecationWarning # Get a debug traceback when a test takes a really long time faulthandler_timeout = 300 From 4b07aca877c2ee1cce2d024bbb056f64bef6d76d Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 12 Oct 2023 13:40:02 +0200 Subject: [PATCH 04/10] test different syntax --- dev/tasks/tasks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index b04e261b9a6..a10b912fda5 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,7 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: "-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'" + PYTEST_ARGS: "-W error -W ignore:Setting custom ClientSession:DeprecationWarning" image: conda-python {% endfor %} From 33c672a135d392d63ad2800354e362b6abc1a159 Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 12 Oct 2023 14:09:08 +0200 Subject: [PATCH 05/10] try escape the quote --- dev/tasks/tasks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index a10b912fda5..cd13f029917 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,7 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: "-W error -W ignore:Setting custom ClientSession:DeprecationWarning" + PYTEST_ARGS: "-W error -W \"ignore:Setting custom ClientSession:DeprecationWarning\"" image: conda-python {% endfor %} From 3e333864bc0536c47a98d20e0e33003f4c806134 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Fri, 13 Oct 2023 03:41:42 +0200 Subject: [PATCH 06/10] Adjust quotes so valid gha yaml is generated --- dev/tasks/tasks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index cd13f029917..4657d9bd2c9 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,7 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: "-W error -W \"ignore:Setting custom ClientSession:DeprecationWarning\"" + PYTEST_ARGS: '-W error -W \"ignore:Setting custom ClientSession:DeprecationWarning\"' image: conda-python {% endfor %} From 3115ea6a00ae25251c34f6f6d82a57b4887b3d07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Fri, 13 Oct 2023 11:31:24 +0200 Subject: [PATCH 07/10] Try single quotes on ignore --- dev/tasks/tasks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index 4657d9bd2c9..b04e261b9a6 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,7 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: '-W error -W \"ignore:Setting custom ClientSession:DeprecationWarning\"' + PYTEST_ARGS: "-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'" image: conda-python {% endfor %} From d27837636c9c41a9a0b0110c40de5c35a395d021 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Fri, 13 Oct 2023 11:51:44 +0200 Subject: [PATCH 08/10] Try parameter substitution instead of parameter expansion --- ci/scripts/python_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/scripts/python_test.sh b/ci/scripts/python_test.sh index 8d818346faa..9fbe6c77345 100755 --- a/ci/scripts/python_test.sh +++ b/ci/scripts/python_test.sh @@ -59,4 +59,4 @@ export PYARROW_TEST_PARQUET export PYARROW_TEST_S3 # Testing PyArrow -pytest -r s ${PYTEST_ARGS} --pyargs pyarrow +pytest -r s $(PYTEST_ARGS) --pyargs pyarrow From 2e3041490d277ff07fabc1ee585d16733a46f74c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Fri, 13 Oct 2023 12:06:31 +0200 Subject: [PATCH 09/10] Revert "Try parameter substitution instead of parameter expansion" This reverts commit d27837636c9c41a9a0b0110c40de5c35a395d021. --- ci/scripts/python_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/scripts/python_test.sh b/ci/scripts/python_test.sh index 9fbe6c77345..8d818346faa 100755 --- a/ci/scripts/python_test.sh +++ b/ci/scripts/python_test.sh @@ -59,4 +59,4 @@ export PYARROW_TEST_PARQUET export PYARROW_TEST_S3 # Testing PyArrow -pytest -r s $(PYTEST_ARGS) --pyargs pyarrow +pytest -r s ${PYTEST_ARGS} --pyargs pyarrow From 148d5b2e071599ca817123fdf9058c7e5679bf4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Fri, 13 Oct 2023 14:30:34 +0200 Subject: [PATCH 10/10] Temporarily disable erroring on Warnings to have CI passing --- dev/tasks/tasks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index b04e261b9a6..04afe79d4d9 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -1241,7 +1241,8 @@ tasks: params: env: PYTHON: "{{ python_version }}" - PYTEST_ARGS: "-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'" + # Temporarily disable error on Warning: https://github.com/apache/arrow/issues/38239 + # PYTEST_ARGS: "-W error -W 'ignore:Setting custom ClientSession:DeprecationWarning'" image: conda-python {% endfor %}