From c27166f40af6e8db3587f7305f13e4f8f1226ff3 Mon Sep 17 00:00:00 2001 From: zanmato Date: Wed, 20 Dec 2023 19:23:57 -0800 Subject: [PATCH] Bring back case_when tests for union types --- .../compute/kernels/scalar_if_else_test.cc | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_if_else_test.cc b/cpp/src/arrow/compute/kernels/scalar_if_else_test.cc index a11aab81742..771261cac91 100644 --- a/cpp/src/arrow/compute/kernels/scalar_if_else_test.cc +++ b/cpp/src/arrow/compute/kernels/scalar_if_else_test.cc @@ -2485,16 +2485,14 @@ TEST(TestCaseWhen, UnionBoolString) { } } -// FIXME(GH-15192): enabling this test produces test failures - -// TEST(TestCaseWhen, UnionBoolStringRandom) { -// for (const auto& type : std::vector>{ -// sparse_union({field("a", boolean()), field("b", utf8())}, {2, 7}), -// dense_union({field("a", boolean()), field("b", utf8())}, {2, 7})}) { -// ARROW_SCOPED_TRACE(type->ToString()); -// TestCaseWhenRandom(type); -// } -// } +TEST(TestCaseWhen, UnionBoolStringRandom) { + for (const auto& type : std::vector>{ + sparse_union({field("a", boolean()), field("b", utf8())}, {2, 7}), + dense_union({field("a", boolean()), field("b", utf8())}, {2, 7})}) { + ARROW_SCOPED_TRACE(type->ToString()); + TestCaseWhenRandom(type); + } +} TEST(TestCaseWhen, DispatchBest) { CheckDispatchBest("case_when", {struct_({field("", boolean())}), int64(), int32()},