From 41ebc1bb9e8086ad816caa44c2e11f56f84e1cd1 Mon Sep 17 00:00:00 2001 From: "xiansen.chen" Date: Thu, 25 Jan 2024 20:04:15 +0800 Subject: [PATCH 1/2] fix failures in dataset-scanner-benchmark Signed-off-by: xiansen.chen --- cpp/src/arrow/dataset/scanner_benchmark.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpp/src/arrow/dataset/scanner_benchmark.cc b/cpp/src/arrow/dataset/scanner_benchmark.cc index be953b35559..108e8eb4262 100644 --- a/cpp/src/arrow/dataset/scanner_benchmark.cc +++ b/cpp/src/arrow/dataset/scanner_benchmark.cc @@ -162,7 +162,11 @@ void ScanOnly( acero::DeclarationToTable(std::move(scan))); ASSERT_GT(collected->num_rows(), 0); - ASSERT_EQ(collected->num_columns(), 2); + if (factory_name == "scan") { + ASSERT_EQ(collected->num_columns(), 6); + } else if (factory_name == "scan2") { + ASSERT_EQ(collected->num_columns(), 2); + } } static constexpr int kScanIdx = 0; From d6bf11d80eee2a686f80de5030657f76a4b4c8a2 Mon Sep 17 00:00:00 2001 From: "xiansen.chen" Date: Thu, 25 Jan 2024 21:06:12 +0800 Subject: [PATCH 2/2] fix code style Signed-off-by: xiansen.chen --- cpp/src/arrow/dataset/scanner_benchmark.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/src/arrow/dataset/scanner_benchmark.cc b/cpp/src/arrow/dataset/scanner_benchmark.cc index 108e8eb4262..287d76418ff 100644 --- a/cpp/src/arrow/dataset/scanner_benchmark.cc +++ b/cpp/src/arrow/dataset/scanner_benchmark.cc @@ -163,9 +163,9 @@ void ScanOnly( ASSERT_GT(collected->num_rows(), 0); if (factory_name == "scan") { - ASSERT_EQ(collected->num_columns(), 6); + ASSERT_EQ(collected->num_columns(), 6); } else if (factory_name == "scan2") { - ASSERT_EQ(collected->num_columns(), 2); + ASSERT_EQ(collected->num_columns(), 2); } }