From 54a349d09913cd8fcab9bb74af0bbc2d379df30c Mon Sep 17 00:00:00 2001 From: Divyansh200102 Date: Thu, 22 Feb 2024 00:53:16 +0530 Subject: [PATCH 1/7] Update scalar_temporal_unary.cc --- cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index f49e201492c..a62546f292b 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1782,7 +1782,10 @@ const FunctionDoc strptime_doc( ("For each string in `strings`, parse it as a timestamp.\n" "The timestamp unit and the expected string pattern must be given\n" "in StrptimeOptions. Null inputs emit null. If a non-null string\n" - "fails parsing, an error is returned by default."), + "fails parsing, an error is returned by default.\n" + "\n" + "**Note:** The strptime kernel currently ignores the %Z specifier for any string." + ), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{ "Convert naive timestamp to timezone-aware timestamp", From 084fa491db8bf63b20d5fb7bce31417dbed593a2 Mon Sep 17 00:00:00 2001 From: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Date: Thu, 22 Feb 2024 09:11:19 +0530 Subject: [PATCH 2/7] Update cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc Co-authored-by: Rok Mihevc --- cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index a62546f292b..ced045a1bea 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1784,8 +1784,7 @@ const FunctionDoc strptime_doc( "in StrptimeOptions. Null inputs emit null. If a non-null string\n" "fails parsing, an error is returned by default.\n" "\n" - "**Note:** The strptime kernel currently ignores the %Z specifier for any string." - ), + "**Note:** The strptime kernel currently ignores the %Z specifier for any string."), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{ "Convert naive timestamp to timezone-aware timestamp", From e96a9728484581dc316a28046d5dfd3b270fefe0 Mon Sep 17 00:00:00 2001 From: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Date: Thu, 22 Feb 2024 16:21:09 +0530 Subject: [PATCH 3/7] Update cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc Co-authored-by: Rok Mihevc --- cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index ced045a1bea..ac9ef9b7bf6 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1784,7 +1784,7 @@ const FunctionDoc strptime_doc( "in StrptimeOptions. Null inputs emit null. If a non-null string\n" "fails parsing, an error is returned by default.\n" "\n" - "**Note:** The strptime kernel currently ignores the %Z specifier for any string."), + "**Note:** The strptime kernel currently ignores the %Z specifier for any string."), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{ "Convert naive timestamp to timezone-aware timestamp", From 296f2e7f52b34f6b8d4e40bd37c962fcc20119f8 Mon Sep 17 00:00:00 2001 From: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Date: Thu, 22 Feb 2024 18:01:29 +0530 Subject: [PATCH 4/7] Update cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc Co-authored-by: Rok Mihevc --- cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index ac9ef9b7bf6..4624aacb42a 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1784,7 +1784,8 @@ const FunctionDoc strptime_doc( "in StrptimeOptions. Null inputs emit null. If a non-null string\n" "fails parsing, an error is returned by default.\n" "\n" - "**Note:** The strptime kernel currently ignores the %Z specifier for any string."), + "**Note:** The strptime kernel currently ignores the %Z specifier for any \n" + "string."), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{ "Convert naive timestamp to timezone-aware timestamp", From 8dd4f1670fabc7eced3ba88d1ec1a0459c3d4ae8 Mon Sep 17 00:00:00 2001 From: Divyansh200102 Date: Sat, 24 Feb 2024 08:26:31 +0530 Subject: [PATCH 5/7] Update compute.rst --- docs/source/cpp/compute.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/source/cpp/compute.rst b/docs/source/cpp/compute.rst index e7310d2c0c7..82a8d2a1116 100644 --- a/docs/source/cpp/compute.rst +++ b/docs/source/cpp/compute.rst @@ -1327,7 +1327,7 @@ provided by a concrete function :func:`~arrow::compute::Cast`. +-----------------+------------+--------------------+------------------+--------------------------------+-------+ | strftime | Unary | Temporal | String | :struct:`StrftimeOptions` | \(1) | +-----------------+------------+--------------------+------------------+--------------------------------+-------+ -| strptime | Unary | String-like | Timestamp | :struct:`StrptimeOptions` | | +| strptime | Unary | String-like | Timestamp | :struct:`StrptimeOptions` | \(2) | +-----------------+------------+--------------------+------------------+--------------------------------+-------+ The conversions available with ``cast`` are listed below. In all cases, a @@ -1343,6 +1343,8 @@ null input value is converted into a null output value. .. _detailed formatting documentation: https://howardhinnant.github.io/date/date.html#to_stream_formatting +* \(2) The strptime kernel currently ignores the %Z specifier for any string. + **Truth value extraction** +-----------------------------+------------------------------------+--------------+ From 8a2360a3fe8559218130677cecb12864b2145ad2 Mon Sep 17 00:00:00 2001 From: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:17:50 +0530 Subject: [PATCH 6/7] Update docs/source/cpp/compute.rst Co-authored-by: Sutou Kouhei --- docs/source/cpp/compute.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/cpp/compute.rst b/docs/source/cpp/compute.rst index 82a8d2a1116..f01f504777d 100644 --- a/docs/source/cpp/compute.rst +++ b/docs/source/cpp/compute.rst @@ -1343,7 +1343,7 @@ null input value is converted into a null output value. .. _detailed formatting documentation: https://howardhinnant.github.io/date/date.html#to_stream_formatting -* \(2) The strptime kernel currently ignores the %Z specifier for any string. +* \(2) The strptime kernel currently ignores the ``%Z`` specifier for any string. **Truth value extraction** From 9168d5b758033372d100125d2e64e7c486355804 Mon Sep 17 00:00:00 2001 From: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:18:00 +0530 Subject: [PATCH 7/7] Update cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc Co-authored-by: Sutou Kouhei --- cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index 4624aacb42a..45ae35ffb95 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1784,7 +1784,7 @@ const FunctionDoc strptime_doc( "in StrptimeOptions. Null inputs emit null. If a non-null string\n" "fails parsing, an error is returned by default.\n" "\n" - "**Note:** The strptime kernel currently ignores the %Z specifier for any \n" + "**Note:** The strptime kernel currently ignores the %Z specifier for any\n" "string."), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{