From 7251176324359e680ad40e89a8abacb744ccd5dc Mon Sep 17 00:00:00 2001 From: Ruoxi Sun Date: Tue, 25 Jun 2024 19:35:04 +0800 Subject: [PATCH 1/3] Reduce the recursion of many join test --- cpp/src/arrow/acero/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/acero/hash_join_node_test.cc b/cpp/src/arrow/acero/hash_join_node_test.cc index 215b1e4d211..f7b442cc3c6 100644 --- a/cpp/src/arrow/acero/hash_join_node_test.cc +++ b/cpp/src/arrow/acero/hash_join_node_test.cc @@ -3220,7 +3220,7 @@ TEST(HashJoin, ManyJoins) { // stack), which is essentially the recursive usage of the temp vector stack. // A fair number of joins to guarantee temp vector stack overflow before GH-41335. - const int num_joins = 64; + const int num_joins = 16; // `ExecBatchBuilder::num_rows_max()` is the number of rows for swiss join to accumulate // before outputting. From 3e6acd8cae71a9523d564dda47d1ae372110d50a Mon Sep 17 00:00:00 2001 From: Ruoxi Sun Date: Tue, 25 Jun 2024 19:51:01 +0800 Subject: [PATCH 2/3] Double check by increasing again and see if CI fails --- cpp/src/arrow/acero/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/acero/hash_join_node_test.cc b/cpp/src/arrow/acero/hash_join_node_test.cc index f7b442cc3c6..6476bc038ac 100644 --- a/cpp/src/arrow/acero/hash_join_node_test.cc +++ b/cpp/src/arrow/acero/hash_join_node_test.cc @@ -3220,7 +3220,7 @@ TEST(HashJoin, ManyJoins) { // stack), which is essentially the recursive usage of the temp vector stack. // A fair number of joins to guarantee temp vector stack overflow before GH-41335. - const int num_joins = 16; + const int num_joins = 72; // `ExecBatchBuilder::num_rows_max()` is the number of rows for swiss join to accumulate // before outputting. From 6ccaa6cbdaa2780531d8a1718f2d7be289b4c0db Mon Sep 17 00:00:00 2001 From: Ruoxi Sun Date: Tue, 25 Jun 2024 20:03:53 +0800 Subject: [PATCH 3/3] Reduce the recursion of many join test again --- cpp/src/arrow/acero/hash_join_node_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/arrow/acero/hash_join_node_test.cc b/cpp/src/arrow/acero/hash_join_node_test.cc index 6476bc038ac..f7b442cc3c6 100644 --- a/cpp/src/arrow/acero/hash_join_node_test.cc +++ b/cpp/src/arrow/acero/hash_join_node_test.cc @@ -3220,7 +3220,7 @@ TEST(HashJoin, ManyJoins) { // stack), which is essentially the recursive usage of the temp vector stack. // A fair number of joins to guarantee temp vector stack overflow before GH-41335. - const int num_joins = 72; + const int num_joins = 16; // `ExecBatchBuilder::num_rows_max()` is the number of rows for swiss join to accumulate // before outputting.