diff --git a/java/.gitattributes b/java/.gitattributes index 596615322fb..366d3c2b3cd 100644 --- a/java/.gitattributes +++ b/java/.gitattributes @@ -1,2 +1,3 @@ .gitattributes export-ignore .gitignore export-ignore +* text=auto eol=lf diff --git a/java/dev/checkstyle/checkstyle.xml b/java/dev/checkstyle/checkstyle.xml index eb63c3ff0fc..4b546ac56ea 100644 --- a/java/dev/checkstyle/checkstyle.xml +++ b/java/dev/checkstyle/checkstyle.xml @@ -180,7 +180,7 @@ - + diff --git a/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/VectorSchemaRootTransformer.java b/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/VectorSchemaRootTransformer.java index b651e1eb9bc..b3c7a1ee5c6 100644 --- a/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/VectorSchemaRootTransformer.java +++ b/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/VectorSchemaRootTransformer.java @@ -44,6 +44,12 @@ class Builder { private final List newFields = new ArrayList<>(); private final Collection tasks = new ArrayList<>(); + /** + * Constructor for the VectorSchemaRootTransformer's Builder. + * + * @param schema The Arrow schema. + * @param bufferAllocator The BufferAllocator to use for allocating memory. + */ public Builder(final Schema schema, final BufferAllocator bufferAllocator) { this.schema = schema; this.bufferAllocator = @@ -127,6 +133,11 @@ public Builder addEmptyField(final String fieldName, final ArrowType fieldType) return this; } + /** + * Build the {@link VectorSchemaRoot} with applied transformation tasks. + * + * @return The built {@link VectorSchemaRoot}. + */ public VectorSchemaRootTransformer build() { return (originalRoot, transformedRoot) -> { if (transformedRoot == null) { diff --git a/java/pom.xml b/java/pom.xml index c62ae332b10..838e60b0372 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -105,6 +105,7 @@ under the License. 1.11.3 2 + 10.17.0 true 2.29.2 5.11.0 @@ -719,7 +720,7 @@ under the License. com.puppycrawl.tools checkstyle - 8.29 + ${checkstyle.version} org.slf4j diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java index 50ddf30bf7e..387033f0d2f 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java @@ -453,9 +453,9 @@ public void reAlloc() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseLargeVariableWidthVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseLargeVariableWidthVector.java index 3a177f84c98..552a896ea8c 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/BaseLargeVariableWidthVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseLargeVariableWidthVector.java @@ -259,9 +259,9 @@ public void clear() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Override @Deprecated diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java index 5d761ffbee9..aaccec602f2 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java @@ -275,9 +275,9 @@ public void clear() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java index f0c84bd4106..aee5233f9d4 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java @@ -315,9 +315,9 @@ public void clearDataBuffers() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java b/java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java index 208c8b416cf..3762fecd0bd 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java @@ -233,9 +233,9 @@ public List getFieldBuffers() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/FieldVector.java b/java/vector/src/main/java/org/apache/arrow/vector/FieldVector.java index e58f7bba844..391ef778169 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/FieldVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/FieldVector.java @@ -111,9 +111,9 @@ default void exportCDataBuffers(List buffers, ArrowBuf buffersPtr, lon /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated List getFieldInnerVectors(); diff --git a/java/vector/src/main/java/org/apache/arrow/vector/NullVector.java b/java/vector/src/main/java/org/apache/arrow/vector/NullVector.java index 25e5bdc6f46..227ca716f63 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/NullVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/NullVector.java @@ -224,9 +224,9 @@ public List getFieldBuffers() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java index 10637304df0..1cdb87eba03 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java @@ -142,9 +142,9 @@ protected void reallocOffsetBuffer() { /** * Get the offset vector. * + * @return the underlying offset vector or null if none exists. * @deprecated This API will be removed, as the current implementations no longer hold inner * offset vectors. - * @return the underlying offset vector or null if none exists. */ @Override @Deprecated diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java index ef2e7383a91..b5b32c8032d 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java @@ -319,9 +319,9 @@ private void setReaderAndWriterIndex() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override @@ -494,9 +494,9 @@ public void copyFrom(int inIndex, int outIndex, ValueVector from) { /** * Get the offset vector. * + * @return the underlying offset vector or null if none exists. * @deprecated This API will be removed, as the current implementations no longer hold inner * offset vectors. - * @return the underlying offset vector or null if none exists. */ @Override @Deprecated diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java index 17708167ff4..a1e18210fc6 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java @@ -277,9 +277,9 @@ private void setReaderAndWriterIndex() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java index 16492aec747..de7966a0aee 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/RepeatedValueVector.java @@ -35,9 +35,9 @@ public interface RepeatedValueVector extends ValueVector, DensityAwareVector { /** * Get the offset vector. * + * @return the underlying offset vector or null if none exists. * @deprecated This API will be removed, as the current implementations no longer hold inner * offset vectors. - * @return the underlying offset vector or null if none exists. */ @Deprecated UInt4Vector getOffsetVector(); diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java index 53f83fdfa7c..dda9b6547f7 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java @@ -188,9 +188,9 @@ private void setReaderAndWriterIndex() { /** * Get the inner vectors. * + * @return the inner vectors for this field as defined by the TypeLayout * @deprecated This API will be removed as the current implementations no longer support inner * vectors. - * @return the inner vectors for this field as defined by the TypeLayout */ @Deprecated @Override