From 098c945869942cf1d3b69b21374b08ea3a634286 Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Sat, 25 Mar 2017 15:00:21 -0400 Subject: [PATCH] Remove Array extern templates Change-Id: I38641bb9dec33c0df7df5385a82ac1b905023e71 --- cpp/src/arrow/array.h | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/cpp/src/arrow/array.h b/cpp/src/arrow/array.h index c73b7a87a4f..2b4cde5c8d8 100644 --- a/cpp/src/arrow/array.h +++ b/cpp/src/arrow/array.h @@ -505,38 +505,6 @@ class ARROW_EXPORT DictionaryArray : public Array { std::shared_ptr indices_; }; -// ---------------------------------------------------------------------- -// extern templates and other details - -// gcc and clang disagree about how to handle template visibility when you have -// explicit specializations https://llvm.org/bugs/show_bug.cgi?id=24815 -#if defined(__GNUC__) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wattributes" -#endif - -// Only instantiate these templates once -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; -extern template class ARROW_EXPORT NumericArray; - -#if defined(__GNUC__) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif - } // namespace arrow #endif