From 7002bc3a18f7e2d9186bc2abb3b3ac2c89530b49 Mon Sep 17 00:00:00 2001 From: David Li Date: Fri, 21 Jun 2019 08:50:22 -0400 Subject: [PATCH] Add test for independent Flight client shutdown in Java --- .../apache/arrow/flight/TestFlightClient.java | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 java/flight/src/test/java/org/apache/arrow/flight/TestFlightClient.java diff --git a/java/flight/src/test/java/org/apache/arrow/flight/TestFlightClient.java b/java/flight/src/test/java/org/apache/arrow/flight/TestFlightClient.java new file mode 100644 index 00000000000..273f11fd8cd --- /dev/null +++ b/java/flight/src/test/java/org/apache/arrow/flight/TestFlightClient.java @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.flight; + +import java.util.Collections; + +import org.apache.arrow.flight.FlightClient.ClientStreamListener; +import org.apache.arrow.flight.TestBasicOperation.Producer; +import org.apache.arrow.memory.BufferAllocator; +import org.apache.arrow.memory.RootAllocator; + +import org.apache.arrow.vector.VectorSchemaRoot; +import org.apache.arrow.vector.types.pojo.ArrowType; +import org.apache.arrow.vector.types.pojo.Field; +import org.apache.arrow.vector.types.pojo.Schema; +import org.junit.Assert; +import org.junit.Test; + +public class TestFlightClient { + /** + * ARROW-5063: make sure two clients to the same location can be closed independently. + */ + @Test + public void independentShutdown() throws Exception { + try (final BufferAllocator allocator = new RootAllocator(Integer.MAX_VALUE); + final FlightServer server = FlightTestUtil.getStartedServer( + port -> FlightServer.builder(allocator, Location.forGrpcInsecure(FlightTestUtil.LOCALHOST, port), + new Producer(allocator)).build())) { + final Location location = Location.forGrpcInsecure(FlightTestUtil.LOCALHOST, server.getPort()); + final Schema schema = new Schema(Collections.singletonList(Field.nullable("a", new ArrowType.Int(32, true)))); + try (final FlightClient client1 = FlightClient.builder(allocator, location).build(); + final VectorSchemaRoot root = VectorSchemaRoot.create(schema, allocator)) { + // Use startPut as this ensures the RPC won't finish until we want it to + final ClientStreamListener listener = client1.startPut(FlightDescriptor.path("test"), root); + try (final FlightClient client2 = FlightClient.builder(allocator, location).build()) { + client2.listActions().forEach(actionType -> Assert.assertNotNull(actionType.getType())); + } + listener.completed(); + listener.getResult(); + } + } + } +}