diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f545f5c280a..fe251be693a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -342,6 +342,7 @@ repos: ?^ci/scripts/python_build\.sh$| ?^ci/scripts/python_sdist_build\.sh$| ?^ci/scripts/python_sdist_test\.sh$| + ?^ci/scripts/python_test_emscripten\.sh$| ?^ci/scripts/python_wheel_unix_test\.sh$| ?^ci/scripts/r_build\.sh$| ?^ci/scripts/r_revdepcheck\.sh$| diff --git a/ci/scripts/python_test_emscripten.sh b/ci/scripts/python_test_emscripten.sh index 4029722568b..621ac4bd0d1 100755 --- a/ci/scripts/python_test_emscripten.sh +++ b/ci/scripts/python_test_emscripten.sh @@ -25,14 +25,15 @@ set -ex build_dir=${1}/python pyodide_dist_dir=${2} -cd ${build_dir} +cd "${build_dir}" # note: this uses the newest wheel in dist +# shellcheck disable=SC2012 pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1) echo "-------------- Running emscripten tests in Node ----------------------" -python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node +python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node echo "-------------- Running emscripten tests in Chrome --------------------" -python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome +python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome