From b7304e7dfd7319e97a0f846b56e9599deadb2d4a Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Sat, 4 Apr 2020 18:54:46 -0500 Subject: [PATCH 1/4] Readability --- python/examples/minimal_build/Dockerfile | 26 +++++ python/examples/minimal_build/README.md | 23 +++++ python/examples/minimal_build/build.sh | 122 +++++++++++++++++++++++ 3 files changed, 171 insertions(+) create mode 100644 python/examples/minimal_build/Dockerfile create mode 100644 python/examples/minimal_build/README.md create mode 100644 python/examples/minimal_build/build.sh diff --git a/python/examples/minimal_build/Dockerfile b/python/examples/minimal_build/Dockerfile new file mode 100644 index 00000000000..6f00f475bdc --- /dev/null +++ b/python/examples/minimal_build/Dockerfile @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM ubuntu:bionic + +ENV DEBIAN_FRONTEND=noninteractive + +RUN apt-get update -y -q && \ + apt-get install -y -q --no-install-recommends \ + build-essential \ + cmake && \ + apt-get clean && rm -rf /var/lib/apt/lists* diff --git a/python/examples/minimal_build/README.md b/python/examples/minimal_build/README.md new file mode 100644 index 00000000000..a9af4c404c0 --- /dev/null +++ b/python/examples/minimal_build/README.md @@ -0,0 +1,23 @@ + + +# Minimal Python source build on Linux + +This directory shows how to bootstrap a local build from source on Linux with +an eye toward maximum portability across different Linux distributions. \ No newline at end of file diff --git a/python/examples/minimal_build/build.sh b/python/examples/minimal_build/build.sh new file mode 100644 index 00000000000..3fee1d3c0d9 --- /dev/null +++ b/python/examples/minimal_build/build.sh @@ -0,0 +1,122 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Set $ARROW_ROOT to the path of your Arrow clone and run + +# docker build -t arrow_python_minimal . +# docker run --rm -t -i -v $PWD:/io -v $ARROW_ROOT:/arrow arrow_python_minimal /io/build.sh + +set -ex + +#---------------------------------------------------------------------- +# Change this to whatever makes sense for your system + +HOME= +MINICONDA=$HOME/miniconda-for-arrow +LIBRARY_INSTALL_DIR=$HOME/local-libs +CPP_BUILD_DIR=$HOME/arrow-cpp-build +ARROW_ROOT=/arrow +PYTHON=3.7 + +#---------------------------------------------------------------------- +# Run these only once + +function setup_miniconda() { + MINICONDA_URL="https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh" + wget -O miniconda.sh $MINICONDA_URL + bash miniconda.sh -b -p $MINICONDA + rm -f miniconda.sh + LOCAL_PATH=$PATH + export PATH="$MINICONDA/bin:$PATH" + + conda update -y -q conda + conda config --set auto_update_conda false + conda info -a + + conda config --set show_channel_urls True + conda config --add channels https://repo.continuum.io/pkgs/free + conda config --add channels conda-forge + + export PATH=$LOCAL_PATH +} + +function create_conda_environment() { + conda create -y -n pyarrow-$PYTHON -c conda-forge \ + --file arrow/ci/conda_env_unix.yml \ + --file arrow/ci/conda_env_cpp.yml \ + --file arrow/ci/conda_env_python.yml \ + --file arrow/ci/conda_env_gandiva.yml \ + compilers \ + python=3.7 \ + pandas +} + +setup_miniconda +create_conda_environment + +#---------------------------------------------------------------------- +# Activate conda in bash and activate conda environment + +. $MINICONDA/etc/profile.d/conda.sh +conda activate pyarrow-$PYTHON +export ARROW_HOME=$CONDA_PREFIX + +#---------------------------------------------------------------------- +# Build C++ library +NPROC=$(nproc) + +mkdir -p $CPP_BUILD_DIR +pushd $CPP_BUILD_DIR + +cmake -GNinja \ + -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \ + -DCMAKE_INSTALL_LIBDIR=lib \ + -DARROW_FLIGHT=ON \ + -DARROW_GANDIVA=ON \ + -DARROW_ORC=ON \ + -DARROW_WITH_BZ2=ON \ + -DARROW_WITH_ZLIB=ON \ + -DARROW_WITH_ZSTD=ON \ + -DARROW_WITH_LZ4=ON \ + -DARROW_WITH_SNAPPY=ON \ + -DARROW_WITH_BROTLI=ON \ + -DARROW_PARQUET=ON \ + -DARROW_PYTHON=ON \ + -DARROW_PLASMA=ON \ + -DARROW_BUILD_TESTS=ON \ + .. + +ninja install + +popd + +#---------------------------------------------------------------------- +# Build and test Python library +pushd $ARROW_ROOT/python + +rm -rf build/ # remove any pesky pre-existing build directory + +export PYARROW_WITH_FLIGHT=1 +export PYARROW_WITH_GANDIVA=1 +export PYARROW_WITH_ORC=1 +export PYARROW_WITH_PARQUET=1 + +python setup.py build_ext --inplace +python setup.py develop + +py.test pyarrow From 0d69f8edfc7ebdb9d18648743493ab76aedef4c3 Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Sat, 4 Apr 2020 21:55:14 -0500 Subject: [PATCH 2/4] Complete build_conda.sh cold start script --- .../examples/minimal_build/Dockerfile.fedora | 28 ++++++++++++++++ .../{Dockerfile => Dockerfile.ubuntu} | 1 + .../{build.sh => build_conda.sh} | 33 ++++++++++--------- 3 files changed, 47 insertions(+), 15 deletions(-) create mode 100644 python/examples/minimal_build/Dockerfile.fedora rename python/examples/minimal_build/{Dockerfile => Dockerfile.ubuntu} (98%) rename python/examples/minimal_build/{build.sh => build_conda.sh} (84%) mode change 100644 => 100755 diff --git a/python/examples/minimal_build/Dockerfile.fedora b/python/examples/minimal_build/Dockerfile.fedora new file mode 100644 index 00000000000..2a25756d675 --- /dev/null +++ b/python/examples/minimal_build/Dockerfile.fedora @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM fedora:31 + +RUN dnf update -y && \ + dnf install -y \ + autoconf \ + gcc \ + gcc-g++ \ + git \ + wget \ + make \ + ninja-build \ No newline at end of file diff --git a/python/examples/minimal_build/Dockerfile b/python/examples/minimal_build/Dockerfile.ubuntu similarity index 98% rename from python/examples/minimal_build/Dockerfile rename to python/examples/minimal_build/Dockerfile.ubuntu index 6f00f475bdc..f93fab062c5 100644 --- a/python/examples/minimal_build/Dockerfile +++ b/python/examples/minimal_build/Dockerfile.ubuntu @@ -16,6 +16,7 @@ # under the License. FROM ubuntu:bionic +FROM fedora:31 ENV DEBIAN_FRONTEND=noninteractive diff --git a/python/examples/minimal_build/build.sh b/python/examples/minimal_build/build_conda.sh old mode 100644 new mode 100755 similarity index 84% rename from python/examples/minimal_build/build.sh rename to python/examples/minimal_build/build_conda.sh index 3fee1d3c0d9..88e847a65e5 --- a/python/examples/minimal_build/build.sh +++ b/python/examples/minimal_build/build_conda.sh @@ -19,9 +19,9 @@ # Set $ARROW_ROOT to the path of your Arrow clone and run # docker build -t arrow_python_minimal . -# docker run --rm -t -i -v $PWD:/io -v $ARROW_ROOT:/arrow arrow_python_minimal /io/build.sh +# docker run --rm -t arrow_python_minimal -i -v $PWD:/io /io/build.sh -set -ex +set -e #---------------------------------------------------------------------- # Change this to whatever makes sense for your system @@ -33,6 +33,8 @@ CPP_BUILD_DIR=$HOME/arrow-cpp-build ARROW_ROOT=/arrow PYTHON=3.7 +git clone https://github.com/apache/arrow.git /arrow + #---------------------------------------------------------------------- # Run these only once @@ -52,22 +54,18 @@ function setup_miniconda() { conda config --add channels https://repo.continuum.io/pkgs/free conda config --add channels conda-forge - export PATH=$LOCAL_PATH -} - -function create_conda_environment() { conda create -y -n pyarrow-$PYTHON -c conda-forge \ --file arrow/ci/conda_env_unix.yml \ --file arrow/ci/conda_env_cpp.yml \ --file arrow/ci/conda_env_python.yml \ - --file arrow/ci/conda_env_gandiva.yml \ compilers \ python=3.7 \ pandas + + export PATH=$LOCAL_PATH } setup_miniconda -create_conda_environment #---------------------------------------------------------------------- # Activate conda in bash and activate conda environment @@ -78,17 +76,15 @@ export ARROW_HOME=$CONDA_PREFIX #---------------------------------------------------------------------- # Build C++ library -NPROC=$(nproc) mkdir -p $CPP_BUILD_DIR pushd $CPP_BUILD_DIR cmake -GNinja \ + -DCMAKE_BUILD_TYPE=DEBUG \ -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \ -DCMAKE_INSTALL_LIBDIR=lib \ -DARROW_FLIGHT=ON \ - -DARROW_GANDIVA=ON \ - -DARROW_ORC=ON \ -DARROW_WITH_BZ2=ON \ -DARROW_WITH_ZLIB=ON \ -DARROW_WITH_ZSTD=ON \ @@ -99,7 +95,7 @@ cmake -GNinja \ -DARROW_PYTHON=ON \ -DARROW_PLASMA=ON \ -DARROW_BUILD_TESTS=ON \ - .. + $ARROW_ROOT/cpp ninja install @@ -111,12 +107,19 @@ pushd $ARROW_ROOT/python rm -rf build/ # remove any pesky pre-existing build directory +export PYARROW_BUILD_TYPE=Debug +export PYARROW_CMAKE_GENERATOR=Ninja export PYARROW_WITH_FLIGHT=1 -export PYARROW_WITH_GANDIVA=1 -export PYARROW_WITH_ORC=1 export PYARROW_WITH_PARQUET=1 -python setup.py build_ext --inplace +# You can run either "develop" or "build_ext --inplace". Your pick + +# python setup.py build_ext --inplace python setup.py develop +# git submodules are required for unit tests +git submodule update --init +export PARQUET_TEST_DATA="$ARROW_ROOT/cpp/submodules/parquet-testing/data" +export ARROW_TEST_DATA="$ARROW_ROOT/testing/data" + py.test pyarrow From 3fb7f5edf8996342badaafb5d5bd18a6506363c0 Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Sat, 4 Apr 2020 23:54:14 -0500 Subject: [PATCH 3/4] Finish cleaning up minimal build examples --- docs/source/developers/python.rst | 33 ++++--- .../examples/minimal_build/Dockerfile.fedora | 5 +- .../examples/minimal_build/Dockerfile.ubuntu | 15 +++- python/examples/minimal_build/README.md | 40 ++++++++- python/examples/minimal_build/build_conda.sh | 5 +- python/examples/minimal_build/build_venv.sh | 88 +++++++++++++++++++ 6 files changed, 161 insertions(+), 25 deletions(-) create mode 100755 python/examples/minimal_build/build_venv.sh diff --git a/docs/source/developers/python.rst b/docs/source/developers/python.rst index 7cb340dbbb0..50eba0a3d76 100644 --- a/docs/source/developers/python.rst +++ b/docs/source/developers/python.rst @@ -252,7 +252,8 @@ folder as the repositories and a target installation folder: virtualenv pyarrow source ./pyarrow/bin/activate - pip install six numpy pandas cython pytest hypothesis + pip install -r arrow/python/requirements-build.txt \ + -r arrow/python/requirements-test.txt # This is the folder where we will install the Arrow libraries during # development @@ -281,9 +282,6 @@ Now build and install the Arrow C++ libraries: cmake -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \ -DCMAKE_INSTALL_LIBDIR=lib \ - -DARROW_FLIGHT=ON \ - -DARROW_GANDIVA=ON \ - -DARROW_ORC=ON \ -DARROW_WITH_BZ2=ON \ -DARROW_WITH_ZLIB=ON \ -DARROW_WITH_ZSTD=ON \ @@ -292,24 +290,23 @@ Now build and install the Arrow C++ libraries: -DARROW_WITH_BROTLI=ON \ -DARROW_PARQUET=ON \ -DARROW_PYTHON=ON \ - -DARROW_PLASMA=ON \ -DARROW_BUILD_TESTS=ON \ .. make -j4 make install popd -Many of these components are optional, and can be switched off by setting them -to ``OFF``: +There are a number of optional components that can can be switched ON by +adding flags with ``ON``: * ``ARROW_FLIGHT``: RPC framework * ``ARROW_GANDIVA``: LLVM-based expression compiler * ``ARROW_ORC``: Support for Apache ORC file format * ``ARROW_PARQUET``: Support for Apache Parquet file format * ``ARROW_PLASMA``: Shared memory object store -* ``ARROW_WITH_{BZ2, ZLIB, ZSTD, LZ4, SNAPPY, BROTLI}``: Build support for - compression libraries, used for reading and writing Parquet files and other - things. + +Anything set to ``ON`` above can also be turned off. Note that some compression +libraries are needed for Parquet support. If multiple versions of Python are installed in your environment, you may have to pass additional parameters to cmake so that it can find the right @@ -339,9 +336,6 @@ Now, build pyarrow: .. code-block:: shell pushd arrow/python - export PYARROW_WITH_FLIGHT=1 - export PYARROW_WITH_GANDIVA=1 - export PYARROW_WITH_ORC=1 export PYARROW_WITH_PARQUET=1 python setup.py build_ext --inplace popd @@ -361,6 +355,14 @@ libraries), one can set ``--bundle-arrow-cpp``: python setup.py build_ext --build-type=$ARROW_BUILD_TYPE \ --bundle-arrow-cpp bdist_wheel +Docker examples +~~~~~~~~~~~~~~~ + +If you are having difficulty building the Python library from source, take a +look at the ``python/examples/minimal_build`` directory which illustrates a +complete build and test from source both with the conda and pip/virtualenv +build methods. + Building with CUDA support ~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -462,7 +464,6 @@ Let's configure, build and install the Arrow C++ libraries: cmake -G "%PYARROW_CMAKE_GENERATOR%" ^ -DCMAKE_INSTALL_PREFIX=%ARROW_HOME% ^ -DARROW_CXXFLAGS="/WX /MP" ^ - -DARROW_GANDIVA=on ^ -DARROW_PARQUET=on ^ -DARROW_PYTHON=on ^ .. @@ -474,7 +475,6 @@ Now, we can build pyarrow: .. code-block:: shell pushd arrow\python - set PYARROW_WITH_GANDIVA=1 set PYARROW_WITH_PARQUET=1 python setup.py build_ext --inplace popd @@ -528,7 +528,6 @@ configuration of the Arrow C++ library build: cmake -G "%PYARROW_CMAKE_GENERATOR%" ^ -DCMAKE_INSTALL_PREFIX=%ARROW_HOME% ^ -DARROW_CXXFLAGS="/WX /MP" ^ - -DARROW_GANDIVA=on ^ -DARROW_PARQUET=on ^ -DARROW_PYTHON=on ^ -DARROW_BUILD_TESTS=ON ^ @@ -557,8 +556,6 @@ To run all tests of the Arrow C++ library, you can also run ``ctest``: ctest popd - - Windows Caveats --------------- diff --git a/python/examples/minimal_build/Dockerfile.fedora b/python/examples/minimal_build/Dockerfile.fedora index 2a25756d675..7dc329193c9 100644 --- a/python/examples/minimal_build/Dockerfile.fedora +++ b/python/examples/minimal_build/Dockerfile.fedora @@ -25,4 +25,7 @@ RUN dnf update -y && \ git \ wget \ make \ - ninja-build \ No newline at end of file + cmake \ + ninja-build \ + python3-devel \ + python3-virtualenv \ No newline at end of file diff --git a/python/examples/minimal_build/Dockerfile.ubuntu b/python/examples/minimal_build/Dockerfile.ubuntu index f93fab062c5..d7b84085e90 100644 --- a/python/examples/minimal_build/Dockerfile.ubuntu +++ b/python/examples/minimal_build/Dockerfile.ubuntu @@ -16,12 +16,23 @@ # under the License. FROM ubuntu:bionic -FROM fedora:31 ENV DEBIAN_FRONTEND=noninteractive RUN apt-get update -y -q && \ + apt-get install -y -q --no-install-recommends \ + apt-transport-https \ + software-properties-common \ + wget && \ apt-get install -y -q --no-install-recommends \ build-essential \ - cmake && \ + cmake \ + git \ + ninja-build \ + python3-dev \ + python3-pip && \ apt-get clean && rm -rf /var/lib/apt/lists* + +RUN pip3 install wheel && \ + pip3 install -U setuptools && \ + pip3 install wheel virtualenv \ No newline at end of file diff --git a/python/examples/minimal_build/README.md b/python/examples/minimal_build/README.md index a9af4c404c0..5164bd819de 100644 --- a/python/examples/minimal_build/README.md +++ b/python/examples/minimal_build/README.md @@ -20,4 +20,42 @@ # Minimal Python source build on Linux This directory shows how to bootstrap a local build from source on Linux with -an eye toward maximum portability across different Linux distributions. \ No newline at end of file +an eye toward maximum portability across different Linux distributions. This +may help for contributors debugging build issues caused by their local +environments. + +## Fedora 31 + +Build image: + +``` +docker build -t arrow_fedora_minimal -f Dockerfile.fedora +``` + +Build with conda or pip/virtualenv: + +``` +# With pip/virtualenv +docker run --rm -t -i -v $PWD:/io arrow_fedora_minimal /io/build_venv.sh + +# With conda +docker run --rm -t -i -v $PWD:/io arrow_fedora_minimal /io/build_conda.sh +``` + +## Ubuntu 18.04 + +Build image: + +``` +docker build -t arrow_ubuntu_minimal -f Dockerfile.ubuntu +``` + +Build with conda or pip/virtualenv: + +``` +# With pip/virtualenv +docker run --rm -t -i -v $PWD:/io arrow_ubuntu_minimal /io/build_venv.sh + +# With conda +docker run --rm -t -i -v $PWD:/io arrow_ubuntu_minimal /io/build_conda.sh +``` diff --git a/python/examples/minimal_build/build_conda.sh b/python/examples/minimal_build/build_conda.sh index 88e847a65e5..38da79b2c53 100755 --- a/python/examples/minimal_build/build_conda.sh +++ b/python/examples/minimal_build/build_conda.sh @@ -19,7 +19,7 @@ # Set $ARROW_ROOT to the path of your Arrow clone and run # docker build -t arrow_python_minimal . -# docker run --rm -t arrow_python_minimal -i -v $PWD:/io /io/build.sh +# docker run --rm -t -i -v $PWD:/io arrow_cpp_minimal /io/build.sh set -e @@ -92,9 +92,8 @@ cmake -GNinja \ -DARROW_WITH_SNAPPY=ON \ -DARROW_WITH_BROTLI=ON \ -DARROW_PARQUET=ON \ - -DARROW_PYTHON=ON \ -DARROW_PLASMA=ON \ - -DARROW_BUILD_TESTS=ON \ + -DARROW_PYTHON=ON \ $ARROW_ROOT/cpp ninja install diff --git a/python/examples/minimal_build/build_venv.sh b/python/examples/minimal_build/build_venv.sh new file mode 100755 index 00000000000..de66b23e44f --- /dev/null +++ b/python/examples/minimal_build/build_venv.sh @@ -0,0 +1,88 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Set $ARROW_ROOT to the path of your Arrow clone and run + +# docker build -t arrow_python_minimal . +# docker run --rm -t -i -v $PWD:/io arrow_cpp_minimal /io/build.sh + +set -e + +#---------------------------------------------------------------------- +# Change this to whatever makes sense for your system + +MINICONDA=$HOME/miniconda-for-arrow +LIBRARY_INSTALL_DIR=$HOME/local-libs +CPP_BUILD_DIR=$HOME/arrow-cpp-build +ARROW_ROOT=/arrow +export ARROW_HOME=/dist +export LD_LIBRARY_PATH=/dist/lib:$LD_LIBRARY_PATH + +git clone https://github.com/apache/arrow.git /arrow + +virtualenv /venv +source /venv/bin/activate + +pip install -r /arrow/python/requirements-build.txt \ + -r /arrow/python/requirements-test.txt + +#---------------------------------------------------------------------- +# Build C++ library + +mkdir -p $CPP_BUILD_DIR +pushd $CPP_BUILD_DIR + +cmake -GNinja \ + -DCMAKE_BUILD_TYPE=DEBUG \ + -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \ + -DCMAKE_INSTALL_LIBDIR=lib \ + -DARROW_WITH_BZ2=ON \ + -DARROW_WITH_ZLIB=ON \ + -DARROW_WITH_ZSTD=ON \ + -DARROW_WITH_LZ4=ON \ + -DARROW_WITH_SNAPPY=ON \ + -DARROW_WITH_BROTLI=ON \ + -DARROW_PARQUET=ON \ + -DARROW_PYTHON=ON \ + $ARROW_ROOT/cpp + +ninja install + +popd + +#---------------------------------------------------------------------- +# Build and test Python library +pushd $ARROW_ROOT/python + +rm -rf build/ # remove any pesky pre-existing build directory + +export PYARROW_BUILD_TYPE=Debug +export PYARROW_CMAKE_GENERATOR=Ninja +export PYARROW_WITH_PARQUET=1 + +# You can run either "develop" or "build_ext --inplace". Your pick + +# python setup.py build_ext --inplace +python setup.py develop + +# git submodules are required for unit tests +git submodule update --init +export PARQUET_TEST_DATA="$ARROW_ROOT/cpp/submodules/parquet-testing/data" +export ARROW_TEST_DATA="$ARROW_ROOT/testing/data" + +py.test pyarrow From 5cd691b0a3a3446120c0dce127497d9f721b418a Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Sun, 5 Apr 2020 00:02:52 -0500 Subject: [PATCH 4/4] Remove outdated comments --- python/examples/minimal_build/build_conda.sh | 5 ----- python/examples/minimal_build/build_venv.sh | 5 ----- 2 files changed, 10 deletions(-) diff --git a/python/examples/minimal_build/build_conda.sh b/python/examples/minimal_build/build_conda.sh index 38da79b2c53..6f93ebd5647 100755 --- a/python/examples/minimal_build/build_conda.sh +++ b/python/examples/minimal_build/build_conda.sh @@ -16,11 +16,6 @@ # specific language governing permissions and limitations # under the License. -# Set $ARROW_ROOT to the path of your Arrow clone and run - -# docker build -t arrow_python_minimal . -# docker run --rm -t -i -v $PWD:/io arrow_cpp_minimal /io/build.sh - set -e #---------------------------------------------------------------------- diff --git a/python/examples/minimal_build/build_venv.sh b/python/examples/minimal_build/build_venv.sh index de66b23e44f..b7dfc2061da 100755 --- a/python/examples/minimal_build/build_venv.sh +++ b/python/examples/minimal_build/build_venv.sh @@ -16,11 +16,6 @@ # specific language governing permissions and limitations # under the License. -# Set $ARROW_ROOT to the path of your Arrow clone and run - -# docker build -t arrow_python_minimal . -# docker run --rm -t -i -v $PWD:/io arrow_cpp_minimal /io/build.sh - set -e #----------------------------------------------------------------------