From e94ac803a2f3a9fb0a4e6b899a23c053685920ec Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 8 Apr 2020 10:26:10 -0700 Subject: [PATCH 1/5] Try to make windows R tests more verbose --- .github/workflows/r.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml index 5fe7fab9fcf..e87c5594cc0 100644 --- a/.github/workflows/r.yml +++ b/.github/workflows/r.yml @@ -151,6 +151,14 @@ jobs: uses: actions/checkout@v2 with: fetch-depth: 0 + - name: Make R tests verbose + shell: cmd + run: | + cd r/tests + sed -i.bak -E -e \ + 's/"arrow"/"arrow", reporter = "location"/' \ + testthat.R + rm -f testthat.R.bak - name: Fetch Submodules and Tags shell: bash run: ci/scripts/util_checkout.sh From f1f1f0790887e51d6495d57d954d660b3ad69d60 Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 8 Apr 2020 10:26:59 -0700 Subject: [PATCH 2/5] Make tests crash (revert me) --- r/tests/testthat/test-chunked-array.R | 2 ++ 1 file changed, 2 insertions(+) diff --git a/r/tests/testthat/test-chunked-array.R b/r/tests/testthat/test-chunked-array.R index c627fff3af1..889a312f99e 100644 --- a/r/tests/testthat/test-chunked-array.R +++ b/r/tests/testthat/test-chunked-array.R @@ -46,6 +46,8 @@ expect_chunked_roundtrip <- function(x, type) { invisible(a) } +stop("exit here") + test_that("ChunkedArray", { x <- expect_chunked_roundtrip(list(1:10, 1:10, 1:5), int32()) From 81079b5a49bbd671d690057fe5d932075f66412d Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 8 Apr 2020 11:17:34 -0700 Subject: [PATCH 3/5] Try single line sed --- .github/workflows/r.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml index e87c5594cc0..e0b6093e22b 100644 --- a/.github/workflows/r.yml +++ b/.github/workflows/r.yml @@ -155,9 +155,7 @@ jobs: shell: cmd run: | cd r/tests - sed -i.bak -E -e \ - 's/"arrow"/"arrow", reporter = "location"/' \ - testthat.R + sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "location"/' testthat.R rm -f testthat.R.bak - name: Fetch Submodules and Tags shell: bash From 1b2f9a60ef66cf10309ed7948410024eb5e8e1cb Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 8 Apr 2020 13:06:19 -0700 Subject: [PATCH 4/5] Revert "Make tests crash (revert me)" This reverts commit f1f1f0790887e51d6495d57d954d660b3ad69d60. --- r/tests/testthat/test-chunked-array.R | 2 -- 1 file changed, 2 deletions(-) diff --git a/r/tests/testthat/test-chunked-array.R b/r/tests/testthat/test-chunked-array.R index 889a312f99e..c627fff3af1 100644 --- a/r/tests/testthat/test-chunked-array.R +++ b/r/tests/testthat/test-chunked-array.R @@ -46,8 +46,6 @@ expect_chunked_roundtrip <- function(x, type) { invisible(a) } -stop("exit here") - test_that("ChunkedArray", { x <- expect_chunked_roundtrip(list(1:10, 1:10, 1:5), int32()) From c2b9245cfe70d6b5e674d31ba9cb69d74ef8bad6 Mon Sep 17 00:00:00 2001 From: Neal Richardson Date: Wed, 8 Apr 2020 14:50:22 -0700 Subject: [PATCH 5/5] See if turning off threading fixes windows --- r/tests/testthat/helper-arrow.R | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/r/tests/testthat/helper-arrow.R b/r/tests/testthat/helper-arrow.R index c330f51664c..bd35e1cb4c4 100644 --- a/r/tests/testthat/helper-arrow.R +++ b/r/tests/testthat/helper-arrow.R @@ -18,6 +18,11 @@ # Wrap testthat::test_that with a check for the C++ library options(..skip.tests = !arrow:::arrow_available()) +if (tolower(Sys.info()[["sysname"]]) == "windows") { + # See if this stabilizes tests; TODO fix the underlying issue + options(arrow.use_threads = FALSE) +} + test_that <- function(what, code) { testthat::test_that(what, { skip_if(getOption("..skip.tests", TRUE), "arrow C++ library not available")