From d1c6ea1c3509ccba7f076d13b1636675e107b7dd Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Mon, 1 Jun 2020 17:57:23 -0500 Subject: [PATCH] Set the default for Arity::VarArgs to 0 --- cpp/src/arrow/compute/function.h | 5 ++++- cpp/src/arrow/compute/function_test.cc | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cpp/src/arrow/compute/function.h b/cpp/src/arrow/compute/function.h index ed04b8916c2..90b529be10e 100644 --- a/cpp/src/arrow/compute/function.h +++ b/cpp/src/arrow/compute/function.h @@ -60,7 +60,10 @@ struct ARROW_EXPORT Arity { static Arity Ternary() { return Arity(3, false); } /// \brief A function taking a variable number of arguments - static Arity VarArgs(int min_args = 1) { return Arity(min_args, true); } + /// + /// \param[in] min_args the minimum number of arguments required when + /// invoking the function + static Arity VarArgs(int min_args = 0) { return Arity(min_args, true); } explicit Arity(int num_args, bool is_varargs = false) : num_args(num_args), is_varargs(is_varargs) {} diff --git a/cpp/src/arrow/compute/function_test.cc b/cpp/src/arrow/compute/function_test.cc index 5e48e8bbd09..576659d9331 100644 --- a/cpp/src/arrow/compute/function_test.cc +++ b/cpp/src/arrow/compute/function_test.cc @@ -48,7 +48,7 @@ TEST(Arity, Basics) { ASSERT_EQ(3, ternary.num_args); auto varargs = Arity::VarArgs(); - ASSERT_EQ(1, varargs.num_args); + ASSERT_EQ(0, varargs.num_args); ASSERT_TRUE(varargs.is_varargs); auto varargs2 = Arity::VarArgs(2);