From 852ceb4ecb1b500da9a84ade24ac9d0db7d06ad5 Mon Sep 17 00:00:00 2001 From: Kyle Weaver Date: Wed, 17 Feb 2021 13:38:13 -0800 Subject: [PATCH] [BEAM-11747] Disable BeamJavaUdfCalcRule. --- .../beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java | 3 ++- .../beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java index 13c8657f3d05..f47bd47822cd 100644 --- a/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java +++ b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java @@ -38,7 +38,8 @@ private BeamJavaUdfCalcRule() { @Override public boolean matches(RelOptRuleCall x) { - return ZetaSQLQueryPlanner.hasOnlyJavaUdfInProjects(x); + // TODO(BEAM-11747) Re-enable this rule when we can guarantee its correctness. + return false; } @Override diff --git a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java index a5d2a652eae1..9bbd4e6704f4 100644 --- a/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java +++ b/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java @@ -36,6 +36,7 @@ import org.codehaus.commons.compiler.CompileException; import org.joda.time.Duration; import org.junit.Before; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; @@ -49,6 +50,7 @@ * beam.sql.udf.test.empty_jar_path must be set. */ @RunWith(JUnit4.class) +@Ignore("TODO(BEAM-11747) Re-enable when BeamJavaUdfCalcRule can be re-enabled.") public class ZetaSqlJavaUdfTest extends ZetaSqlTestBase { @Rule public transient TestPipeline pipeline = TestPipeline.create(); @Rule public ExpectedException thrown = ExpectedException.none();