From 55f107af769e8ee09d8a98c420f8d031a7568417 Mon Sep 17 00:00:00 2001 From: Shehzaad Nakhoda Date: Tue, 23 Feb 2021 16:44:51 -0800 Subject: [PATCH 1/2] [BEAM-10961] enable strict dependency checking for sdks/java/io/bigquery-io-perf-tests --- sdks/java/io/bigquery-io-perf-tests/build.gradle | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sdks/java/io/bigquery-io-perf-tests/build.gradle b/sdks/java/io/bigquery-io-perf-tests/build.gradle index 8d5cf89195d3..61950b92ec27 100644 --- a/sdks/java/io/bigquery-io-perf-tests/build.gradle +++ b/sdks/java/io/bigquery-io-perf-tests/build.gradle @@ -17,7 +17,7 @@ */ plugins { id 'org.apache.beam.module' } -applyJavaNature(exportJavadoc: false, publish: false) +applyJavaNature(enableStrictDependencies:true,exportJavadoc: false, publish: false) provideIntegrationTestingDependencies() enableJavaPerformanceTesting() @@ -25,7 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: Google BigQuery IO Performance tes ext.summary = "Performance tests for Google BigQuery IO sources and sinks" dependencies { - compile library.java.google_api_services_bigquery + testImplementation library.java.google_api_services_bigquery testCompile project(path: ":sdks:java:core", configuration: "shadowTest") testCompile project(path: ":sdks:java:testing:test-utils", configuration: "testRuntime") testCompile project(path: ":sdks:java:extensions:google-cloud-platform-core", configuration: "testRuntime") @@ -34,7 +34,4 @@ dependencies { testCompile project(path: ":sdks:java:io:google-cloud-platform", configuration: "testRuntime") testCompile project(":sdks:java:io:synthetic") testCompile library.java.junit - testCompile library.java.hamcrest_core - testCompile library.java.jaxb_api - testCompile library.java.jaxb_impl } From 42e9b477771225b85e8308f7bd9d9bd0789a0d2c Mon Sep 17 00:00:00 2001 From: Shehzaad Nakhoda Date: Tue, 23 Feb 2021 21:34:49 -0800 Subject: [PATCH 2/2] [BEAM-10961] (1) nitpick: space (2) change testImplementation to testCompile --- sdks/java/io/bigquery-io-perf-tests/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdks/java/io/bigquery-io-perf-tests/build.gradle b/sdks/java/io/bigquery-io-perf-tests/build.gradle index 61950b92ec27..ee5c12332de1 100644 --- a/sdks/java/io/bigquery-io-perf-tests/build.gradle +++ b/sdks/java/io/bigquery-io-perf-tests/build.gradle @@ -17,7 +17,7 @@ */ plugins { id 'org.apache.beam.module' } -applyJavaNature(enableStrictDependencies:true,exportJavadoc: false, publish: false) +applyJavaNature(enableStrictDependencies: true, exportJavadoc: false, publish: false) provideIntegrationTestingDependencies() enableJavaPerformanceTesting() @@ -25,7 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: Google BigQuery IO Performance tes ext.summary = "Performance tests for Google BigQuery IO sources and sinks" dependencies { - testImplementation library.java.google_api_services_bigquery + testCompile library.java.google_api_services_bigquery testCompile project(path: ":sdks:java:core", configuration: "shadowTest") testCompile project(path: ":sdks:java:testing:test-utils", configuration: "testRuntime") testCompile project(path: ":sdks:java:extensions:google-cloud-platform-core", configuration: "testRuntime")