From c5b431e9c9dc8c2af6f8e4ecd0b0a001e18fcd18 Mon Sep 17 00:00:00 2001 From: Alexander Date: Mon, 27 Dec 2021 16:23:19 +0400 Subject: [PATCH 1/2] [BEAM-13558] Hid the Graph tab from output area & SCIO from SDK options --- .../frontend/lib/modules/output/components/output.dart | 2 +- .../frontend/lib/modules/output/components/output_area.dart | 2 +- .../output/components/output_header/output_tabs.dart | 2 +- .../frontend/lib/modules/sdk/components/sdk_selector.dart | 6 ++++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/playground/frontend/lib/modules/output/components/output.dart b/playground/frontend/lib/modules/output/components/output.dart index 526f3f15cbc1..026c2cafe509 100644 --- a/playground/frontend/lib/modules/output/components/output.dart +++ b/playground/frontend/lib/modules/output/components/output.dart @@ -26,7 +26,7 @@ class Output extends StatelessWidget { @override Widget build(BuildContext context) { return DefaultTabController( - length: 3, + length: 2, child: Column( children: const [OutputHeader(), Expanded(child: OutputArea())], ), diff --git a/playground/frontend/lib/modules/output/components/output_area.dart b/playground/frontend/lib/modules/output/components/output_area.dart index ede27168755c..c233d67c0855 100644 --- a/playground/frontend/lib/modules/output/components/output_area.dart +++ b/playground/frontend/lib/modules/output/components/output_area.dart @@ -38,7 +38,7 @@ class OutputArea extends StatelessWidget { children: [ OutputResult(text: state.result?.output ?? ''), OutputResult(text: state.result?.log ?? ''), - const Center(child: Text(kGraphText)), + // const Center(child: Text(kGraphText)), ], ); }, diff --git a/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart b/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart index 896f749d9cbf..eefe677b2e63 100644 --- a/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart +++ b/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart @@ -29,7 +29,7 @@ class OutputTabs extends StatelessWidget { tabs: [ Tab(text: 'Output'), Tab(text: 'Log'), - Tab(text: 'Graph'), + // Tab(text: 'Graph'), ], ), ); diff --git a/playground/frontend/lib/modules/sdk/components/sdk_selector.dart b/playground/frontend/lib/modules/sdk/components/sdk_selector.dart index 3259f0fd590a..40307f4af4a0 100644 --- a/playground/frontend/lib/modules/sdk/components/sdk_selector.dart +++ b/playground/frontend/lib/modules/sdk/components/sdk_selector.dart @@ -32,7 +32,7 @@ const kSdkSelectorLabel = 'Select SDK Dropdown'; const kEmptyExampleName = 'Catalog'; const double kWidth = 150; -const double kHeight = 172; +const double kHeight = 137; class SDKSelector extends StatelessWidget { final SDK sdk; @@ -58,7 +58,9 @@ class SDKSelector extends StatelessWidget { createDropdown: (close) => Column( children: [ const SizedBox(height: kMdSpacing), - ...SDK.values.map((SDK value) { + ...SDK.values + .where((element) => element != SDK.scio) + .map((SDK value) { return SizedBox( width: double.infinity, child: Consumer( From ef4660edee6f9fef5381b50663dabfd36f62237c Mon Sep 17 00:00:00 2001 From: Alexander Date: Tue, 28 Dec 2021 17:40:14 +0400 Subject: [PATCH 2/2] [BEAM-13515] Added clarifying comments --- .../frontend/lib/modules/output/components/output_area.dart | 1 + .../lib/modules/output/components/output_header/output_tabs.dart | 1 + playground/frontend/lib/modules/sdk/components/sdk_selector.dart | 1 + 3 files changed, 3 insertions(+) diff --git a/playground/frontend/lib/modules/output/components/output_area.dart b/playground/frontend/lib/modules/output/components/output_area.dart index c233d67c0855..cc9accdb9220 100644 --- a/playground/frontend/lib/modules/output/components/output_area.dart +++ b/playground/frontend/lib/modules/output/components/output_area.dart @@ -38,6 +38,7 @@ class OutputArea extends StatelessWidget { children: [ OutputResult(text: state.result?.output ?? ''), OutputResult(text: state.result?.log ?? ''), + // Not supported yet // const Center(child: Text(kGraphText)), ], ); diff --git a/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart b/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart index eefe677b2e63..24bd95e175b0 100644 --- a/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart +++ b/playground/frontend/lib/modules/output/components/output_header/output_tabs.dart @@ -29,6 +29,7 @@ class OutputTabs extends StatelessWidget { tabs: [ Tab(text: 'Output'), Tab(text: 'Log'), + // Not supported yet // Tab(text: 'Graph'), ], ), diff --git a/playground/frontend/lib/modules/sdk/components/sdk_selector.dart b/playground/frontend/lib/modules/sdk/components/sdk_selector.dart index 40307f4af4a0..6154d556c6c7 100644 --- a/playground/frontend/lib/modules/sdk/components/sdk_selector.dart +++ b/playground/frontend/lib/modules/sdk/components/sdk_selector.dart @@ -58,6 +58,7 @@ class SDKSelector extends StatelessWidget { createDropdown: (close) => Column( children: [ const SizedBox(height: kMdSpacing), + // SCIO is not supported yet ...SDK.values .where((element) => element != SDK.scio) .map((SDK value) {