From 1c448bd2d14d445b83eba4c45a2ba4e124c8b9cb Mon Sep 17 00:00:00 2001 From: Kenneth Knowles Date: Mon, 11 Apr 2016 15:20:34 -0700 Subject: [PATCH] Remove unused MergingTriggerContext#getFinishedMergingWindows method --- .../dataflow/sdk/transforms/windowing/Trigger.java | 3 --- .../dataflow/sdk/util/TriggerContextFactory.java | 11 ----------- 2 files changed, 14 deletions(-) diff --git a/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/Trigger.java b/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/Trigger.java index fde8ca4455c6..1eaf9e84910c 100644 --- a/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/Trigger.java +++ b/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/Trigger.java @@ -171,9 +171,6 @@ public interface MergingTriggerInfo extends TriggerInfo { /** Return true if the trigger is finished in all windows being merged. */ public abstract boolean finishedInAllMergingWindows(); - - /** Return the merging windows in which the trigger is finished. */ - public abstract Iterable getFinishedMergingWindows(); } /** diff --git a/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerContextFactory.java b/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerContextFactory.java index 5e2dc5ed9c5e..ce19162d5582 100644 --- a/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerContextFactory.java +++ b/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerContextFactory.java @@ -33,7 +33,6 @@ import com.google.common.collect.FluentIterable; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Iterables; -import com.google.common.collect.Maps; import org.joda.time.Instant; @@ -249,16 +248,6 @@ public boolean finishedInAllMergingWindows() { } return true; } - - @Override - public Iterable getFinishedMergingWindows() { - return Maps.filterValues(finishedSets, new Predicate() { - @Override - public boolean apply(FinishedTriggers finishedSet) { - return finishedSet.isFinished(trigger); - } - }).keySet(); - } } private class StateAccessorImpl implements StateAccessor {