From 2cd51f5001b2f8f1f79d6eb1f87cf1078c02a20a Mon Sep 17 00:00:00 2001 From: Kenneth Knowles Date: Mon, 17 Nov 2025 10:44:49 -0500 Subject: [PATCH 1/2] Remove SimpleDoFnRunner timestamp check --- .../java/org/apache/beam/runners/core/SimpleDoFnRunner.java | 1 - .../main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java index 9cce1f71f2a1..1db633d3a0a2 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java @@ -459,7 +459,6 @@ public void outputWindowedValue( .setPaneInfo(paneInfo) .setReceiver( wv -> { - checkTimestamp(elem.getTimestamp(), wv.getTimestamp()); SimpleDoFnRunner.this.outputWindowedValue(tag, wv); }) .output(); diff --git a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java index 1b7d75f6ec32..405464994f12 100644 --- a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java +++ b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java @@ -1860,7 +1860,7 @@ public OutputBuilder builder(OutputT value) { .withValue(value) .setReceiver( windowedValue -> { - checkTimestamp(windowedValue.getTimestamp()); + // checkTimestamp(windowedValue.getTimestamp()); outputTo(mainOutputConsumer, windowedValue); }); } From 145ff8f6c3b4f33cd79c27024d58d2f746761c95 Mon Sep 17 00:00:00 2001 From: Kenneth Knowles Date: Mon, 17 Nov 2025 10:51:19 -0500 Subject: [PATCH 2/2] Touch trigger files --- .../beam_PostCommit_Java_ValidatesRunner_Dataflow.json | 1 + .../beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json | 1 + .../beam_PostCommit_Java_ValidatesRunner_Direct.json | 1 + .../beam_PostCommit_Java_ValidatesRunner_Flink.json | 1 + .../beam_PostCommit_Java_ValidatesRunner_Spark.json | 1 + 5 files changed, 5 insertions(+) diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow.json index 2d05fc1b5d19..188f8e48c141 100644 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow.json +++ b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow.json @@ -1,4 +1,5 @@ { + "https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check", "https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder", "comment": "Modify this file in a trivial way to cause this test suite to run", "modification": 2, diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json index 24fc17d4c74a..001eb0fb7683 100644 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json +++ b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json @@ -1,4 +1,5 @@ { + "https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check", "https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder", "comment": "Modify this file in a trivial way to cause this test suite to run", "https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test", diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Direct.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Direct.json index 7e7462c0b059..fcd243625e7a 100644 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Direct.json +++ b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Direct.json @@ -1,4 +1,5 @@ { + "https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check", "https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder", "https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()", "https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners", diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json index afda4087adf8..bc8400e944ac 100644 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json +++ b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json @@ -1,4 +1,5 @@ { + "https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check", "https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder", "https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()", "https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners", diff --git a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json index f0c7c2ae3cfd..907d551718ef 100644 --- a/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json +++ b/.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json @@ -1,4 +1,5 @@ { + "https://github.com/apache/beam/pull/36822": "Testing removal of a timestamp check", "https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder", "https://github.com/apache/beam/pull/35213": "Eliminating getPane() in favor of getPaneInfo()", "https://github.com/apache/beam/pull/35177": "Introducing WindowedValueReceiver to runners",