From 32ecd233807c42e1206bb5f8cf4900ecba624fb0 Mon Sep 17 00:00:00 2001 From: Dan Halperin Date: Mon, 13 Jun 2016 17:34:58 -0700 Subject: [PATCH] CompressedSourceTest: simplify We should use random.nextBytes(buff) instead of making the array in a loop. The code we now point to is the same as the for loop, so the test continues to pass. --- .../java/org/apache/beam/sdk/io/CompressedSourceTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CompressedSourceTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CompressedSourceTest.java index 9b44386b9805..c34d2ddffa2e 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CompressedSourceTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CompressedSourceTest.java @@ -384,9 +384,7 @@ private byte[] generateInput(int size) { // Arbitrary but fixed seed Random random = new Random(285930); byte[] buff = new byte[size]; - for (int i = 0; i < size; i++) { - buff[i] = (byte) (random.nextInt() % Byte.MAX_VALUE); - } + random.nextBytes(buff); return buff; }