From 99408d929f5b88490934a5e498e1efcc61bda731 Mon Sep 17 00:00:00 2001 From: Pei He Date: Tue, 21 Jun 2016 15:25:06 -0700 Subject: [PATCH 1/3] Enable dependency-plugin at global level. --- examples/java/pom.xml | 13 ---- examples/java8/pom.xml | 14 ---- pom.xml | 23 +++--- runners/core-java/pom.xml | 13 ---- runners/direct-java/pom.xml | 13 ---- runners/flink/examples/pom.xml | 14 ++++ runners/flink/runner/pom.xml | 14 ++++ runners/google-cloud-dataflow-java/pom.xml | 13 ---- runners/spark/pom.xml | 88 ++++++++++++++++++++++ sdks/java/core/pom.xml | 15 ---- sdks/java/io/google-cloud-platform/pom.xml | 26 ++++++- sdks/java/io/hdfs/pom.xml | 32 ++++++++ sdks/java/io/kafka/pom.xml | 30 ++++++++ sdks/java/java8tests/pom.xml | 13 ---- 14 files changed, 217 insertions(+), 104 deletions(-) diff --git a/examples/java/pom.xml b/examples/java/pom.xml index cac985773bda..55b2ec849b5d 100644 --- a/examples/java/pom.xml +++ b/examples/java/pom.xml @@ -56,19 +56,6 @@ - - org.apache.maven.plugins - maven-dependency-plugin - - - analyze-only - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin diff --git a/examples/java8/pom.xml b/examples/java8/pom.xml index 08b811bc96e1..c5fe38545cd3 100644 --- a/examples/java8/pom.xml +++ b/examples/java8/pom.xml @@ -66,20 +66,6 @@ - - - org.apache.maven.plugins - maven-dependency-plugin - - - analyze-only - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin diff --git a/pom.xml b/pom.xml index 31beef175ef6..2bc92949748e 100644 --- a/pom.xml +++ b/pom.xml @@ -861,15 +861,6 @@ - - org.apache.maven.plugins - maven-dependency-plugin - 2.10 - - true - - - org.codehaus.mojo build-helper-maven-plugin @@ -918,6 +909,20 @@ + + org.apache.maven.plugins + maven-dependency-plugin + 2.10 + + + analyze-only + + true + true + + + + org.apache.maven.plugins maven-enforcer-plugin diff --git a/runners/core-java/pom.xml b/runners/core-java/pom.xml index 1587a1af36d2..8ee28744cc07 100644 --- a/runners/core-java/pom.xml +++ b/runners/core-java/pom.xml @@ -52,19 +52,6 @@ - - org.apache.maven.plugins - maven-dependency-plugin - - - analyze-only - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin diff --git a/runners/direct-java/pom.xml b/runners/direct-java/pom.xml index 3010757c1846..13e8951c1f0e 100644 --- a/runners/direct-java/pom.xml +++ b/runners/direct-java/pom.xml @@ -46,19 +46,6 @@ maven-compiler-plugin - - org.apache.maven.plugins - maven-dependency-plugin - - - analyze-only - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin diff --git a/runners/flink/examples/pom.xml b/runners/flink/examples/pom.xml index 1fba81cfec99..b0ee2ed04e68 100644 --- a/runners/flink/examples/pom.xml +++ b/runners/flink/examples/pom.xml @@ -96,6 +96,20 @@ maven-source-plugin + + org.apache.maven.plugins + maven-dependency-plugin + + + analyze-only + + + false + + + + + + false + + + + + diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml index 741f2db63c41..9a87e6a43a1e 100644 --- a/runners/spark/pom.xml +++ b/runners/spark/pom.xml @@ -127,6 +127,83 @@ auto-service true + + org.apache.hadoop + hadoop-common + 2.2.0 + provided + + + com.fasterxml.jackson.core + jackson-core + 2.7.2 + + + org.apache.hadoop + hadoop-mapreduce-client-core + 2.2.0 + provided + + + commons-io + commons-io + 2.4 + provided + + + com.fasterxml.jackson.core + jackson-annotations + 2.7.2 + + + org.apache.kafka + kafka-clients + 0.8.2.1 + provided + + + org.apache.avro + avro + 1.7.7 + + + org.slf4j + slf4j-api + 1.7.14 + + + joda-time + joda-time + 2.4 + + + org.apache.zookeeper + zookeeper + 3.4.6 + provided + + + org.apache.spark + spark-network-common_2.10 + 1.6.1 + provided + + + org.scala-lang + scala-library + 2.10.5 + provided + + + com.fasterxml.jackson.core + jackson-databind + 2.7.2 + + + com.google.http-client + google-http-client + 1.22.0 + org.apache.beam beam-sdks-java-core @@ -138,6 +215,17 @@ + + org.apache.beam + beam-runners-core-java + + + + org.slf4j + slf4j-jdk14 + + + org.apache.beam beam-examples-java diff --git a/sdks/java/core/pom.xml b/sdks/java/core/pom.xml index bbba77b29c0a..3b650c6da3e8 100644 --- a/sdks/java/core/pom.xml +++ b/sdks/java/core/pom.xml @@ -135,21 +135,6 @@ - - org.apache.maven.plugins - maven-dependency-plugin - - - - analyze-only - - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin diff --git a/sdks/java/io/google-cloud-platform/pom.xml b/sdks/java/io/google-cloud-platform/pom.xml index f567261af3c7..876f5e9b8e69 100644 --- a/sdks/java/io/google-cloud-platform/pom.xml +++ b/sdks/java/io/google-cloud-platform/pom.xml @@ -79,7 +79,31 @@ ${bigtable.version} - + + org.slf4j + slf4j-api + 1.7.14 + + + + com.google.guava + guava + 19.0 + + + + com.google.protobuf + protobuf-java + 3.0.0-beta-1 + + + + com.google.code.findbugs + jsr305 + 3.0.1 + + + org.apache.beam beam-sdks-java-core diff --git a/sdks/java/io/hdfs/pom.xml b/sdks/java/io/hdfs/pom.xml index 9c307922e2e5..8ebcf4641c59 100644 --- a/sdks/java/io/hdfs/pom.xml +++ b/sdks/java/io/hdfs/pom.xml @@ -57,6 +57,24 @@ beam-sdks-java-core + + com.fasterxml.jackson.core + jackson-annotations + 2.7.2 + + + + com.google.guava + guava + 19.0 + + + + com.google.code.findbugs + jsr305 + 3.0.1 + + org.apache.hadoop hadoop-client @@ -64,6 +82,20 @@ provided + + org.apache.hadoop + hadoop-common + 2.7.0 + provided + + + + org.apache.hadoop + hadoop-mapreduce-client-core + 2.7.0 + provided + + org.apache.beam diff --git a/sdks/java/io/kafka/pom.xml b/sdks/java/io/kafka/pom.xml index 76c0eb6f470c..7b28fcc9e234 100644 --- a/sdks/java/io/kafka/pom.xml +++ b/sdks/java/io/kafka/pom.xml @@ -69,6 +69,36 @@ 0.9.0.1 + + org.slf4j + slf4j-api + 1.7.14 + + + + joda-time + joda-time + 2.4 + + + + com.fasterxml.jackson.core + jackson-annotations + 2.7.2 + + + + com.google.guava + guava + 19.0 + + + + com.google.code.findbugs + jsr305 + 3.0.1 + + org.apache.beam diff --git a/sdks/java/java8tests/pom.xml b/sdks/java/java8tests/pom.xml index 8e20228a0b8e..775a7c7b1b60 100644 --- a/sdks/java/java8tests/pom.xml +++ b/sdks/java/java8tests/pom.xml @@ -51,19 +51,6 @@ maven-compiler-plugin - - org.apache.maven.plugins - maven-dependency-plugin - - - analyze-only - - true - - - - - org.apache.maven.plugins maven-checkstyle-plugin From ff5256b2f742798ee3d8b18690a34f8748c0060a Mon Sep 17 00:00:00 2001 From: Pei He Date: Thu, 23 Jun 2016 16:11:18 -0700 Subject: [PATCH 2/3] Update PR to use versions in dependencyManagement --- runners/spark/pom.xml | 79 ++++++++++------------ sdks/java/io/google-cloud-platform/pom.xml | 4 -- sdks/java/io/hdfs/pom.xml | 3 - sdks/java/io/kafka/pom.xml | 5 -- 4 files changed, 37 insertions(+), 54 deletions(-) diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml index 9a87e6a43a1e..0158e05c2717 100644 --- a/runners/spark/pom.xml +++ b/runners/spark/pom.xml @@ -35,6 +35,8 @@ UTF-8 UTF-8 1.6.1 + 2.2.0 + 0.8.2.1 @@ -112,10 +114,34 @@ ${spark.version} provided + + org.apache.spark + spark-network-common_2.10 + ${spark.version} + provided + org.apache.kafka kafka_2.10 - 0.8.2.1 + ${kafka.version} + provided + + + org.apache.kafka + kafka-clients + ${kafka.version} + provided + + + org.apache.hadoop + hadoop-common + ${hadoop.version} + provided + + + org.apache.hadoop + hadoop-mapreduce-client-core + ${hadoop.version} provided @@ -128,53 +154,38 @@ true - org.apache.hadoop - hadoop-common - 2.2.0 - provided + com.google.http-client + google-http-client com.fasterxml.jackson.core jackson-core - 2.7.2 - - - org.apache.hadoop - hadoop-mapreduce-client-core - 2.2.0 - provided - - - commons-io - commons-io - 2.4 - provided com.fasterxml.jackson.core jackson-annotations - 2.7.2 - - org.apache.kafka - kafka-clients - 0.8.2.1 - provided + + com.fasterxml.jackson.core + jackson-databind org.apache.avro avro - 1.7.7 org.slf4j slf4j-api - 1.7.14 joda-time joda-time + + + commons-io + commons-io 2.4 + provided org.apache.zookeeper @@ -182,28 +193,12 @@ 3.4.6 provided - - org.apache.spark - spark-network-common_2.10 - 1.6.1 - provided - org.scala-lang scala-library 2.10.5 provided - - com.fasterxml.jackson.core - jackson-databind - 2.7.2 - - - com.google.http-client - google-http-client - 1.22.0 - org.apache.beam beam-sdks-java-core diff --git a/sdks/java/io/google-cloud-platform/pom.xml b/sdks/java/io/google-cloud-platform/pom.xml index 876f5e9b8e69..5786e842d10a 100644 --- a/sdks/java/io/google-cloud-platform/pom.xml +++ b/sdks/java/io/google-cloud-platform/pom.xml @@ -82,25 +82,21 @@ org.slf4j slf4j-api - 1.7.14 com.google.guava guava - 19.0 com.google.protobuf protobuf-java - 3.0.0-beta-1 com.google.code.findbugs jsr305 - 3.0.1 diff --git a/sdks/java/io/hdfs/pom.xml b/sdks/java/io/hdfs/pom.xml index 8ebcf4641c59..9f4b38ac4741 100644 --- a/sdks/java/io/hdfs/pom.xml +++ b/sdks/java/io/hdfs/pom.xml @@ -60,19 +60,16 @@ com.fasterxml.jackson.core jackson-annotations - 2.7.2 com.google.guava guava - 19.0 com.google.code.findbugs jsr305 - 3.0.1 diff --git a/sdks/java/io/kafka/pom.xml b/sdks/java/io/kafka/pom.xml index 7b28fcc9e234..578026b52867 100644 --- a/sdks/java/io/kafka/pom.xml +++ b/sdks/java/io/kafka/pom.xml @@ -72,31 +72,26 @@ org.slf4j slf4j-api - 1.7.14 joda-time joda-time - 2.4 com.fasterxml.jackson.core jackson-annotations - 2.7.2 com.google.guava guava - 19.0 com.google.code.findbugs jsr305 - 3.0.1 From 670e3014b27c7431738030851a9702d6a5974ac0 Mon Sep 17 00:00:00 2001 From: Pei He Date: Fri, 24 Jun 2016 14:24:02 -0700 Subject: [PATCH 3/3] address comments --- pom.xml | 2 +- runners/spark/pom.xml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 2bc92949748e..aaca7a11a12b 100644 --- a/pom.xml +++ b/pom.xml @@ -860,7 +860,6 @@ - org.codehaus.mojo build-helper-maven-plugin @@ -917,6 +916,7 @@ analyze-only + true true diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml index 0158e05c2717..94c42bd663f6 100644 --- a/runners/spark/pom.xml +++ b/runners/spark/pom.xml @@ -203,7 +203,7 @@ org.apache.beam beam-sdks-java-core - + org.slf4j slf4j-jdk14 @@ -214,7 +214,7 @@ org.apache.beam beam-runners-core-java - + org.slf4j slf4j-jdk14 @@ -225,7 +225,7 @@ org.apache.beam beam-examples-java - + org.slf4j slf4j-jdk14