From 72529a4273815f85c48b2b7350af256008a9c053 Mon Sep 17 00:00:00 2001 From: cclauss Date: Mon, 9 Jul 2018 07:41:37 +0200 Subject: [PATCH] [BEAM-3959] Add Python 3 undefined names to flake8 As soon as #5843 and #5900 are closed, we should add F821 (undefined names) tests to the flake8 tests on Python 3. This should flag commits that contain unqualified past.builtin imports such as basestring, cmp, raw_input, reload, unicode, xrange, etc. --- sdks/python/scripts/run_mini_py3lint.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sdks/python/scripts/run_mini_py3lint.sh b/sdks/python/scripts/run_mini_py3lint.sh index 63e71771d734..0729c7ba2cfc 100755 --- a/sdks/python/scripts/run_mini_py3lint.sh +++ b/sdks/python/scripts/run_mini_py3lint.sh @@ -48,5 +48,4 @@ if test $# -gt 0; then fi echo "Running flake8 for module $MODULE:" -# TODO(BEAM-3959): Add F821 (undefined names) as soon as that test passes -flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics +flake8 $MODULE --count --select=E9,F821,F822,F823 --show-source --statistics