From fb1ce7439d7d491f9e935a3cd4d9326aea9c1ea7 Mon Sep 17 00:00:00 2001 From: yjhjstz Date: Thu, 8 Jun 2023 09:21:48 +0800 Subject: [PATCH 01/11] Update issue template and PR template --- .github/ISSUE_TEMPLATE/bug-report.md | 27 ++++++++++------------- .github/ISSUE_TEMPLATE/feature-request.md | 21 +++++++++++------- .github/pull_request_template.md | 21 +++++++++++++++--- 3 files changed, 43 insertions(+), 26 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index 01114a54625..6bdfce9bd58 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -1,21 +1,18 @@ --- -name: "\U0001F41B Bug Report" -about: As a user, I want to report a bug. -labels: "type: bug" ---- - -## Bug Report - -### Greenplum version or build +name: Bug Report +about: Create a report to help us improve +labels: type/bug -### OS version and uname -a - -### autoconf options used ( config.status --config ) +--- -### Installation information ( pg_config ) +### Steps to reproduce the behavior (Required) +Please provide detailed steps, such as SQL commands or operations on the database. -### Expected behavior +### Expected behavior (Required) +A clear and concise description of what you expected to happen. -### Actual behavior +### Real behavior (Required) +A clear and concise description of what actually happened. -### Step to reproduce the behavior +### CloudberryDB version (Required) +Please provide the version of CloudberryDB you're using. diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index c8b975b96e2..9ece5a73c62 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -1,13 +1,18 @@ --- -name: "\U0001F680 Feature Request" -about: As a user, I want to request a new feature. -labels: "type: feature" +name: Feature Request +about: Suggest an idea for this project +labels: type/feature-request + --- -## Feature Request +## Feature request +Is your feature request related to a problem? Please describe. + +## Describe the solution you'd like +A clear and concise description of what you want to happen. -**Is your feature request related to a problem? Please describe:** - +## Describe alternatives you've considered +A clear and concise description of any alternative solutions or features you've considered. -**Describe the feature you'd like to request:** - +## Additional context +Add any other context or screenshots about the feature request here. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5e62f3832ac..d852eb36e64 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,21 @@ -## Here are some reminders before you submit the pull request +## Here are some reminders before you submit the pull request: + - [ ] Add tests for the change - [ ] Document changes - [ ] Communicate in the mailing list if needed -- [ ] Pass `make installcheck` -- [ ] Review a PR in return to support the community +- [ ] Pass make installcheck +- [ ] Pass make -C src/test installcheck-cbdb-parallel + +--- + +**What changes were proposed in this pull request?** +Please provide a clear and concise description of the changes, including what problem is being solved or what feature is being added. + +**Why are the changes needed?** +Please clarify why the changes are necessary. + +**Does this PR introduce any user-facing change?** +If yes, please clarify the previous behavior and the change this PR proposes. + +**How was this patch tested?** +Please detail how the changes were tested, including manual tests and any relevant unit or integration tests. From 8fe984387aa5e1a01c24e875c67f99f0b82fc80c Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Thu, 15 Jun 2023 11:10:12 +0800 Subject: [PATCH 02/11] Update ISSUE and Pull Request templates (#3) For a better user and developer experience, update the Issue and PR templates. Files changed: * Add bug-report.yml * Modify pull_request_template.md * Delete bug-report.md * Delete enhancement.md * Delete feature-request.md --- .github/ISSUE_TEMPLATE/bug-report.md | 18 ------ .github/ISSUE_TEMPLATE/bug-report.yml | 67 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/config.yml | 22 ++++++-- .github/ISSUE_TEMPLATE/enhancement.md | 7 --- .github/ISSUE_TEMPLATE/feature-request.md | 18 ------ .github/pull_request_template.md | 44 ++++++++++----- 6 files changed, 113 insertions(+), 63 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/bug-report.yml delete mode 100644 .github/ISSUE_TEMPLATE/enhancement.md delete mode 100644 .github/ISSUE_TEMPLATE/feature-request.md diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md deleted file mode 100644 index 6bdfce9bd58..00000000000 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ /dev/null @@ -1,18 +0,0 @@ ---- -name: Bug Report -about: Create a report to help us improve -labels: type/bug - ---- - -### Steps to reproduce the behavior (Required) -Please provide detailed steps, such as SQL commands or operations on the database. - -### Expected behavior (Required) -A clear and concise description of what you expected to happen. - -### Real behavior (Required) -A clear and concise description of what actually happened. - -### CloudberryDB version (Required) -Please provide the version of CloudberryDB you're using. diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml new file mode 100644 index 00000000000..94d546da79c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -0,0 +1,67 @@ +name: "\U0001F41B Bug Report" +description: Problems and issues with code in Cloudberry Database core. +title: "[Bug] " +labels: ["bug"] +body: + - type: markdown + attributes: + value: "Thank you for reporting the problem! We really appreciate your efforts to improve Cloudberry Database. Before reporting it, please (ideally) test on the latest release or main to see if the issue is fixed." + - type: textarea + attributes: + label: Cloudberry Database version + description: What version are you using? + - type: textarea + attributes: + label: What happened + description: Describe what happened. + placeholder: > + Please provide the context in which the problem occurred and explain what happened + validations: + required: true + - type: textarea + attributes: + label: What you think should happen instead + description: What do you think went wrong? + placeholder: > + Please explain why you think the behaviour is erroneous. It is extremely helpful if you copy&paste the fragment of logs showing the exact error messages or wrong behaviour. If you can provide some screenshots or videos, you can include files by dragging and dropping them here. + - type: textarea + attributes: + label: How to reproduce + description: > + What should we do to reproduce the problem? Any SQL commmands or operations? + placeholder: > + Please make sure you provide a reproducible step-by-step case of how to reproduce the problem as minimally and precisely as possible. Remember that non-reproducible issues will be closed! Opening a discussion is recommended as a first step. + validations: + required: true + - type: input + attributes: + label: Operating System + description: What Operating System are you using? + placeholder: "You can get it via `cat /etc/os-release` for example" + validations: + required: true + - type: textarea + attributes: + label: Anything else + description: Anything else we need to know? + placeholder: > + How often does this problem occur? (Once? Every time? Only when certain conditions are met?) Any relevant logs to include? Put them here. + - type: checkboxes + attributes: + label: Are you willing to submit PR? + description: > + This is absolutely not required, but we are happy to guide you in the contribution process especially if you already have a good understanding of how to implement the fix. + options: + - label: Yes, I am willing to submit a PR! + - type: checkboxes + attributes: + label: Code of Conduct + description: By submitting this issue, you agree to follow our [Code of Conduct](https://cloudberrydb.org/community/coc). + options: + - label: > + I agree to follow this project's + [Code of Conduct](https://cloudberrydb.org/community/coc). + required: true + - type: markdown + attributes: + value: "Thanks for completing our form!" \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 9e38b59fb02..c19c305c2b5 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,7 +1,17 @@ +blank_issues_enabled: false contact_links: - - name: Join Greenplum users mailing list - url: https://groups.google.com/a/greenplum.org/g/gpdb-users - about: Please ask general questions here. - - name: Join Greenplum developers mailing list - url: https://groups.google.com/a/greenplum.org/g/gpdb-dev - about: Please ask developing questions here. + - name: 🙏🏻Q&A @ GitHub Discussions + url: https://github.com/orgs/cloudberrydb/discussions/categories/q-a + about: Ask for help when running/developing Cloudberry Database. + - name: 💡️New Ideas / Feature Requests + url: https://github.com/orgs/cloudberrydb/discussions/categories/ideas-feature-requests + about: Share ideas for new features. + - name: 🎙️RFC(Request For Comments) + url: https://github.com/orgs/cloudberrydb/discussions/categories/rfc + about: As a developer, proposing any major change or enhancement to Cloudberry Database. + - name: 💬️Join Cloudberry Database @ Slack for Real-time Chat + url: https://communityinviter.com/apps/cloudberrydb/welcome + about: Real-time chat including QA, Dev, Events and more. + - name: 🪲Issues for Website, Docs + url: https://github.com/cloudberrydb/cloudberrydb-site/issues + about: Hey, we have one dedicated repo for the website and docs. diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md deleted file mode 100644 index 74a11d329bc..00000000000 --- a/.github/ISSUE_TEMPLATE/enhancement.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -name: "\U0001F680 Enhancement" -about: As a developer, I want to make an enhancement. -labels: "type: enhancement" ---- - -## Enhancement diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md deleted file mode 100644 index 9ece5a73c62..00000000000 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ /dev/null @@ -1,18 +0,0 @@ ---- -name: Feature Request -about: Suggest an idea for this project -labels: type/feature-request - ---- - -## Feature request -Is your feature request related to a problem? Please describe. - -## Describe the solution you'd like -A clear and concise description of what you want to happen. - -## Describe alternatives you've considered -A clear and concise description of any alternative solutions or features you've considered. - -## Additional context -Add any other context or screenshots about the feature request here. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d852eb36e64..50019b44ac8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,21 +1,37 @@ -## Here are some reminders before you submit the pull request: + -- [ ] Add tests for the change -- [ ] Document changes -- [ ] Communicate in the mailing list if needed -- [ ] Pass make installcheck -- [ ] Pass make -C src/test installcheck-cbdb-parallel + +closes: #ISSUE + --- -**What changes were proposed in this pull request?** -Please provide a clear and concise description of the changes, including what problem is being solved or what feature is being added. +### Change logs -**Why are the changes needed?** -Please clarify why the changes are necessary. +_Describe your change clearly, including what problem is being solved or what feature is being added._ -**Does this PR introduce any user-facing change?** -If yes, please clarify the previous behavior and the change this PR proposes. +### Why are the changes needed? -**How was this patch tested?** -Please detail how the changes were tested, including manual tests and any relevant unit or integration tests. +_Describe why the changes are necessary._ + +### Does this PR introduce any user-facing change? + +_If yes, please clarify the previous behavior and the change this PR proposes._ + +### How was this patch tested? + +_Please detail how the changes were tested, including manual tests and any relevant unit or integration tests._ + +### Contributor's Checklist +Here are some reminders before you submit the pull request: +* Document changes +* Communicate in the [GitHub Issues](https://github.com/cloudberrydb/cloudberrydb/issues) or [Discussions](https://github.com/orgs/cloudberrydb/discussions) (list them if needed) +* Add tests for the change +* Pass `make installcheck` +* Pass `make -C src/test installcheck-cbdb-parallel` + + From 3c18f4962e8aaaddd336afa293c4b0f9ebebbf0e Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Thu, 15 Jun 2023 11:13:12 +0800 Subject: [PATCH 03/11] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 94d546da79c..f05f4b215f4 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -1,4 +1,4 @@ -name: "\U0001F41B Bug Report" +name: "Bug Report" description: Problems and issues with code in Cloudberry Database core. title: "[Bug] " labels: ["bug"] @@ -64,4 +64,4 @@ body: required: true - type: markdown attributes: - value: "Thanks for completing our form!" \ No newline at end of file + value: "Thanks for completing our form!" From 4302bb30cee18a674b51a2dc8522ef9d7db5b2bf Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Thu, 15 Jun 2023 11:34:19 +0800 Subject: [PATCH 04/11] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index f05f4b215f4..6c71278a839 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -1,4 +1,4 @@ -name: "Bug Report" +name: "\U0001F41B Bug Report" description: Problems and issues with code in Cloudberry Database core. title: "[Bug] " labels: ["bug"] @@ -53,7 +53,7 @@ body: This is absolutely not required, but we are happy to guide you in the contribution process especially if you already have a good understanding of how to implement the fix. options: - label: Yes, I am willing to submit a PR! - - type: checkboxes + - type: checkboxes attributes: label: Code of Conduct description: By submitting this issue, you agree to follow our [Code of Conduct](https://cloudberrydb.org/community/coc). From c6f15573b681eb2c2072ded7a1697b7a00a0f612 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Thu, 15 Jun 2023 11:37:28 +0800 Subject: [PATCH 05/11] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 6c71278a839..ef9c1935148 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -56,7 +56,7 @@ body: - type: checkboxes attributes: label: Code of Conduct - description: By submitting this issue, you agree to follow our [Code of Conduct](https://cloudberrydb.org/community/coc). + description: The Code of Conduct helps create a safe space for everyone. We require that everyone agrees to it. options: - label: > I agree to follow this project's From da99498dd6a9043f380646c242110c1a80dc3275 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Fri, 16 Jun 2023 10:03:35 +0800 Subject: [PATCH 06/11] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index c19c305c2b5..e97e88987d0 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,17 +1,17 @@ blank_issues_enabled: false contact_links: - - name: 🙏🏻Q&A @ GitHub Discussions + - name: 🙏🏻 Q&A url: https://github.com/orgs/cloudberrydb/discussions/categories/q-a about: Ask for help when running/developing Cloudberry Database. - - name: 💡️New Ideas / Feature Requests + - name: 💡️ New Ideas / Feature Requests url: https://github.com/orgs/cloudberrydb/discussions/categories/ideas-feature-requests about: Share ideas for new features. - - name: 🎙️RFC(Request For Comments) + - name: 🎙️ RFC(Request For Comments) url: https://github.com/orgs/cloudberrydb/discussions/categories/rfc about: As a developer, proposing any major change or enhancement to Cloudberry Database. - - name: 💬️Join Cloudberry Database @ Slack for Real-time Chat + - name: 💬️ Join Slack for Real-time Chat url: https://communityinviter.com/apps/cloudberrydb/welcome about: Real-time chat including QA, Dev, Events and more. - - name: 🪲Issues for Website, Docs + - name: 🪲 Issues for Website, Docs url: https://github.com/cloudberrydb/cloudberrydb-site/issues about: Hey, we have one dedicated repo for the website and docs. From 0a25ca000294ab36015a785c11079576f1238c25 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Fri, 16 Jun 2023 10:18:55 +0800 Subject: [PATCH 07/11] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index ef9c1935148..71ce3692eca 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -23,12 +23,12 @@ body: label: What you think should happen instead description: What do you think went wrong? placeholder: > - Please explain why you think the behaviour is erroneous. It is extremely helpful if you copy&paste the fragment of logs showing the exact error messages or wrong behaviour. If you can provide some screenshots or videos, you can include files by dragging and dropping them here. + Please explain why you think the behavior is erroneous. It is extremely helpful if you copy&paste the fragment of logs showing the exact error messages or wrong behavior. If you can provide some screenshots or videos, you can include files by dragging and dropping them here. - type: textarea attributes: label: How to reproduce description: > - What should we do to reproduce the problem? Any SQL commmands or operations? + What should we do to reproduce the problem? Any SQL commands or operations? placeholder: > Please make sure you provide a reproducible step-by-step case of how to reproduce the problem as minimally and precisely as possible. Remember that non-reproducible issues will be closed! Opening a discussion is recommended as a first step. validations: @@ -50,7 +50,7 @@ body: attributes: label: Are you willing to submit PR? description: > - This is absolutely not required, but we are happy to guide you in the contribution process especially if you already have a good understanding of how to implement the fix. + This is absolutely not required, but we are happy to guide you in the contribution process, especially if you already understand how to implement the fix. options: - label: Yes, I am willing to submit a PR! - type: checkboxes From 52779e01adabbd60da745e9a7483be2ba962bedd Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Fri, 16 Jun 2023 10:32:00 +0800 Subject: [PATCH 08/11] Add Discussion template Yaml for Ideas and RFC --- .github/DISCUSSION_TEMPLATE/ideas.yml | 29 ++++++++++++ .github/DISCUSSION_TEMPLATE/rfc.yml | 65 +++++++++++++++++++++++++++ 2 files changed, 94 insertions(+) create mode 100644 .github/DISCUSSION_TEMPLATE/ideas.yml create mode 100644 .github/DISCUSSION_TEMPLATE/rfc.yml diff --git a/.github/DISCUSSION_TEMPLATE/ideas.yml b/.github/DISCUSSION_TEMPLATE/ideas.yml new file mode 100644 index 00000000000..e3bc6e46374 --- /dev/null +++ b/.github/DISCUSSION_TEMPLATE/ideas.yml @@ -0,0 +1,29 @@ +title: "[Ideas] " +labels: ["enhancement"] +body: + - type: markdown + attributes: + value: "Thanks for sharing your idea or proposing new features!" + - type: textarea + attributes: + label: Description + description: A short description of your feature. + - type: textarea + attributes: + label: Use case/motivation + description: What would you like to happen? + placeholder: > + Rather than telling us how you might implement this feature, try to take a + step back and describe what you are trying to achieve. + - type: textarea + attributes: + label: Related issues + description: Is there currently another issue associated with this? + - type: checkboxes + attributes: + label: Are you willing to submit a PR? + options: + - label: Yes I am willing to submit a PR! + - type: markdown + attributes: + value: "Thanks for sharing!" diff --git a/.github/DISCUSSION_TEMPLATE/rfc.yml b/.github/DISCUSSION_TEMPLATE/rfc.yml new file mode 100644 index 00000000000..a3d30a95f89 --- /dev/null +++ b/.github/DISCUSSION_TEMPLATE/rfc.yml @@ -0,0 +1,65 @@ +title: "[RFC] " +body: + - type: markdown + attributes: + value: " + + Thanks for proposing major changes to Cloudberry Database! + + When changes are just minor updates, general bug fixes, just Pull Request directly! + + When you just have one idea or more `casual` feature request, consider choosing [Ideas / Feature Requests](https://github.com/orgs/cloudberrydb/discussions/new?category=ideas-feature-requests). + + But any of the following can be considered a major change that needs to have RFC. + + * Any change that impacts the public interfaces of the project. + + * Any new component, module or code that introduces a new concept into the project or alters the behavior of an existing one + + * Any large code refactor to address general code re-usability and structure. + " + - type: textarea + attributes: + label: Proposers + description: What can we call you or you guys, list you and your co-author if has. + - type: dropdown + attributes: + label: RFC Status + multiple: false + options: + - "Under Discussion" + - "In Progress" + - "Completed" + - "Inactive" + - "Abandoned" + validations: + required: true + - type: textarea + attributes: + label: Abstract + description: A clear and concise description of what the change is. + validations: + required: true + - type: textarea + attributes: + label: Motivation + description: Please outline the motivation and why it should be implemented. + validations: + required: true + - type: textarea + attributes: + label: Implementation + description: How to implement your RFC? Including the principle, design, plans, etc. + validations: + required: true + - type: textarea + attributes: + label: Rollout/Adoption Plan + - type: checkboxes + attributes: + label: Are you willing to submit a PR? + options: + - label: Yes I am willing to submit a PR! + - type: markdown + attributes: + value: "Thanks for your RFC! Now invite more people to have feedback!" From 7a68c520e76d7bc3cd04abbc247c84f9260a7bf6 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Fri, 16 Jun 2023 10:59:30 +0800 Subject: [PATCH 09/11] Update pull_request_template - Add compatibility reminder --- .github/pull_request_template.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 50019b44ac8..e9b9f4ffcfb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,7 +3,7 @@ Thank you for contributing! ***If you're the first time contributor, please sign the Contributor License Agreement(CLA).*** --> - + closes: #ISSUE @@ -13,6 +13,8 @@ closes: #ISSUE _Describe your change clearly, including what problem is being solved or what feature is being added._ +_If it has some breaking backward or forward compatibility, please clary._ + ### Why are the changes needed? _Describe why the changes are necessary._ From ef9a8eecc4739dae1839e868cf0bb8f03476a405 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Mon, 19 Jun 2023 11:37:15 +0800 Subject: [PATCH 10/11] Update and rename rfc.yml to proposal.yml --- .github/DISCUSSION_TEMPLATE/{rfc.yml => proposal.yml} | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) rename .github/DISCUSSION_TEMPLATE/{rfc.yml => proposal.yml} (87%) diff --git a/.github/DISCUSSION_TEMPLATE/rfc.yml b/.github/DISCUSSION_TEMPLATE/proposal.yml similarity index 87% rename from .github/DISCUSSION_TEMPLATE/rfc.yml rename to .github/DISCUSSION_TEMPLATE/proposal.yml index a3d30a95f89..a2b8888324d 100644 --- a/.github/DISCUSSION_TEMPLATE/rfc.yml +++ b/.github/DISCUSSION_TEMPLATE/proposal.yml @@ -1,4 +1,4 @@ -title: "[RFC] " +title: "[Proposal] " body: - type: markdown attributes: @@ -10,7 +10,7 @@ body: When you just have one idea or more `casual` feature request, consider choosing [Ideas / Feature Requests](https://github.com/orgs/cloudberrydb/discussions/new?category=ideas-feature-requests). - But any of the following can be considered a major change that needs to have RFC. + But any of the following can be considered a major change that needs to have **Proposal**. * Any change that impacts the public interfaces of the project. @@ -24,7 +24,7 @@ body: description: What can we call you or you guys, list you and your co-author if has. - type: dropdown attributes: - label: RFC Status + label: Proposal Status multiple: false options: - "Under Discussion" @@ -49,7 +49,7 @@ body: - type: textarea attributes: label: Implementation - description: How to implement your RFC? Including the principle, design, plans, etc. + description: How to implement your proposal? Including the principle, design, plans, etc. validations: required: true - type: textarea @@ -62,4 +62,4 @@ body: - label: Yes I am willing to submit a PR! - type: markdown attributes: - value: "Thanks for your RFC! Now invite more people to have feedback!" + value: "Thanks for your proposal! Now invite more people to have feedback!" From 2ab29a46115ecc051d8c3c4531563e73ddf144f9 Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Mon, 19 Jun 2023 11:44:31 +0800 Subject: [PATCH 11/11] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index e97e88987d0..1e47358b3cc 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -6,8 +6,8 @@ contact_links: - name: 💡️ New Ideas / Feature Requests url: https://github.com/orgs/cloudberrydb/discussions/categories/ideas-feature-requests about: Share ideas for new features. - - name: 🎙️ RFC(Request For Comments) - url: https://github.com/orgs/cloudberrydb/discussions/categories/rfc + - name: 🎙️ Submit Your Proposal + url: https://github.com/orgs/cloudberrydb/discussions/categories/proposal about: As a developer, proposing any major change or enhancement to Cloudberry Database. - name: 💬️ Join Slack for Real-time Chat url: https://communityinviter.com/apps/cloudberrydb/welcome