From 424c29a5b4b0670346cd385505ee14e0fa813dfd Mon Sep 17 00:00:00 2001 From: Dianjin Wang Date: Tue, 25 Jul 2023 10:15:29 +0800 Subject: [PATCH] Doc: update Pull_Request template for contributor Update the contributor's checklist type from a bulleted list to a task list, so that contributors can check them before/when they submit PRs. See: Discussion#20 --- .github/pull_request_template.md | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e9b9f4ffcfb..cf290dd1c67 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,7 @@ - + -closes: #ISSUE +closes: #ISSUE_Number --- @@ -28,12 +25,14 @@ _If yes, please clarify the previous behavior and the change this PR proposes._ _Please detail how the changes were tested, including manual tests and any relevant unit or integration tests._ ### Contributor's Checklist -Here are some reminders before you submit the pull request: -* Document changes -* Communicate in the [GitHub Issues](https://github.com/cloudberrydb/cloudberrydb/issues) or [Discussions](https://github.com/orgs/cloudberrydb/discussions) (list them if needed) -* Add tests for the change -* Pass `make installcheck` -* Pass `make -C src/test installcheck-cbdb-parallel` - - + +Here are some reminders and checklists before/when submitting your pull request, please check them: + +- [ ] Make sure your Pull Request has a clear title and commit message. You can take [git-commit](https://github.com/cloudberrydb/cloudberrydb/blob/main/.gitmessage) template as a reference. +- [ ] Sign the Contributor License Agreement as prompted for your first-time contribution. +- [ ] List your communication in the [GitHub Issues](https://github.com/cloudberrydb/cloudberrydb/issues) or [Discussions](https://github.com/orgs/cloudberrydb/discussions) (if has or needed). +- [ ] Document changes. +- [ ] Add tests for the change +- [ ] Pass `make installcheck` +- [ ] Pass `make -C src/test installcheck-cbdb-parallel` +- [ ] Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳