From 45594e1c055c33b0dc10606281cea8ff676e7360 Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Tue, 15 Oct 2019 09:44:45 +0000 Subject: [PATCH] kvm: fix issue that network rules for secondary IPs are not applied When I add a secondary IP to a nic on shared network in advanced zone with security groups, the network rules for new IP are not applied on KVM hypervisors. It is because "--action -A" cannot be recognized in security_group.py after commit ac73e7e671ba107830f96b9fb534eb716956e405. changing to "--action=-A" will fix it. --- .../cloud/hypervisor/kvm/resource/LibvirtComputingResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java index b20f1a58b949..07461393c60a 100644 --- a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java +++ b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java @@ -3638,7 +3638,7 @@ public boolean configureNetworkRulesVMSecondaryIP(final Connect conn, final Stri cmd.add("network_rules_vmSecondaryIp"); cmd.add("--vmname", vmName); cmd.add("--nicsecips", secIp); - cmd.add("--action", action); + cmd.add("--action=" + action); final String result = cmd.execute(); if (result != null) {